)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b6a90745242e2644e981707ef24076ff2210748a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"xenapi: clean up step decorator fake steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In vmops.py there are some fake methods to adjuste the number"},{"line_number":10,"context_line":"of steps used for a resize up/down."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":" + This patch adds to the method used to create steps two new private"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F828I%3D","line":9,"updated":"2013-12-19 14:16:09.000000000","message":"adjuste \u003d\u003e adjust","commit_id":"b94300c4c84e4905008c76095fdcff1e0ae113d9"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0d5f512c6d565f3f41a091fcebe8bf0b336643f3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"xenapi: clean up step decorator fake steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In vmops.py there are some fake methods to adjuste the number"},{"line_number":10,"context_line":"of steps used for a resize up/down."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":" + This patch adds to the method used to create steps two new private"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F8240%3D","line":9,"in_reply_to":"AAAATn%2F828I%3D","updated":"2013-12-19 14:27:38.000000000","message":"Done","commit_id":"b94300c4c84e4905008c76095fdcff1e0ae113d9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b6a90745242e2644e981707ef24076ff2210748a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"of steps used for a resize up/down."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":" + This patch adds to the method used to create steps two new private"},{"line_number":13,"context_line":"   parameters used to adjuste offset of current and total steps."},{"line_number":14,"context_line":" + This patch also adds a missing test for a successful resize down."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I506045442d893e91b03ce33e4aab9930966c8ec2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F8274%3D","line":13,"updated":"2013-12-19 14:16:09.000000000","message":"adjuste  \u003d\u003e adjust","commit_id":"b94300c4c84e4905008c76095fdcff1e0ae113d9"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0d5f512c6d565f3f41a091fcebe8bf0b336643f3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"of steps used for a resize up/down."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":" + This patch adds to the method used to create steps two new private"},{"line_number":13,"context_line":"   parameters used to adjuste offset of current and total steps."},{"line_number":14,"context_line":" + This patch also adds a missing test for a successful resize down."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I506045442d893e91b03ce33e4aab9930966c8ec2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F824w%3D","line":13,"in_reply_to":"AAAATn%2F8274%3D","updated":"2013-12-19 14:27:38.000000000","message":"Done","commit_id":"b94300c4c84e4905008c76095fdcff1e0ae113d9"}],"nova/tests/virt/xenapi/test_vmops.py":[{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"244dc937c3bd3ff7941dd88c75a3869adbf5dacd","unresolved":false,"context_lines":[{"line_number":675,"context_line":"                                    dest, sr_path, 0)]"},{"line_number":676,"context_line":"        self.assertEqual(m_vhd_expected, mock_migrate_vhd.call_args_list)"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        prog_expected \u003d ["},{"line_number":679,"context_line":"            mock.call(context, instance, 1, 5),"},{"line_number":680,"context_line":"            mock.call(context, instance, 2, 5),"},{"line_number":681,"context_line":"            mock.call(context, instance, 3, 5),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2F0Wg%3D","line":678,"updated":"2013-12-30 21:39:12.000000000","message":"Having thought about this some more.  I\u0027m not leaning towards changing this to be 4 steps.  \n\nso calls would expect (1,4), (2,4), (3,4), and (4,4)...\n\nIf we don\u0027t use finish migration any more let\u0027s just get rid of it from the step process?","commit_id":"aec170eb6125604be7205917a33647cfa1767558"}],"nova/tests/virt/xenapi/test_xenapi.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c5978d806a67b96d4b10261ed1587d9d6ce4f814","unresolved":false,"context_lines":[{"line_number":1857,"context_line":"        vm_utils.resize_disk(vmops._session, instance, old_vdi_ref,"},{"line_number":1858,"context_line":"            flavor).AndReturn((new_vdi_ref, new_vdi_uuid))"},{"line_number":1859,"context_line":"        virtapi.instance_update(self.context, \u0027uuid\u0027, {\u0027progress\u0027: 60.0})"},{"line_number":1860,"context_line":""},{"line_number":1861,"context_line":"        vm_utils.migrate_vhd(vmops._session, instance, new_vdi_uuid, dest,"},{"line_number":1862,"context_line":"                             sr_path, 0).AndRaise("},{"line_number":1863,"context_line":"                                exception.ResizeError(reason\u003d\"asdf\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2BE8w%3D","line":1860,"updated":"2014-01-30 12:12:30.000000000","message":"please remove this unrelated change, if you need to rebase, etc.","commit_id":"83c1ac6098b1c16bbb42271f33011fba9a433787"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"6fc87329036efb5143fdb6ea00b455060eb99390","unresolved":false,"context_lines":[{"line_number":1857,"context_line":"        vm_utils.resize_disk(vmops._session, instance, old_vdi_ref,"},{"line_number":1858,"context_line":"            flavor).AndReturn((new_vdi_ref, new_vdi_uuid))"},{"line_number":1859,"context_line":"        virtapi.instance_update(self.context, \u0027uuid\u0027, {\u0027progress\u0027: 60.0})"},{"line_number":1860,"context_line":""},{"line_number":1861,"context_line":"        vm_utils.migrate_vhd(vmops._session, instance, new_vdi_uuid, dest,"},{"line_number":1862,"context_line":"                             sr_path, 0).AndRaise("},{"line_number":1863,"context_line":"                                exception.ResizeError(reason\u003d\"asdf\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2BEzw%3D","line":1860,"in_reply_to":"AAAAUH%2F%2BE8w%3D","updated":"2014-01-30 12:28:11.000000000","message":"Done","commit_id":"83c1ac6098b1c16bbb42271f33011fba9a433787"}],"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"801b4eb0bb65ac1277d008c471953b282783443b","unresolved":false,"context_lines":[{"line_number":817,"context_line":""},{"line_number":818,"context_line":"        undo_mgr \u003d utils.UndoManager()"},{"line_number":819,"context_line":"        try:"},{"line_number":820,"context_line":"            fake_step_to_match_resizing_up()"},{"line_number":821,"context_line":"            rename_and_power_off_vm(undo_mgr)"},{"line_number":822,"context_line":"            old_vdi_ref, _ignore \u003d vm_utils.get_vdi_for_vm_safely("},{"line_number":823,"context_line":"                self._session, vm_ref)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F82LQ%3D","side":"PARENT","line":820,"updated":"2013-12-19 16:06:44.000000000","message":"This seems bad, we want a progress bump before attempting the power off, so the user knows we are doing something.","commit_id":"7d79f458d6935bd7939a7c7d3b15d114e85268f2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"801b4eb0bb65ac1277d008c471953b282783443b","unresolved":false,"context_lines":[{"line_number":971,"context_line":"                    self._session, instance, vm_ref, label) as root_vdi_uuids:"},{"line_number":972,"context_line":"                # NOTE(johngarbutt) snapshot attached here will delete"},{"line_number":973,"context_line":"                # the snapshot if an error occurs"},{"line_number":974,"context_line":"                fake_step_to_show_snapshot_complete()"},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"                # transfer all the non-active VHDs in the root disk chain"},{"line_number":977,"context_line":"                active_root_vdi_uuid \u003d transfer_immutable_vhds(root_vdi_uuids)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F82Ks%3D","side":"PARENT","line":974,"updated":"2013-12-19 16:06:44.000000000","message":"Same here, this is to show progress to the user, its here to trigger a progress update, we still need that progress update to be sent I feel.","commit_id":"7d79f458d6935bd7939a7c7d3b15d114e85268f2"},{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"897628ebdcbeba7c150e813d3caf6370192ed299","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def make_step_decorator(context, instance, update_instance_progress,"},{"line_number":111,"context_line":"                        _current\u003d0, _total\u003d0):"},{"line_number":112,"context_line":"    \"\"\"Factory to create a decorator that records instance progress as a series"},{"line_number":113,"context_line":"    of discrete steps."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F82iw%3D","line":111,"updated":"2013-12-19 15:23:35.000000000","message":"_total as an argument name here isn\u0027t really accurate.  It\u0027s an offset or total_start...  Given the @step is going to increment total, it isn\u0027t what I expected (see below).","commit_id":"d1db72bb7e1fcfebee8ae13c9171200f631d0a43"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"3a17c1a738ee2e52bfc08dc03336671c0c2c0398","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def make_step_decorator(context, instance, update_instance_progress,"},{"line_number":111,"context_line":"                        _current\u003d0, _total\u003d0):"},{"line_number":112,"context_line":"    \"\"\"Factory to create a decorator that records instance progress as a series"},{"line_number":113,"context_line":"    of discrete steps."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F82dE%3D","line":111,"in_reply_to":"AAAATn%2F82iw%3D","updated":"2013-12-19 15:35:26.000000000","message":"Yes you\u0027re probably right, during the development i chose \"offset\" but changed at the end to be coherent with the variables.\n\n\"_offset\" works for you?","commit_id":"d1db72bb7e1fcfebee8ae13c9171200f631d0a43"},{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"897628ebdcbeba7c150e813d3caf6370192ed299","unresolved":false,"context_lines":[{"line_number":778,"context_line":"        step \u003d make_step_decorator(context, instance,"},{"line_number":779,"context_line":"                                   self._update_instance_progress,"},{"line_number":780,"context_line":"                                   _current\u003d1,"},{"line_number":781,"context_line":"                                   _total\u003d2)"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"        @step"},{"line_number":784,"context_line":"        def rename_and_power_off_vm(undo_mgr):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F82lE%3D","line":781,"updated":"2013-12-19 15:23:35.000000000","message":"it took me a while to determine that 2 was the correct count even though there are \"5\" steps in the process.","commit_id":"d1db72bb7e1fcfebee8ae13c9171200f631d0a43"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c5978d806a67b96d4b10261ed1587d9d6ce4f814","unresolved":false,"context_lines":[{"line_number":107,"context_line":"DEVICE_CD \u003d \u00271\u0027"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def make_step_decorator(context, instance, update_instance_progress, offset\u003d0):"},{"line_number":111,"context_line":"    \"\"\"Factory to create a decorator that records instance progress as a series"},{"line_number":112,"context_line":"    of discrete steps."},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2BE5s%3D","line":110,"updated":"2014-01-30 12:12:30.000000000","message":"I think offset if the wrong word... it feels like you start at the offset, but you actually start at zero.\n\nHmm, maybe just total_steps would be much better.\n\nThere is actually used to be a constance somewhere for RESIZE_STEPS or something like that, which could be passed in here.","commit_id":"83c1ac6098b1c16bbb42271f33011fba9a433787"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"6fc87329036efb5143fdb6ea00b455060eb99390","unresolved":false,"context_lines":[{"line_number":107,"context_line":"DEVICE_CD \u003d \u00271\u0027"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def make_step_decorator(context, instance, update_instance_progress, offset\u003d0):"},{"line_number":111,"context_line":"    \"\"\"Factory to create a decorator that records instance progress as a series"},{"line_number":112,"context_line":"    of discrete steps."},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2BEzs%3D","line":110,"in_reply_to":"AAAAUH%2F%2BE5s%3D","updated":"2014-01-30 12:28:11.000000000","message":"Done","commit_id":"83c1ac6098b1c16bbb42271f33011fba9a433787"}]}