)]}'
{"nova/tests/unit/objects/test_compute_node.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9286b5dbe3fc38b1cb204b496151dc5ff2b61108","unresolved":false,"context_lines":[{"line_number":451,"context_line":"        versions \u003d ovo_base.obj_tree_get_versions(\u0027ComputeNode\u0027)"},{"line_number":452,"context_line":"        primitive \u003d compute.obj_to_primitive(target_version\u003d\u00271.4\u0027,"},{"line_number":453,"context_line":"                                             version_manifest\u003dversions)"},{"line_number":454,"context_line":"        self.assertNotIn(\u0027numa_topology\u0027, primitive[\u0027nova_object.data\u0027])"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    def test_compat_supported_hv_specs(self):"},{"line_number":457,"context_line":"        compute \u003d compute_node.ComputeNode()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_73f176cd","line":454,"range":{"start_line":454,"start_character":0,"end_line":454,"end_character":72},"updated":"2019-01-16 11:42:28.000000000","message":"Can we add a positive test for version 1.5 to prevent this happening again. It\u0027s not the first time this has happened and I doubt it\u0027ll be the last\n\nDitto for the rest of the these changes","commit_id":"e7ae769cc7cee0406d5819ca7aa88c69ccec9a0a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2f0f7a70fedb92f167d29489fc53a0397d104f57","unresolved":false,"context_lines":[{"line_number":451,"context_line":"        versions \u003d ovo_base.obj_tree_get_versions(\u0027ComputeNode\u0027)"},{"line_number":452,"context_line":"        primitive \u003d compute.obj_to_primitive(target_version\u003d\u00271.4\u0027,"},{"line_number":453,"context_line":"                                             version_manifest\u003dversions)"},{"line_number":454,"context_line":"        self.assertNotIn(\u0027numa_topology\u0027, primitive[\u0027nova_object.data\u0027])"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    def test_compat_supported_hv_specs(self):"},{"line_number":457,"context_line":"        compute \u003d compute_node.ComputeNode()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_bee7a512","line":454,"range":{"start_line":454,"start_character":0,"end_line":454,"end_character":72},"in_reply_to":"bfdaf3ff_73f176cd","updated":"2019-01-16 13:55:49.000000000","message":"\u003e  It\u0027s not the first time this has happened and I\n \u003e doubt it\u0027ll be the last\n \u003e \n\nAnd this is not the only place where it is wrong. I\u0027m going through nova to fix all of it... :)\n\nI\u0027ve added the positive cases anyhow.","commit_id":"e7ae769cc7cee0406d5819ca7aa88c69ccec9a0a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"88646b5cdda34a31f6d86e0c5f7b77943ad4ba41","unresolved":false,"context_lines":[{"line_number":454,"context_line":"        self.assertNotIn(\u0027numa_topology\u0027, primitive[\u0027nova_object.data\u0027])"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        primitive \u003d compute.obj_to_primitive(target_version\u003d\u00271.5\u0027,"},{"line_number":457,"context_line":"                                             version_manifest\u003dversions)"},{"line_number":458,"context_line":"        self.assertIn(\u0027numa_topology\u0027, primitive[\u0027nova_object.data\u0027])"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def test_compat_supported_hv_specs(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfdaf3ff_193febd6","line":457,"range":{"start_line":457,"start_character":45,"end_line":457,"end_character":70},"updated":"2019-01-16 14:22:26.000000000","message":"How come you need this here","commit_id":"1e7cc87b6608907b8e315342178d1cc2ab9001e9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2526d33742287abc512ed4da8557a7bb94fadd49","unresolved":false,"context_lines":[{"line_number":454,"context_line":"        self.assertNotIn(\u0027numa_topology\u0027, primitive[\u0027nova_object.data\u0027])"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        primitive \u003d compute.obj_to_primitive(target_version\u003d\u00271.5\u0027,"},{"line_number":457,"context_line":"                                             version_manifest\u003dversions)"},{"line_number":458,"context_line":"        self.assertIn(\u0027numa_topology\u0027, primitive[\u0027nova_object.data\u0027])"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def test_compat_supported_hv_specs(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_630b1c8e","line":457,"range":{"start_line":457,"start_character":45,"end_line":457,"end_character":70},"in_reply_to":"bfdaf3ff_193febd6","updated":"2019-01-22 16:31:16.000000000","message":"Copied from the same thing above.","commit_id":"1e7cc87b6608907b8e315342178d1cc2ab9001e9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"88646b5cdda34a31f6d86e0c5f7b77943ad4ba41","unresolved":false,"context_lines":[{"line_number":472,"context_line":"    @mock.patch(\u0027nova.objects.service.Service.get_by_compute_host\u0027)"},{"line_number":473,"context_line":"    def test_compat_host(self, mock_get_compute):"},{"line_number":474,"context_line":"        compute \u003d compute_node.ComputeNode(host\u003d\u0027fake-host\u0027)"},{"line_number":475,"context_line":"        primitive \u003d compute.obj_to_primitive(target_version\u003d\u00271.6\u0027)"},{"line_number":476,"context_line":"        self.assertNotIn(\u0027host\u0027, primitive[\u0027nova_object.data\u0027])"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        primitive \u003d compute.obj_to_primitive(target_version\u003d\u00271.7\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfdaf3ff_b9257fc4","line":475,"updated":"2019-01-16 14:22:26.000000000","message":"But not here?","commit_id":"1e7cc87b6608907b8e315342178d1cc2ab9001e9"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a4ab528ebaea702b7861f8d721cf0e845e027cd0","unresolved":false,"context_lines":[{"line_number":472,"context_line":"    @mock.patch(\u0027nova.objects.service.Service.get_by_compute_host\u0027)"},{"line_number":473,"context_line":"    def test_compat_host(self, mock_get_compute):"},{"line_number":474,"context_line":"        compute \u003d compute_node.ComputeNode(host\u003d\u0027fake-host\u0027)"},{"line_number":475,"context_line":"        primitive \u003d compute.obj_to_primitive(target_version\u003d\u00271.6\u0027)"},{"line_number":476,"context_line":"        self.assertNotIn(\u0027host\u0027, primitive[\u0027nova_object.data\u0027])"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        primitive \u003d compute.obj_to_primitive(target_version\u003d\u00271.7\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfdaf3ff_2b505632","line":475,"in_reply_to":"bfdaf3ff_b9257fc4","updated":"2019-01-16 15:03:29.000000000","message":"I think the version manifest is used to traverse subobject. As compute node has subobjects we need to pass the manifest. This test does not fail as we are not checking the proper backporting of a subobject.\n\nSo in a real situation we would need to pass a manifest but it is OK not to pass it here.","commit_id":"1e7cc87b6608907b8e315342178d1cc2ab9001e9"}]}