)]}'
{"nova/api/openstack/compute/plugins/v3/server_metadata.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"962b065b13cc19db1f6ad57382d631f236ffde26","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        try:"},{"line_number":195,"context_line":"            server \u003d self.compute_api.get(context, server_id,"},{"line_number":196,"context_line":"                                          want_objects\u003dTrue)"},{"line_number":197,"context_line":"            self.compute_api.delete_instance_metadata(context, server, id)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        except exception.InstanceNotFound:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FeAE%3D","line":196,"updated":"2014-01-13 15:32:09.000000000","message":"As the title, this patch only change for update_instance_metadata","commit_id":"30a439cccc1edabc81ff1fb22a319b0b3b25ef55"}],"nova/compute/api.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"b075bc9960891404107a17d780773447ea110324","unresolved":false,"context_lines":[{"line_number":2818,"context_line":"                          task_state\u003dNone)"},{"line_number":2819,"context_line":"    def delete_instance_metadata(self, context, instance, key):"},{"line_number":2820,"context_line":"        \"\"\"Delete the given metadata item from an instance.\"\"\""},{"line_number":2821,"context_line":"        instance.metadata \u003d {}"},{"line_number":2822,"context_line":"        self.db.instance_metadata_delete(context, instance[\u0027uuid\u0027], key)"},{"line_number":2823,"context_line":"        instance[\u0027metadata\u0027] \u003d {}"},{"line_number":2824,"context_line":"        notifications.send_update(context, instance, instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2FzoU%3D","line":2821,"updated":"2013-12-31 05:46:32.000000000","message":"This is also 2 lines down..  And it leaves the field \u0027dirty\u0027.  Using instance_metadata_delete is definitely more efficient than doing an instance.save() though.  I wonder if we should add a \u0027metadata_delete\u0027 helper method to the Instance object that can do the more efficient DB call and also 0 out the metadata field properly?","commit_id":"159bb478c80bb0069fffe87792bdd8dc477d8423"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"962b065b13cc19db1f6ad57382d631f236ffde26","unresolved":false,"context_lines":[{"line_number":2873,"context_line":"        metadata \u003d self.db.instance_metadata_update(context, instance[\u0027uuid\u0027],"},{"line_number":2874,"context_line":"                                         _metadata, True)"},{"line_number":2875,"context_line":"        instance[\u0027metadata\u0027] \u003d metadata"},{"line_number":2876,"context_line":"        notifications.send_update(context, instance, instance)"},{"line_number":2877,"context_line":"        diff \u003d _diff_dict(orig, _metadata)"},{"line_number":2878,"context_line":"        self.compute_rpcapi.change_instance_metadata(context,"},{"line_number":2879,"context_line":"                                                     instance\u003dinstance,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FeDs%3D","side":"PARENT","line":2876,"updated":"2014-01-13 15:32:09.000000000","message":"we needn\u0027t this notification anymore?","commit_id":"c2a204b79ca013d28cd651b2ff7b5e9795596a3c"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"0eeec4b9cb53e18829957791edce23bbf8cbfdf5","unresolved":false,"context_lines":[{"line_number":2873,"context_line":"        metadata \u003d self.db.instance_metadata_update(context, instance[\u0027uuid\u0027],"},{"line_number":2874,"context_line":"                                         _metadata, True)"},{"line_number":2875,"context_line":"        instance[\u0027metadata\u0027] \u003d metadata"},{"line_number":2876,"context_line":"        notifications.send_update(context, instance, instance)"},{"line_number":2877,"context_line":"        diff \u003d _diff_dict(orig, _metadata)"},{"line_number":2878,"context_line":"        self.compute_rpcapi.change_instance_metadata(context,"},{"line_number":2879,"context_line":"                                                     instance\u003dinstance,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Fd9c%3D","side":"PARENT","line":2876,"in_reply_to":"AAAAUH%2F%2FeDs%3D","updated":"2014-01-13 15:37:52.000000000","message":"oops, sorry, looks like it invoke at instance.save(). I think I need go to bed now...","commit_id":"c2a204b79ca013d28cd651b2ff7b5e9795596a3c"}],"nova/compute/rpcapi.py":[{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"84e19086ede650e4821f80f78cdcc207c89a85e9","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        else:"},{"line_number":310,"context_line":"            # NOTE(russellb) Havana compat"},{"line_number":311,"context_line":"            version \u003d self._get_compat_version(\u00273.0\u0027, \u00272.0\u0027)"},{"line_number":312,"context_line":"            instance \u003d jsonutils.to_primitive(instance)"},{"line_number":313,"context_line":"        cctxt \u003d self.client.prepare(server\u003d_compute_host(None, instance),"},{"line_number":314,"context_line":"                version\u003dversion)"},{"line_number":315,"context_line":"        cctxt.cast(ctxt, \u0027change_instance_metadata\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2FqS4%3D","line":312,"updated":"2014-01-03 22:39:51.000000000","message":"I noticed several same code here to decide if we should use object or dict. Have you ever consider to use a decorator for it?","commit_id":"278d6932b7d1807ec1cd40d73f7757335441d409"}]}