)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"10e98d1f3e78679430c42e6bfc1356cdc663caad","unresolved":false,"context_lines":[{"line_number":1540,"context_line":"        except Exception:"},{"line_number":1541,"context_line":"            return False"},{"line_number":1542,"context_line":""},{"line_number":1543,"context_line":"        if cur \u003d\u003d end and cur !\u003d 0 and end !\u003d 0:"},{"line_number":1544,"context_line":"            return False"},{"line_number":1545,"context_line":"        else:"},{"line_number":1546,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2F4nE%3D","line":1543,"updated":"2014-01-07 08:44:58.000000000","message":"to me it seems we should change this to return False if both are 0, and not do ant guessing above. this just seems way to convoluted to not mess it up again in the future.\n\nAm I missing a case why we can\u0027t do this?","commit_id":"5a03390ba1f28dfbadd37578ba59f111d4c4ba4c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"fe0b1eb0b5242257211c1e42d89c13c8e562f73f","unresolved":false,"context_lines":[{"line_number":1540,"context_line":"        except Exception:"},{"line_number":1541,"context_line":"            return False"},{"line_number":1542,"context_line":""},{"line_number":1543,"context_line":"        if cur \u003d\u003d end and cur !\u003d 0 and end !\u003d 0:"},{"line_number":1544,"context_line":"            return False"},{"line_number":1545,"context_line":"        else:"},{"line_number":1546,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2F1BU%3D","line":1543,"in_reply_to":"AAAAUH%2F%2F4nE%3D","updated":"2014-01-08 00:03:15.000000000","message":"This seems fine to me, but I\u0027m also wondering whether there\u0027s a corner case here already where libvirt could return something like {cur\u003d1000, end\u003d1000} before the job is \"finalized\", and we flag it as done too early.\n\nNot sure if that is possible.","commit_id":"5a03390ba1f28dfbadd37578ba59f111d4c4ba4c"}]}
