)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6bd0133f4374c5a4524922155402a3ee376fdfc0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Change-Id: I890b2c81cd49c1c601e9baee6a249709d0f6810e"},{"line_number":30,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":31,"context_line":"Closes-Bug: #1810977"},{"line_number":32,"context_line":"(cherry picked from commit fd19aeafbce0fa11821b2a064bd694b078613c2f)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_7ae8807b","line":32,"range":{"start_line":32,"start_character":27,"end_line":32,"end_character":67},"updated":"2019-02-21 16:22:57.000000000","message":"This should really be b24ad3780bc872d1a17907909cd6bcbea7e804b3 but looking at b24ad3780bc872d1a17907909cd6bcbea7e804b3 that\u0027s PS4 on the change in master and the only difference from that and this commit is what looks to be a rebase, so functionally the changes are the same.","commit_id":"780ccfcbdea919b196c18372d1c66bc88b4fa48c"}],"nova/objects/numa.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6e862279454cdcc866d7c56f0fe3217c07499663","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                   cpu_usage\u003dcpu_usage, memory_usage\u003dmemory_usage,"},{"line_number":138,"context_line":"                   mempages\u003d[], pinned_cpus\u003dset([]), siblings\u003d[])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def can_fit_pagesize(self, pagesize, memory, use_free\u003dTrue):"},{"line_number":141,"context_line":"        \"\"\"Returns whether memory can fit into a given pagesize."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        :param pagesize: a page size in KibB"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_093b0f9c","line":140,"range":{"start_line":140,"start_character":0,"end_line":140,"end_character":64},"updated":"2019-01-25 13:51:01.000000000","message":"Stupid o.vo question time, changing this signature doesn\u0027t break us if we pass around NUMACell objects between  stable/rocky services with and without this change right?\n\nI\u0027m not even sure that we pass NUMACell objects around but just wanted to check that if we did this wouldn\u0027t break us.","commit_id":"780ccfcbdea919b196c18372d1c66bc88b4fa48c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8b9c53e2d3c84df2ddc7a185f46996358ab5750e","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                   cpu_usage\u003dcpu_usage, memory_usage\u003dmemory_usage,"},{"line_number":138,"context_line":"                   mempages\u003d[], pinned_cpus\u003dset([]), siblings\u003d[])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def can_fit_pagesize(self, pagesize, memory, use_free\u003dTrue):"},{"line_number":141,"context_line":"        \"\"\"Returns whether memory can fit into a given pagesize."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        :param pagesize: a page size in KibB"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_4917d7ee","line":140,"range":{"start_line":140,"start_character":0,"end_line":140,"end_character":64},"in_reply_to":"9fdfeff1_093b0f9c","updated":"2019-01-25 13:55:52.000000000","message":"Nah, we should be good\n\n\u003clyarwood\u003e stephenfin: https://review.openstack.org/#/c/633197/1/nova/objects/numa.py - stupid o.vo question in there if you have a second, I assume it\u0027s fine just wanted to check.\n\u003csean-k-mooney\u003e lyarwood: it should not no\n\u003csean-k-mooney\u003e lyarwood: the function signitru is part of the class deffinion not the serialised object\n\u003cstephenfin\u003e lyarwood: Yeah, what Sean says. The scheduler, for example, will use its own version of the object\n\u003clyarwood\u003e sean-k-mooney: right, wasn\u0027t sure so it was worth asking. Thanks.\n\u003cstephenfin\u003e *definition","commit_id":"780ccfcbdea919b196c18372d1c66bc88b4fa48c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"4b8c80da8e4be74d057b53d698416e9d447de90d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                   cpu_usage\u003dcpu_usage, memory_usage\u003dmemory_usage,"},{"line_number":138,"context_line":"                   mempages\u003d[], pinned_cpus\u003dset([]), siblings\u003d[])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def can_fit_pagesize(self, pagesize, memory, use_free\u003dTrue):"},{"line_number":141,"context_line":"        \"\"\"Returns whether memory can fit into a given pagesize."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        :param pagesize: a page size in KibB"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_69d09b20","line":140,"range":{"start_line":140,"start_character":0,"end_line":140,"end_character":64},"in_reply_to":"9fdfeff1_4917d7ee","updated":"2019-01-25 13:57:25.000000000","message":"ACK thanks again.","commit_id":"780ccfcbdea919b196c18372d1c66bc88b4fa48c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6bd0133f4374c5a4524922155402a3ee376fdfc0","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                   cpu_usage\u003dcpu_usage, memory_usage\u003dmemory_usage,"},{"line_number":138,"context_line":"                   mempages\u003d[], pinned_cpus\u003dset([]), siblings\u003d[])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def can_fit_pagesize(self, pagesize, memory, use_free\u003dTrue):"},{"line_number":141,"context_line":"        \"\"\"Returns whether memory can fit into a given pagesize."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        :param pagesize: a page size in KibB"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_9aa0c444","line":140,"range":{"start_line":140,"start_character":0,"end_line":140,"end_character":64},"in_reply_to":"9fdfeff1_69d09b20","updated":"2019-02-21 16:22:57.000000000","message":"If this were remotable then we\u0027d have a problem, but the objects version test would catch it if the version had not been bumped.","commit_id":"780ccfcbdea919b196c18372d1c66bc88b4fa48c"}]}