)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c5ed7cba30cd24685257386b21adc01f065f3635","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change InstanceFaultRollback handling in _error_out_instance_on_exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For some reason, only NotImplementedError in _error_out_instance_on_exception"},{"line_number":10,"context_line":"would use the $instance_state parameter which can be controller by the"},{"line_number":11,"context_line":"caller of the context manager to determine the rollback vm_state. But in the"},{"line_number":12,"context_line":"case of InstanceFaultRollback, the caller may want to reset the vm_state"},{"line_number":13,"context_line":"back to something other than ACTIVE, like if the instance is actually"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_49a7d750","line":10,"range":{"start_line":10,"start_character":53,"end_line":10,"end_character":63},"updated":"2019-01-25 14:25:48.000000000","message":"controlled","commit_id":"0901a6ad806b07ca37f7358fa5511ce605ebf844"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c5ed7cba30cd24685257386b21adc01f065f3635","unresolved":false,"context_lines":[{"line_number":11,"context_line":"caller of the context manager to determine the rollback vm_state. But in the"},{"line_number":12,"context_line":"case of InstanceFaultRollback, the caller may want to reset the vm_state"},{"line_number":13,"context_line":"back to something other than ACTIVE, like if the instance is actually"},{"line_number":14,"context_line":"STOPPED and somehting like prep_resize fails (you can resize a STOPPED"},{"line_number":15,"context_line":"instance)."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This change makes _error_out_instance_on_exception handle InstanceFaultRollback"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_09678f27","line":14,"range":{"start_line":14,"start_character":12,"end_line":14,"end_character":21},"updated":"2019-01-25 14:25:48.000000000","message":"something","commit_id":"0901a6ad806b07ca37f7358fa5511ce605ebf844"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ec6db72f404ba73c2ef1ac6088d8fe1179ade6f7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"case of InstanceFaultRollback, the caller may want to reset the vm_state"},{"line_number":13,"context_line":"back to something other than ACTIVE, like if the instance is actually"},{"line_number":14,"context_line":"STOPPED and something like prep_resize fails (you can resize a STOPPED"},{"line_number":15,"context_line":"instance)."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This change makes _error_out_instance_on_exception handle InstanceFaultRollback"},{"line_number":18,"context_line":"like NotImplementedError in that the instance_state parameter is used to reset"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5fc1f717_05afaae3","line":15,"updated":"2019-03-07 22:57:24.000000000","message":"Currently this is only specified for suspend and resume, right?\n\nBut in the next patch you\u0027re putting it into resize.","commit_id":"4c45cd4dfcbf899ae9e9c8465aaad3912128d4e2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"156ee09b96c831586c9610d5238ed131bae323d4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"case of InstanceFaultRollback, the caller may want to reset the vm_state"},{"line_number":13,"context_line":"back to something other than ACTIVE, like if the instance is actually"},{"line_number":14,"context_line":"STOPPED and something like prep_resize fails (you can resize a STOPPED"},{"line_number":15,"context_line":"instance)."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This change makes _error_out_instance_on_exception handle InstanceFaultRollback"},{"line_number":18,"context_line":"like NotImplementedError in that the instance_state parameter is used to reset"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5fc1f717_2238863b","line":15,"in_reply_to":"5fc1f717_05afaae3","updated":"2019-03-08 20:43:49.000000000","message":"Sorry, which thing? _error_out_instance_on_exception is used in several places, but it always reverts the vm_state to ACTIVE. Or are you asking what uses InstanceFaultRollback?","commit_id":"4c45cd4dfcbf899ae9e9c8465aaad3912128d4e2"}],"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c5ed7cba30cd24685257386b21adc01f065f3635","unresolved":false,"context_lines":[{"line_number":7899,"context_line":"        re-raised."},{"line_number":7900,"context_line":""},{"line_number":7901,"context_line":"        :param context: The nova auth request context for the operation."},{"line_number":7902,"context_line":"        :param instance: The instance to update. The vm_state and task_state"},{"line_number":7903,"context_line":"            will be set by this context manager when an exception is raised."},{"line_number":7904,"context_line":"        :param instance_state: For NotImplementedError and"},{"line_number":7905,"context_line":"            InstanceFaultRollback this is the vm_state to set the instance to"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_29813390","line":7902,"range":{"start_line":7902,"start_character":66,"end_line":7902,"end_character":76},"updated":"2019-01-25 14:25:48.000000000","message":"Well, not in the case of generic Exception...","commit_id":"0901a6ad806b07ca37f7358fa5511ce605ebf844"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6a425463d41823903eac67f74c52bc3d95dc1bc0","unresolved":false,"context_lines":[{"line_number":7901,"context_line":"            LOG.info(\"Setting instance back to ACTIVE after: %s\","},{"line_number":7902,"context_line":"                     error, instance_uuid\u003dinstance_uuid)"},{"line_number":7903,"context_line":"            self._instance_update(context, instance,"},{"line_number":7904,"context_line":"                                  vm_state\u003dvm_states.ACTIVE,"},{"line_number":7905,"context_line":"                                  task_state\u003dNone)"},{"line_number":7906,"context_line":"            raise error.inner_exception"},{"line_number":7907,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_ef624b3e","side":"PARENT","line":7904,"range":{"start_line":7904,"start_character":34,"end_line":7904,"end_character":60},"updated":"2019-01-25 16:02:10.000000000","message":"Should test that this is no longer hard-coded for InstanceFaultRollback.","commit_id":"0a50198158f7d9864b25761d1a590915bde71978"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ec6db72f404ba73c2ef1ac6088d8fe1179ade6f7","unresolved":false,"context_lines":[{"line_number":7978,"context_line":"        except Exception:"},{"line_number":7979,"context_line":"            LOG.exception(\u0027Setting instance vm_state to ERROR\u0027,"},{"line_number":7980,"context_line":"                          instance_uuid\u003dinstance_uuid)"},{"line_number":7981,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":7982,"context_line":"                # NOTE(mriedem): Why don\u0027t we pass clean_task_state\u003dTrue here?"},{"line_number":7983,"context_line":"                self._set_instance_obj_error_state(context, instance)"},{"line_number":7984,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_e517fe44","line":7981,"range":{"start_line":7981,"start_character":12,"end_line":7981,"end_character":55},"updated":"2019-03-07 22:57:24.000000000","message":"this should go up a line, no?","commit_id":"4c45cd4dfcbf899ae9e9c8465aaad3912128d4e2"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"957f1df750f3a6db9722caba1bd702466576d6f3","unresolved":false,"context_lines":[{"line_number":7978,"context_line":"        except Exception:"},{"line_number":7979,"context_line":"            LOG.exception(\u0027Setting instance vm_state to ERROR\u0027,"},{"line_number":7980,"context_line":"                          instance_uuid\u003dinstance_uuid)"},{"line_number":7981,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":7982,"context_line":"                # NOTE(mriedem): Why don\u0027t we pass clean_task_state\u003dTrue here?"},{"line_number":7983,"context_line":"                self._set_instance_obj_error_state(context, instance)"},{"line_number":7984,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_f237c74c","line":7981,"range":{"start_line":7981,"start_character":12,"end_line":7981,"end_character":55},"in_reply_to":"5fc1f717_82485acc","updated":"2019-04-02 20:28:56.000000000","message":"yes","commit_id":"4c45cd4dfcbf899ae9e9c8465aaad3912128d4e2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"156ee09b96c831586c9610d5238ed131bae323d4","unresolved":false,"context_lines":[{"line_number":7978,"context_line":"        except Exception:"},{"line_number":7979,"context_line":"            LOG.exception(\u0027Setting instance vm_state to ERROR\u0027,"},{"line_number":7980,"context_line":"                          instance_uuid\u003dinstance_uuid)"},{"line_number":7981,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":7982,"context_line":"                # NOTE(mriedem): Why don\u0027t we pass clean_task_state\u003dTrue here?"},{"line_number":7983,"context_line":"                self._set_instance_obj_error_state(context, instance)"},{"line_number":7984,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_82485acc","line":7981,"range":{"start_line":7981,"start_character":12,"end_line":7981,"end_character":55},"in_reply_to":"5fc1f717_e517fe44","updated":"2019-03-08 20:43:49.000000000","message":"Sure, but that\u0027s latent yeah?","commit_id":"4c45cd4dfcbf899ae9e9c8465aaad3912128d4e2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"747fb57bbe9d026a99a2cc904f742ec1a0aa52a3","unresolved":false,"context_lines":[{"line_number":7980,"context_line":"                          instance_uuid\u003dinstance_uuid)"},{"line_number":7981,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":7982,"context_line":"                # NOTE(mriedem): Why don\u0027t we pass clean_task_state\u003dTrue here?"},{"line_number":7983,"context_line":"                self._set_instance_obj_error_state(context, instance)"},{"line_number":7984,"context_line":""},{"line_number":7985,"context_line":"    @wrap_exception()"},{"line_number":7986,"context_line":"    def add_aggregate_host(self, context, aggregate, host, slave_info):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_824ffabb","line":7983,"range":{"start_line":7983,"start_character":21,"end_line":7983,"end_character":50},"updated":"2019-03-08 20:49:36.000000000","message":"Another thing that\u0027s always annoyed me with this is it doesn\u0027t reset the task_state\u003dNone here like above, but that\u0027s a different change for another day.","commit_id":"4c45cd4dfcbf899ae9e9c8465aaad3912128d4e2"}]}