)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d5fee0d8cba54f8007e49c21ea93929146f7b615","unresolved":false,"context_lines":[{"line_number":4216,"context_line":"                    context, instance, claim.migration, image,"},{"line_number":4217,"context_line":"                    instance_type, clean_shutdown)"},{"line_number":4218,"context_line":""},{"line_number":4219,"context_line":"    def _send_prep_resize_notifications("},{"line_number":4220,"context_line":"            self, context, instance, phase, flavor):"},{"line_number":4221,"context_line":"        \"\"\"Send \"resize.prep.*\" notifications."},{"line_number":4222,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_ea65a646","line":4219,"updated":"2019-02-06 10:27:39.000000000","message":"Replacing this amount of code duplication with a a function with extra conditionals feels like complicating things. I guess this new function will be used in more places later on to avoid further duplication to justify this refactor.\n// later //\nI see this will be reused also in prep_snapshot_based_resize_at_dest in I518ae675b7a67da64a5796e57e87860f0c3ef0db. So I\u0027m OK with this.","commit_id":"883da6cb8129b96138339c24890b8871eb122111"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"451b550d67493e5f03bc77b6724f1d1ba4feeeca","unresolved":false,"context_lines":[{"line_number":4216,"context_line":"                    context, instance, claim.migration, image,"},{"line_number":4217,"context_line":"                    instance_type, clean_shutdown)"},{"line_number":4218,"context_line":""},{"line_number":4219,"context_line":"    def _send_prep_resize_notifications("},{"line_number":4220,"context_line":"            self, context, instance, phase, flavor):"},{"line_number":4221,"context_line":"        \"\"\"Send \"resize.prep.*\" notifications."},{"line_number":4222,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_e9a92690","line":4219,"in_reply_to":"9fdfeff1_ea65a646","updated":"2019-02-06 22:04:42.000000000","message":"\u003e Replacing this amount of code duplication with a a function with extra conditionals feels like complicating things. I guess this new function will be used in more places later on to avoid further duplication to justify this refactor.\n\nYes it\u0027s re-used later, but regardless of that I think it\u0027s good on its own merit because I don\u0027t know about everyone else, but we have so many giant methods through the compute manager code that they can be hard to read, easy to miss things, and hard to test part of a method because you have 20 other things going on, so I think in general refactoring to break down complexity is a good thing.","commit_id":"883da6cb8129b96138339c24890b8871eb122111"}]}