)]}'
{"tox.ini":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e49bb8afd7469624a0744d49f116dd2ef62a2b19","unresolved":false,"context_lines":[{"line_number":133,"context_line":"  {[testenv:functional]commands}"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"[testenv:api-samples]"},{"line_number":136,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":137,"context_line":"setenv \u003d"},{"line_number":138,"context_line":"  {[testenv]setenv}"},{"line_number":139,"context_line":"  GENERATE_SAMPLES\u003dTrue"}],"source_content_type":"text/x-properties","patch_set":2,"id":"9fdfeff1_a642e03c","line":136,"range":{"start_line":136,"start_character":0,"end_line":136,"end_character":28},"updated":"2019-02-14 14:27:26.000000000","message":"You need to remove this otherwise you\u0027ll stomp all over the virtualenv and negate the advantages of using shared envs","commit_id":"d056623bf4aa1bbe970f96c3a8b7fe14a5959090"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"106c673f9adc13b798f8f22dac51053fa19fc327","unresolved":false,"context_lines":[{"line_number":133,"context_line":"  {[testenv:functional]commands}"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"[testenv:api-samples]"},{"line_number":136,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":137,"context_line":"setenv \u003d"},{"line_number":138,"context_line":"  {[testenv]setenv}"},{"line_number":139,"context_line":"  GENERATE_SAMPLES\u003dTrue"}],"source_content_type":"text/x-properties","patch_set":2,"id":"9fdfeff1_7157d027","line":136,"range":{"start_line":136,"start_character":0,"end_line":136,"end_character":28},"in_reply_to":"9fdfeff1_319708ef","updated":"2019-02-14 15:47:00.000000000","message":"Nah, it\u0027s related because previously we were using the same dependencies as the other tox targets that use this shared venv. That is no longer the case so we need to stop setting this else we get the aforementioned issues","commit_id":"d056623bf4aa1bbe970f96c3a8b7fe14a5959090"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a5e9b002efd54fd6024b942164bffd90cb3f66af","unresolved":false,"context_lines":[{"line_number":133,"context_line":"  {[testenv:functional]commands}"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"[testenv:api-samples]"},{"line_number":136,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":137,"context_line":"setenv \u003d"},{"line_number":138,"context_line":"  {[testenv]setenv}"},{"line_number":139,"context_line":"  GENERATE_SAMPLES\u003dTrue"}],"source_content_type":"text/x-properties","patch_set":2,"id":"9fdfeff1_319708ef","line":136,"range":{"start_line":136,"start_character":0,"end_line":136,"end_character":28},"in_reply_to":"9fdfeff1_a642e03c","updated":"2019-02-14 15:41:47.000000000","message":"OK I\u0027m not sure why this is here but it\u0027s not used in testenv:functional so I guess I can remove it - seems separate from what I\u0027m trying to fix though.","commit_id":"d056623bf4aa1bbe970f96c3a8b7fe14a5959090"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e49bb8afd7469624a0744d49f116dd2ef62a2b19","unresolved":false,"context_lines":[{"line_number":138,"context_line":"  {[testenv]setenv}"},{"line_number":139,"context_line":"  GENERATE_SAMPLES\u003dTrue"},{"line_number":140,"context_line":"  PYTHONHASHSEED\u003d0"},{"line_number":141,"context_line":"deps \u003d {[testenv:functional]deps}"},{"line_number":142,"context_line":"commands \u003d"},{"line_number":143,"context_line":"  {[testenv]commands}"},{"line_number":144,"context_line":"  stestr --test-path\u003d./nova/tests/functional/api_sample_tests run {posargs}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"9fdfeff1_264fd06b","line":141,"range":{"start_line":141,"start_character":0,"end_line":141,"end_character":33},"updated":"2019-02-14 14:27:26.000000000","message":"You haven\u0027t said why this fails. Is it because we use the placement fixture here somehow or because we\u0027re generating placement API samples too? If the latter, I assume we\u0027re going to stop doing that at some point, right? If so, maybe add a TODO to remove this again when that happens","commit_id":"d056623bf4aa1bbe970f96c3a8b7fe14a5959090"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a5e9b002efd54fd6024b942164bffd90cb3f66af","unresolved":false,"context_lines":[{"line_number":138,"context_line":"  {[testenv]setenv}"},{"line_number":139,"context_line":"  GENERATE_SAMPLES\u003dTrue"},{"line_number":140,"context_line":"  PYTHONHASHSEED\u003d0"},{"line_number":141,"context_line":"deps \u003d {[testenv:functional]deps}"},{"line_number":142,"context_line":"commands \u003d"},{"line_number":143,"context_line":"  {[testenv]commands}"},{"line_number":144,"context_line":"  stestr --test-path\u003d./nova/tests/functional/api_sample_tests run {posargs}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"9fdfeff1_918b54be","line":141,"range":{"start_line":141,"start_character":0,"end_line":141,"end_character":33},"in_reply_to":"9fdfeff1_264fd06b","updated":"2019-02-14 15:41:47.000000000","message":"The commit message says, \"The api-samples tox target fails since it can\u0027t find placement.\" So this is pulling in the placement fixture dependency via testenv:functional just like functional-py3* targets above.","commit_id":"d056623bf4aa1bbe970f96c3a8b7fe14a5959090"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"106c673f9adc13b798f8f22dac51053fa19fc327","unresolved":false,"context_lines":[{"line_number":138,"context_line":"  {[testenv]setenv}"},{"line_number":139,"context_line":"  GENERATE_SAMPLES\u003dTrue"},{"line_number":140,"context_line":"  PYTHONHASHSEED\u003d0"},{"line_number":141,"context_line":"deps \u003d {[testenv:functional]deps}"},{"line_number":142,"context_line":"commands \u003d"},{"line_number":143,"context_line":"  {[testenv]commands}"},{"line_number":144,"context_line":"  stestr --test-path\u003d./nova/tests/functional/api_sample_tests run {posargs}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"9fdfeff1_116e84ff","line":141,"range":{"start_line":141,"start_character":0,"end_line":141,"end_character":33},"in_reply_to":"9fdfeff1_918b54be","updated":"2019-02-14 15:47:00.000000000","message":"I wasn\u0027t clear. I meant it doesn\u0027t say what about placement it can\u0027t find. Seems it\u0027s the fixture, rather than something else. Maybe s/can\u0027t find placement/needs the placement fixture/","commit_id":"d056623bf4aa1bbe970f96c3a8b7fe14a5959090"}]}