)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f73218a608658467aeab8e9ce921ab3663f2ebef","unresolved":false,"context_lines":[{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    def _cleanup_created_port(self, port_client, port_id, instance):"},{"line_number":476,"context_line":"        try:"},{"line_number":477,"context_line":"            msg \u003d (_(\"The auto-created port %(port_id)s is being deleted due \""},{"line_number":478,"context_line":"                     \"to it\u0027s network having QoS policy.\") %"},{"line_number":479,"context_line":"                   {\u0027port_id\u0027: port_id})"},{"line_number":480,"context_line":"            LOG.info(msg)"},{"line_number":481,"context_line":"            port_client.delete_port(port_id)"},{"line_number":482,"context_line":"        except neutron_client_exc.NeutronClientException:"},{"line_number":483,"context_line":"            LOG.exception("}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_fa6ad417","line":480,"range":{"start_line":477,"start_character":12,"end_line":480,"end_character":25},"updated":"2019-01-29 16:31:38.000000000","message":"Don\u0027t put a specific log message in a generic method - move this to before calling the generic method.\n\nAlso, shouldn\u0027t the substitution variables be passed to the LOG.info method?\n\nLOG.info(msg, port_id)","commit_id":"9524eeff0cf84e2e9f068e6bf0c054a665977ac6"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"03f021a4d48b50d601c3701579f9e37f45139628","unresolved":false,"context_lines":[{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    def _cleanup_created_port(self, port_client, port_id, instance):"},{"line_number":476,"context_line":"        try:"},{"line_number":477,"context_line":"            msg \u003d (_(\"The auto-created port %(port_id)s is being deleted due \""},{"line_number":478,"context_line":"                     \"to it\u0027s network having QoS policy.\") %"},{"line_number":479,"context_line":"                   {\u0027port_id\u0027: port_id})"},{"line_number":480,"context_line":"            LOG.info(msg)"},{"line_number":481,"context_line":"            port_client.delete_port(port_id)"},{"line_number":482,"context_line":"        except neutron_client_exc.NeutronClientException:"},{"line_number":483,"context_line":"            LOG.exception("}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_d666bfc1","line":480,"range":{"start_line":477,"start_character":12,"end_line":480,"end_character":25},"in_reply_to":"9fdfeff1_fa6ad417","updated":"2019-01-30 10:30:09.000000000","message":"Done","commit_id":"9524eeff0cf84e2e9f068e6bf0c054a665977ac6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4818d6068db5131841678a77c86ce7a9f9013005","unresolved":false,"context_lines":[{"line_number":524,"context_line":"            if port.get(\u0027resource_request\u0027, None):"},{"line_number":525,"context_line":"                msg \u003d _("},{"line_number":526,"context_line":"                    \"The auto-created port %(port_id)s is being deleted due \""},{"line_number":527,"context_line":"                    \"to it\u0027s network having QoS policy.\")"},{"line_number":528,"context_line":"                LOG.info(msg, {\u0027port_id\u0027: port_id})"},{"line_number":529,"context_line":"                self._cleanup_created_port(port_client, port_id, instance)"},{"line_number":530,"context_line":"                # NOTE(gibi): This limitation regarding server create can be"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_2fb32e9a","line":527,"range":{"start_line":527,"start_character":24,"end_line":527,"end_character":28},"updated":"2019-01-30 14:04:16.000000000","message":"its","commit_id":"49ec9c803ab5513fc25a8a9afc79914751433ebe"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"830283d3498dd42fd83b9baa082f9c91412bc39d","unresolved":false,"context_lines":[{"line_number":524,"context_line":"            if port.get(\u0027resource_request\u0027, None):"},{"line_number":525,"context_line":"                msg \u003d _("},{"line_number":526,"context_line":"                    \"The auto-created port %(port_id)s is being deleted due \""},{"line_number":527,"context_line":"                    \"to it\u0027s network having QoS policy.\")"},{"line_number":528,"context_line":"                LOG.info(msg, {\u0027port_id\u0027: port_id})"},{"line_number":529,"context_line":"                self._cleanup_created_port(port_client, port_id, instance)"},{"line_number":530,"context_line":"                # NOTE(gibi): This limitation regarding server create can be"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_726316b3","line":527,"range":{"start_line":527,"start_character":24,"end_line":527,"end_character":28},"in_reply_to":"9fdfeff1_2fb32e9a","updated":"2019-02-04 13:11:14.000000000","message":"Done","commit_id":"49ec9c803ab5513fc25a8a9afc79914751433ebe"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"874f0a19d6a6f36724bc08ac603c3c125e7a5421","unresolved":false,"context_lines":[{"line_number":523,"context_line":"            # need a new scheduling if resource on this host is not available."},{"line_number":524,"context_line":"            if port.get(\u0027resource_request\u0027, None):"},{"line_number":525,"context_line":"                msg \u003d _("},{"line_number":526,"context_line":"                    \"The auto-created port %(port_id)s is being deleted due \""},{"line_number":527,"context_line":"                    \"to its network having QoS policy.\")"},{"line_number":528,"context_line":"                LOG.info(msg, {\u0027port_id\u0027: port_id})"},{"line_number":529,"context_line":"                self._cleanup_created_port(port_client, port_id, instance)"},{"line_number":530,"context_line":"                # NOTE(gibi): This limitation regarding server create can be"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_9ecbaea3","line":527,"range":{"start_line":526,"start_character":0,"end_line":527,"end_character":56},"updated":"2019-02-11 16:14:12.000000000","message":"This is correct but it reads rather weirdly and took me a few passes to grok. Not sure how I\u0027d reword though, tbh.","commit_id":"cc16de04e8dc21a666ddc414cf80a94f30e4d424"}],"nova/tests/unit/compute/test_compute_api.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"874f0a19d6a6f36724bc08ac603c3c125e7a5421","unresolved":false,"context_lines":[{"line_number":6425,"context_line":"        self.assertItemsEqual([\u0027default\u0027, uuids.secgroup_uuid],"},{"line_number":6426,"context_line":"                              security_groups)"},{"line_number":6427,"context_line":""},{"line_number":6428,"context_line":"    @mock.patch(\u0027nova.network.neutronv2.api.API.validate_networks\u0027)"},{"line_number":6429,"context_line":"    @mock.patch(\u0027nova.network.neutronv2.api.API.create_resource_requests\u0027)"},{"line_number":6430,"context_line":"    def test_validate_and_build_base_options_checks_resource_request("},{"line_number":6431,"context_line":"            self, mock_neutron_create_resource_requests,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_7ef36ae8","side":"PARENT","line":6428,"updated":"2019-02-11 16:14:12.000000000","message":"This is removed per comment at [1]\n\n[1] https://review.openstack.org/#/c/630721/4/nova/tests/unit/compute/test_compute_api.py@6430","commit_id":"ac1fafb84c94ed9f8e610c7c3e152e38aef844ed"}]}