)]}'
{"nova/network/os_vif_util.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7743b05dfb8bda3b0204fffa6d15d91b824686dc","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        # VIFPortProfileOpenVSwitch during Train."},{"line_number":295,"context_line":"        profile \u003d objects.vif.VIFPortProfileOVSRepresentor("},{"line_number":296,"context_line":"            interface_id\u003dvif.get(\u0027ovs_interfaceid\u0027) or vif[\u0027id\u0027],"},{"line_number":297,"context_line":"            representor_name\u003d_get_vif_name(vif),"},{"line_number":298,"context_line":"            representor_address\u003dvif[\"profile\"][\u0027pci_slot\u0027],"},{"line_number":299,"context_line":"            datapath_offload\u003ddatapath_offload)"},{"line_number":300,"context_line":"        obj \u003d _get_vif_instance("}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_52eac0d7","line":297,"range":{"start_line":297,"start_character":29,"end_line":297,"end_character":47},"updated":"2019-01-31 14:08:55.000000000","message":"nit: we get the vif name above when building the datapath_offload variable, we could just keep a local variable for that and re-use it.","commit_id":"ba3fe17b0390ef7027a37d2577b6a3ea14548ce9"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"750fc9530f8dc9bb648d490008198bb836ccfba2","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        # VIFPortProfileOpenVSwitch during Train."},{"line_number":295,"context_line":"        profile \u003d objects.vif.VIFPortProfileOVSRepresentor("},{"line_number":296,"context_line":"            interface_id\u003dvif.get(\u0027ovs_interfaceid\u0027) or vif[\u0027id\u0027],"},{"line_number":297,"context_line":"            representor_name\u003d_get_vif_name(vif),"},{"line_number":298,"context_line":"            representor_address\u003dvif[\"profile\"][\u0027pci_slot\u0027],"},{"line_number":299,"context_line":"            datapath_offload\u003ddatapath_offload)"},{"line_number":300,"context_line":"        obj \u003d _get_vif_instance("}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_78da4378","line":297,"range":{"start_line":297,"start_character":29,"end_line":297,"end_character":47},"in_reply_to":"9fdfeff1_52eac0d7","updated":"2019-01-31 15:24:20.000000000","message":"Done","commit_id":"ba3fe17b0390ef7027a37d2577b6a3ea14548ce9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7743b05dfb8bda3b0204fffa6d15d91b824686dc","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        # plug/unplug, this should be the same as VIF.dev_address in the"},{"line_number":342,"context_line":"        # VNIC_TYPE_DIRECT case."},{"line_number":343,"context_line":"        datapath_offload \u003d objects.vif.DatapathOffloadRepresentor("},{"line_number":344,"context_line":"            representor_name\u003d_get_vif_name(vif),"},{"line_number":345,"context_line":"            representor_address\u003dvif[\"profile\"][\"pci_slot\"]"},{"line_number":346,"context_line":"        )"},{"line_number":347,"context_line":"        # NOTE(jangutter): in accordance with the generic-os-vif-offloads spec,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_b2b44cf3","line":344,"range":{"start_line":344,"start_character":29,"end_line":344,"end_character":47},"updated":"2019-01-31 14:08:55.000000000","message":"nit: We have vif_name above to use.","commit_id":"ba3fe17b0390ef7027a37d2577b6a3ea14548ce9"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"750fc9530f8dc9bb648d490008198bb836ccfba2","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        # plug/unplug, this should be the same as VIF.dev_address in the"},{"line_number":342,"context_line":"        # VNIC_TYPE_DIRECT case."},{"line_number":343,"context_line":"        datapath_offload \u003d objects.vif.DatapathOffloadRepresentor("},{"line_number":344,"context_line":"            representor_name\u003d_get_vif_name(vif),"},{"line_number":345,"context_line":"            representor_address\u003dvif[\"profile\"][\"pci_slot\"]"},{"line_number":346,"context_line":"        )"},{"line_number":347,"context_line":"        # NOTE(jangutter): in accordance with the generic-os-vif-offloads spec,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_18e53738","line":344,"range":{"start_line":344,"start_character":29,"end_line":344,"end_character":47},"in_reply_to":"9fdfeff1_b2b44cf3","updated":"2019-01-31 15:24:20.000000000","message":"Done","commit_id":"ba3fe17b0390ef7027a37d2577b6a3ea14548ce9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"38a8580b34937ab5f929f34c66a3756c51471cd2","unresolved":false,"context_lines":[{"line_number":447,"context_line":""},{"line_number":448,"context_line":"# VIF_TYPE_VROUTER \u003d \u0027vrouter\u0027"},{"line_number":449,"context_line":"def _nova_to_osvif_vif_vrouter(vif):"},{"line_number":450,"context_line":"    vif_name \u003d _get_vif_name(vif)"},{"line_number":451,"context_line":"    vnic_type \u003d vif.get(\u0027vnic_type\u0027, model.VNIC_TYPE_NORMAL)"},{"line_number":452,"context_line":"    if vnic_type \u003d\u003d model.VNIC_TYPE_NORMAL:"},{"line_number":453,"context_line":"        obj \u003d _get_vif_instance("}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_507b8126","line":450,"range":{"start_line":450,"start_character":4,"end_line":450,"end_character":33},"updated":"2019-02-01 17:48:05.000000000","message":"ok so your just pulling this out.\nthat makes sense.\nits not need but it makes senes","commit_id":"ecfdec5a6ed0de56c4a5b1649a17f5f229d9470b"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"d47d0a796f38815d702451ccaab305008e4639b3","unresolved":false,"context_lines":[{"line_number":447,"context_line":""},{"line_number":448,"context_line":"# VIF_TYPE_VROUTER \u003d \u0027vrouter\u0027"},{"line_number":449,"context_line":"def _nova_to_osvif_vif_vrouter(vif):"},{"line_number":450,"context_line":"    vif_name \u003d _get_vif_name(vif)"},{"line_number":451,"context_line":"    vnic_type \u003d vif.get(\u0027vnic_type\u0027, model.VNIC_TYPE_NORMAL)"},{"line_number":452,"context_line":"    if vnic_type \u003d\u003d model.VNIC_TYPE_NORMAL:"},{"line_number":453,"context_line":"        obj \u003d _get_vif_instance("}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_d2920259","line":450,"range":{"start_line":450,"start_character":4,"end_line":450,"end_character":33},"in_reply_to":"9fdfeff1_507b8126","updated":"2019-02-04 13:17:25.000000000","message":"Other options are to split the vif_name \u003d _get_vif_name(vif) refactor into a separate patch, or move it over to the next patch in the series. I did this here mostly so there\u0027s some uniformity in the pattern between the three VIF types.","commit_id":"ecfdec5a6ed0de56c4a5b1649a17f5f229d9470b"}]}