)]}'
{"nova/tests/virt/docker/mock_client.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2f9c1ff55bc30819f5f236340c7a87bc24b7c777","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            })"},{"line_number":47,"context_line":"        return containers"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def create_container(self, args, name):"},{"line_number":50,"context_line":"        data \u003d {"},{"line_number":51,"context_line":"            \u0027Hostname\u0027: \u0027\u0027,"},{"line_number":52,"context_line":"            \u0027User\u0027: \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2FTts%3D","line":49,"updated":"2014-01-15 08:02:33.000000000","message":"any reason why you do not make use of the name here in the mock method?","commit_id":"a1935aa7fbbc4e2733ff60f7d4be7ba26a98e847"},{"author":{"_account_id":9173,"name":"Daniel Kuffner","email":"daniel.kuffner@gmail.com","username":"dkuffner"},"change_message_id":"666bb24c41dd49f79bf51ca39b60fda4a915917a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            })"},{"line_number":47,"context_line":"        return containers"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def create_container(self, args, name):"},{"line_number":50,"context_line":"        data \u003d {"},{"line_number":51,"context_line":"            \u0027Hostname\u0027: \u0027\u0027,"},{"line_number":52,"context_line":"            \u0027User\u0027: \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2FTck%3D","line":49,"in_reply_to":"AAAAUH%2F%2FTts%3D","updated":"2014-01-15 09:41:32.000000000","message":"Would it be acceptable to add a not None assertion here? Currently there are no assertions in the mock client.\n\nAlternative we could save the name as member on the mock client and assert for correct value in the tests","commit_id":"a1935aa7fbbc4e2733ff60f7d4be7ba26a98e847"}],"nova/tests/virt/docker/test_docker_client.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"284999bb974d9ddaddf9b661f9ca0cf281f20071","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.mox.ReplayAll()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        client \u003d nova.virt.docker.client.DockerHTTPClient(mock_conn)"},{"line_number":89,"context_line":"        container_id \u003d client.create_container({}, \"name\")"},{"line_number":90,"context_line":"        self.assertEqual(\u0027XXX\u0027, container_id)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self.mox.VerifyAll()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FmpU%3D","line":89,"updated":"2014-01-10 15:37:28.000000000","message":"This should be a uuid now right?  I\u0027d use uuid.uuid4() in the tests to be consistent with what this value should be in the source.","commit_id":"312e17e3bafb5228c8192d43f2bcc540bbd82c2f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2f9c1ff55bc30819f5f236340c7a87bc24b7c777","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_create_container(self):"},{"line_number":60,"context_line":"        mock_conn \u003d self.mox.CreateMockAnything()"},{"line_number":61,"context_line":"        expected_uuid \u003d uuid.uuid4()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        expected_body \u003d jsonutils.dumps({"},{"line_number":64,"context_line":"            \u0027Hostname\u0027: \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2FTtQ%3D","line":61,"updated":"2014-01-15 08:02:33.000000000","message":"should this not be called the instance_uuid?\n\nin addition to this it should be str(uuid.uuid4())\n\nnot sure if you want to use the openstack common generate_uuid (some are moving away from that though)","commit_id":"a1935aa7fbbc4e2733ff60f7d4be7ba26a98e847"},{"author":{"_account_id":9173,"name":"Daniel Kuffner","email":"daniel.kuffner@gmail.com","username":"dkuffner"},"change_message_id":"666bb24c41dd49f79bf51ca39b60fda4a915917a","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_create_container(self):"},{"line_number":60,"context_line":"        mock_conn \u003d self.mox.CreateMockAnything()"},{"line_number":61,"context_line":"        expected_uuid \u003d uuid.uuid4()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        expected_body \u003d jsonutils.dumps({"},{"line_number":64,"context_line":"            \u0027Hostname\u0027: \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2FTdA%3D","line":61,"in_reply_to":"AAAAUH%2F%2FTtQ%3D","updated":"2014-01-15 09:41:32.000000000","message":"To use  uuid.uuid4() was a recommendation from Matt Riedmann. \n\nIf this method not deprecated I see no reason to change that now.","commit_id":"a1935aa7fbbc4e2733ff60f7d4be7ba26a98e847"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c01c03358984c17bfcf972c2219bd20770f9bf8b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from nova import test"},{"line_number":22,"context_line":"import nova.virt.docker.client"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import uuid"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class FakeResponse(object):"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F%2BV5M%3D","line":24,"updated":"2014-01-27 21:15:10.000000000","message":"stdlib imports should go first, see:\n\nhttp://docs.openstack.org/developer/hacking/#imports","commit_id":"92778ecac2fe2cf150d3b8e006534e4847f58b8b"}],"nova/virt/docker/client.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2f9c1ff55bc30819f5f236340c7a87bc24b7c777","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            \u0027VolumesFrom\u0027: \u0027\u0027,"},{"line_number":132,"context_line":"        }"},{"line_number":133,"context_line":"        data.update(args)"},{"line_number":134,"context_line":"        resp \u003d self.make_request("},{"line_number":135,"context_line":"            \u0027POST\u0027,"},{"line_number":136,"context_line":"            \u0027/v1.7/containers/create?name\u003d{0}\u0027.format(name),"},{"line_number":137,"context_line":"            body\u003djsonutils.dumps(data))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2FTsw%3D","line":134,"updated":"2014-01-15 08:02:33.000000000","message":"not related to the patch set but what if there is an exception regarding the method call?","commit_id":"a1935aa7fbbc4e2733ff60f7d4be7ba26a98e847"}],"nova/virt/docker/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"284999bb974d9ddaddf9b661f9ca0cf281f20071","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        self.docker.push_repository(name, headers\u003dheaders)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    def _create_container(self, instance, args):"},{"line_number":391,"context_line":"        name \u003d \"nova-\" + instance[\u0027uuid\u0027]"},{"line_number":392,"context_line":"        return self.docker.create_container(args, name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Fmps%3D","line":391,"updated":"2014-01-10 15:37:28.000000000","message":"The instance arg in the spawn method is an object now, so you should be able to access the fields like an object, i.e. instance.uuid.","commit_id":"312e17e3bafb5228c8192d43f2bcc540bbd82c2f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2f9c1ff55bc30819f5f236340c7a87bc24b7c777","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        return int(flavor[\u0027vcpus\u0027]) * 1024"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    def _create_container(self, instance, args):"},{"line_number":411,"context_line":"        name \u003d \"nova-\" + instance[\u0027uuid\u0027]"},{"line_number":412,"context_line":"        return self.docker.create_container(args, name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2FTsg%3D","line":411,"updated":"2014-01-15 08:02:33.000000000","message":"can you please update the commit message to say that the name is prefixed by nova\n\nwhat happens when there is a vm rescue (not sure if this is supported by docker - you may have the same name for 2 instances)","commit_id":"a1935aa7fbbc4e2733ff60f7d4be7ba26a98e847"},{"author":{"_account_id":9173,"name":"Daniel Kuffner","email":"daniel.kuffner@gmail.com","username":"dkuffner"},"change_message_id":"666bb24c41dd49f79bf51ca39b60fda4a915917a","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        return int(flavor[\u0027vcpus\u0027]) * 1024"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    def _create_container(self, instance, args):"},{"line_number":411,"context_line":"        name \u003d \"nova-\" + instance[\u0027uuid\u0027]"},{"line_number":412,"context_line":"        return self.docker.create_container(args, name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2FTdU%3D","line":411,"in_reply_to":"AAAAUH%2F%2FTsg%3D","updated":"2014-01-15 09:41:32.000000000","message":"Some capabilties has been disabled recently not sure if rescue is part of it: https://github.com/openstack/nova/commit/6a932aebbc68989485d4867920a6a6bbf536f6c6","commit_id":"a1935aa7fbbc4e2733ff60f7d4be7ba26a98e847"}]}