)]}'
{"nova/compute/api.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3695222bf195625af07318456b8a2ba09932cb9b","unresolved":false,"context_lines":[{"line_number":3394,"context_line":"    def _check_vpmems_for_resize(instance,"},{"line_number":3395,"context_line":"                                 current_flavor, new_flavor):"},{"line_number":3396,"context_line":"        image_meta \u003d instance.image_meta"},{"line_number":3397,"context_line":"        current_numa_topo \u003d hardware.numa_get_constraints(current_flavor,"},{"line_number":3398,"context_line":"                                                          image_meta)"},{"line_number":3399,"context_line":"        new_numa_topo \u003d hardware.numa_get_constraints(new_flavor,"},{"line_number":3400,"context_line":"                                                      image_meta)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_202b66eb","line":3397,"updated":"2019-02-26 02:45:30.000000000","message":"These exception \"InvalidNUMAPMEMSize\" and \"InvalidNUMAPMEM\", should be captured in \"def resize()\".","commit_id":"585b2b39628c1f61622db73ad2e51a28b08c37d6"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"8739592f57db618e153ecab2bb8d77dc808093ba","unresolved":false,"context_lines":[{"line_number":3394,"context_line":"    def _check_vpmems_for_resize(instance,"},{"line_number":3395,"context_line":"                                 current_flavor, new_flavor):"},{"line_number":3396,"context_line":"        image_meta \u003d instance.image_meta"},{"line_number":3397,"context_line":"        current_numa_topo \u003d hardware.numa_get_constraints(current_flavor,"},{"line_number":3398,"context_line":"                                                          image_meta)"},{"line_number":3399,"context_line":"        new_numa_topo \u003d hardware.numa_get_constraints(new_flavor,"},{"line_number":3400,"context_line":"                                                      image_meta)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_d6bbc00c","line":3397,"in_reply_to":"9fdfeff1_202b66eb","updated":"2019-03-04 11:04:01.000000000","message":"I‘d like catch these exceptions and raise exception.CannotResizeVpmem here. Is that OK for you?","commit_id":"585b2b39628c1f61622db73ad2e51a28b08c37d6"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3695222bf195625af07318456b8a2ba09932cb9b","unresolved":false,"context_lines":[{"line_number":3577,"context_line":"                                         current_instance_type,"},{"line_number":3578,"context_line":"                                         new_instance_type)"},{"line_number":3579,"context_line":""},{"line_number":3580,"context_line":"        self._check_vpmems_for_resize(instance,"},{"line_number":3581,"context_line":"                                      current_instance_type,"},{"line_number":3582,"context_line":"                                      new_instance_type)"},{"line_number":3583,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_e009de83","line":3580,"updated":"2019-02-26 02:45:30.000000000","message":"Maybe need it here：\ntry:\n    self._check_vpmems_for_resize(instance,\n                                  current_instance_type,\n                                  new_instance_type)\nexcept InvalidNUMAPMEMSize:\n    ...\nexcept InvalidNUMAPMEM:\n    ...","commit_id":"585b2b39628c1f61622db73ad2e51a28b08c37d6"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"8739592f57db618e153ecab2bb8d77dc808093ba","unresolved":false,"context_lines":[{"line_number":3577,"context_line":"                                         current_instance_type,"},{"line_number":3578,"context_line":"                                         new_instance_type)"},{"line_number":3579,"context_line":""},{"line_number":3580,"context_line":"        self._check_vpmems_for_resize(instance,"},{"line_number":3581,"context_line":"                                      current_instance_type,"},{"line_number":3582,"context_line":"                                      new_instance_type)"},{"line_number":3583,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_563d908c","line":3580,"in_reply_to":"9fdfeff1_2470de73","updated":"2019-03-04 11:04:01.000000000","message":"Thank you for your explanation.","commit_id":"585b2b39628c1f61622db73ad2e51a28b08c37d6"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"42725c06c3b4c6328c4f9c543e5e1c8d4d74eab8","unresolved":false,"context_lines":[{"line_number":3577,"context_line":"                                         current_instance_type,"},{"line_number":3578,"context_line":"                                         new_instance_type)"},{"line_number":3579,"context_line":""},{"line_number":3580,"context_line":"        self._check_vpmems_for_resize(instance,"},{"line_number":3581,"context_line":"                                      current_instance_type,"},{"line_number":3582,"context_line":"                                      new_instance_type)"},{"line_number":3583,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_2470de73","line":3580,"in_reply_to":"9fdfeff1_61cd992e","updated":"2019-03-04 03:27:08.000000000","message":"Personal opinion, if the expansion fails, you can print a log record of the failure to expand the pmem namespace, and then you can go out, not just a short pop-up an exception, or what I ignored?","commit_id":"585b2b39628c1f61622db73ad2e51a28b08c37d6"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"fce1880e20ba470dbe8c3796d9b5b8e420c70b47","unresolved":false,"context_lines":[{"line_number":3577,"context_line":"                                         current_instance_type,"},{"line_number":3578,"context_line":"                                         new_instance_type)"},{"line_number":3579,"context_line":""},{"line_number":3580,"context_line":"        self._check_vpmems_for_resize(instance,"},{"line_number":3581,"context_line":"                                      current_instance_type,"},{"line_number":3582,"context_line":"                                      new_instance_type)"},{"line_number":3583,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_61cd992e","line":3580,"in_reply_to":"9fdfeff1_e009de83","updated":"2019-03-01 06:50:03.000000000","message":"Why do we need to catch these exceptions？ It should be raised so that the resize will fail.","commit_id":"585b2b39628c1f61622db73ad2e51a28b08c37d6"}],"nova/privsep/libvirt.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3695222bf195625af07318456b8a2ba09932cb9b","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    cmd_1 \u003d ("},{"line_number":259,"context_line":"        \u0027sudo daxio -i /dev/%s \u0027 % src_dev,"},{"line_number":260,"context_line":"        \u0027-l %sM \u0027 % (src_size_mb - label_size_mb - 2),"},{"line_number":261,"context_line":"        \u0027|ssh root@%s \u0027 % remote_address,"},{"line_number":262,"context_line":"        \u0027\"sudo daxio -o /dev/%s \u0027 % dst_dev,"},{"line_number":263,"context_line":"        \u0027-l %sM \"\u0027 % (src_size_mb - label_size_mb - 2),"},{"line_number":264,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_c05cda4c","line":261,"range":{"start_line":261,"start_character":8,"end_line":261,"end_character":41},"updated":"2019-02-26 02:45:30.000000000","message":"If I resize on the same node, do I need to ssh to the current host?","commit_id":"585b2b39628c1f61622db73ad2e51a28b08c37d6"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"56065798aa2dbdd3b0b764b6db2a664a563ece82","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    cmd_1 \u003d ("},{"line_number":259,"context_line":"        \u0027sudo daxio -i /dev/%s \u0027 % src_dev,"},{"line_number":260,"context_line":"        \u0027-l %sM \u0027 % (src_size_mb - label_size_mb - 2),"},{"line_number":261,"context_line":"        \u0027|ssh root@%s \u0027 % remote_address,"},{"line_number":262,"context_line":"        \u0027\"sudo daxio -o /dev/%s \u0027 % dst_dev,"},{"line_number":263,"context_line":"        \u0027-l %sM \"\u0027 % (src_size_mb - label_size_mb - 2),"},{"line_number":264,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_706685f0","line":261,"range":{"start_line":261,"start_character":8,"end_line":261,"end_character":41},"in_reply_to":"9fdfeff1_1624e80d","updated":"2019-03-07 05:43:11.000000000","message":"In theory, copying between the same host does not require ssh, but there is nothing wrong with this processing, I am ok for this done.","commit_id":"585b2b39628c1f61622db73ad2e51a28b08c37d6"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"fce1880e20ba470dbe8c3796d9b5b8e420c70b47","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    cmd_1 \u003d ("},{"line_number":259,"context_line":"        \u0027sudo daxio -i /dev/%s \u0027 % src_dev,"},{"line_number":260,"context_line":"        \u0027-l %sM \u0027 % (src_size_mb - label_size_mb - 2),"},{"line_number":261,"context_line":"        \u0027|ssh root@%s \u0027 % remote_address,"},{"line_number":262,"context_line":"        \u0027\"sudo daxio -o /dev/%s \u0027 % dst_dev,"},{"line_number":263,"context_line":"        \u0027-l %sM \"\u0027 % (src_size_mb - label_size_mb - 2),"},{"line_number":264,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_c17c85ec","line":261,"range":{"start_line":261,"start_character":8,"end_line":261,"end_character":41},"in_reply_to":"9fdfeff1_c05cda4c","updated":"2019-03-01 06:50:03.000000000","message":"There\u0027s no need to ssh, we can copy the data directly. Thank you for your review, I will update this.","commit_id":"585b2b39628c1f61622db73ad2e51a28b08c37d6"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"42725c06c3b4c6328c4f9c543e5e1c8d4d74eab8","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    cmd_1 \u003d ("},{"line_number":259,"context_line":"        \u0027sudo daxio -i /dev/%s \u0027 % src_dev,"},{"line_number":260,"context_line":"        \u0027-l %sM \u0027 % (src_size_mb - label_size_mb - 2),"},{"line_number":261,"context_line":"        \u0027|ssh root@%s \u0027 % remote_address,"},{"line_number":262,"context_line":"        \u0027\"sudo daxio -o /dev/%s \u0027 % dst_dev,"},{"line_number":263,"context_line":"        \u0027-l %sM \"\u0027 % (src_size_mb - label_size_mb - 2),"},{"line_number":264,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_e469768c","line":261,"range":{"start_line":261,"start_character":8,"end_line":261,"end_character":41},"in_reply_to":"9fdfeff1_c17c85ec","updated":"2019-03-04 03:27:08.000000000","message":"Thanks.","commit_id":"585b2b39628c1f61622db73ad2e51a28b08c37d6"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"8739592f57db618e153ecab2bb8d77dc808093ba","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    cmd_1 \u003d ("},{"line_number":259,"context_line":"        \u0027sudo daxio -i /dev/%s \u0027 % src_dev,"},{"line_number":260,"context_line":"        \u0027-l %sM \u0027 % (src_size_mb - label_size_mb - 2),"},{"line_number":261,"context_line":"        \u0027|ssh root@%s \u0027 % remote_address,"},{"line_number":262,"context_line":"        \u0027\"sudo daxio -o /dev/%s \u0027 % dst_dev,"},{"line_number":263,"context_line":"        \u0027-l %sM \"\u0027 % (src_size_mb - label_size_mb - 2),"},{"line_number":264,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_1624e80d","line":261,"range":{"start_line":261,"start_character":8,"end_line":261,"end_character":41},"in_reply_to":"9fdfeff1_e469768c","updated":"2019-03-04 11:04:01.000000000","message":"I recheck this and find that the code for local host migration is almost the same, if we handle this seperately, it will bring duplicated code here. SSH can work well and can simplify the design,  but maybe have some influences on network, i\u0027m not sure if we can accept the influence caused by ssh. What do you think about it?","commit_id":"585b2b39628c1f61622db73ad2e51a28b08c37d6"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3695222bf195625af07318456b8a2ba09932cb9b","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    cmd_2 \u003d ("},{"line_number":267,"context_line":"        \u0027sudo daxio -i /dev/%s \u0027 % src_dev,"},{"line_number":268,"context_line":"        \u0027-k %sM \u0027 % (src_size_mb - label_size_mb - 2),"},{"line_number":269,"context_line":"        \u0027|ssh root@%s \u0027 % remote_address,"},{"line_number":270,"context_line":"        \u0027\"sudo daxio -o /dev/%s \u0027 % dst_dev,"},{"line_number":271,"context_line":"        \u0027-s %sM \"\u0027 % (dst_size_mb - label_size_mb - 2),"},{"line_number":272,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_2031260c","line":269,"range":{"start_line":269,"start_character":8,"end_line":269,"end_character":41},"updated":"2019-02-26 02:45:30.000000000","message":"ditto.","commit_id":"585b2b39628c1f61622db73ad2e51a28b08c37d6"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3695222bf195625af07318456b8a2ba09932cb9b","unresolved":false,"context_lines":[{"line_number":8603,"context_line":""},{"line_number":8604,"context_line":"        return jsonutils.dumps(disk_info)"},{"line_number":8605,"context_line":""},{"line_number":8606,"context_line":"    def migrate_vpmems_data(self, context, instance):"},{"line_number":8607,"context_line":"        if \u0027migration_context\u0027 not in instance or \\"},{"line_number":8608,"context_line":"                not instance.migration_context:"},{"line_number":8609,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_6b186f75","line":8606,"updated":"2019-02-26 02:45:30.000000000","message":"This interface would be better if you could add some log prints.","commit_id":"585b2b39628c1f61622db73ad2e51a28b08c37d6"}]}