)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c8da3ba4a7874fbcf4addfff611c8dd0b2ab62a0","unresolved":false,"context_lines":[{"line_number":4891,"context_line":"            context, instance, bdms, network_info,"},{"line_number":4892,"context_line":"            fields.NotificationPhase.END)"},{"line_number":4893,"context_line":""},{"line_number":4894,"context_line":"    def _send_finish_resize_notifications("},{"line_number":4895,"context_line":"            self, context, instance, bdms, network_info, phase):"},{"line_number":4896,"context_line":"        \"\"\"Send notifications for the finish_resize flow."},{"line_number":4897,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_e35e31e8","line":4894,"updated":"2019-02-06 13:38:11.000000000","message":"This seems identical to [1] with the exception of `action`, which could be a parameter. Can we DRY?\n\n[1] https://review.openstack.org/#/c/634831/2/nova/compute/manager.py","commit_id":"05df13e16e175fc54d06036f071901d533c90cdd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"684445b9fe53704ceef9bb45d1e99037c93cedcb","unresolved":false,"context_lines":[{"line_number":4891,"context_line":"            context, instance, bdms, network_info,"},{"line_number":4892,"context_line":"            fields.NotificationPhase.END)"},{"line_number":4893,"context_line":""},{"line_number":4894,"context_line":"    def _send_finish_resize_notifications("},{"line_number":4895,"context_line":"            self, context, instance, bdms, network_info, phase):"},{"line_number":4896,"context_line":"        \"\"\"Send notifications for the finish_resize flow."},{"line_number":4897,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_dd90a551","line":4894,"in_reply_to":"9fdfeff1_793c2ebf","updated":"2019-02-06 15:53:22.000000000","message":"That *is* annoying.","commit_id":"05df13e16e175fc54d06036f071901d533c90cdd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5fbfabf01ab2201ebd6b46c49fea8376e874edad","unresolved":false,"context_lines":[{"line_number":4891,"context_line":"            context, instance, bdms, network_info,"},{"line_number":4892,"context_line":"            fields.NotificationPhase.END)"},{"line_number":4893,"context_line":""},{"line_number":4894,"context_line":"    def _send_finish_resize_notifications("},{"line_number":4895,"context_line":"            self, context, instance, bdms, network_info, phase):"},{"line_number":4896,"context_line":"        \"\"\"Send notifications for the finish_resize flow."},{"line_number":4897,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_793c2ebf","line":4894,"in_reply_to":"9fdfeff1_e35e31e8","updated":"2019-02-06 14:56:31.000000000","message":"The difference with that one is the action is the same for the legacy and versioned notification, but this one is an annoyingly different action for the legacy (finish_resize) and versioned (resize_finish) notification.","commit_id":"05df13e16e175fc54d06036f071901d533c90cdd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a750a29acd55d920eb46abc59be06e70b85e2a9e","unresolved":false,"context_lines":[{"line_number":4631,"context_line":"            context, instance, bdms, network_info,"},{"line_number":4632,"context_line":"            fields.NotificationPhase.END)"},{"line_number":4633,"context_line":""},{"line_number":4634,"context_line":"    def _send_finish_resize_notifications("},{"line_number":4635,"context_line":"            self, context, instance, bdms, network_info, phase):"},{"line_number":4636,"context_line":"        \"\"\"Send notifications for the finish_resize flow."},{"line_number":4637,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_08b6c98b","line":4634,"updated":"2019-02-21 22:02:24.000000000","message":"yep this look like a pretty clean refactor.\nbehavior should be identical before and after this patch\nbut you have pulled out the common code.","commit_id":"f548c91da693aa3ce1b4277c250601f799db9512"}]}