)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"622cb2471fe0dca9d3848dfdabd06047fa089cde","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Surya Seetharaman \u003csuryaseetharaman.9@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-02-06 12:32:34 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Plumbing for allowing the all-tenants filter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch lays the underground work for supporting the"},{"line_number":10,"context_line":"``all-tenants`` filter. It also modifies the logic in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_037d75e6","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":44},"updated":"2019-02-06 13:57:32.000000000","message":"nit: \"filter with down cells\"\n\nOtherwise it reads like we don\u0027t already support the all-tenants filter.","commit_id":"5fc1f74cd2ec2f42b227086e87bd247059804064"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"5e026c59d8e24f487082fd8ae32e3f6964572b8a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Surya Seetharaman \u003csuryaseetharaman.9@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-02-06 12:32:34 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Plumbing for allowing the all-tenants filter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch lays the underground work for supporting the"},{"line_number":10,"context_line":"``all-tenants`` filter. It also modifies the logic in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_7dc89973","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":44},"in_reply_to":"9fdfeff1_037d75e6","updated":"2019-02-07 09:09:29.000000000","message":"Done","commit_id":"5fc1f74cd2ec2f42b227086e87bd247059804064"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"622cb2471fe0dca9d3848dfdabd06047fa089cde","unresolved":false,"context_lines":[{"line_number":10,"context_line":"``all-tenants`` filter. It also modifies the logic in"},{"line_number":11,"context_line":"the construction of the instance.avz to"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"a) check whether it is set by the user  during boot time"},{"line_number":14,"context_line":"   and use that value if it is set."},{"line_number":15,"context_line":"b) if its not set during boot time return \"UNKNOWN\"."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_a38109c6","line":13,"range":{"start_line":13,"start_character":38,"end_line":13,"end_character":40},"updated":"2019-02-06 13:57:32.000000000","message":"single space","commit_id":"5fc1f74cd2ec2f42b227086e87bd247059804064"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"5e026c59d8e24f487082fd8ae32e3f6964572b8a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"``all-tenants`` filter. It also modifies the logic in"},{"line_number":11,"context_line":"the construction of the instance.avz to"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"a) check whether it is set by the user  during boot time"},{"line_number":14,"context_line":"   and use that value if it is set."},{"line_number":15,"context_line":"b) if its not set during boot time return \"UNKNOWN\"."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_c03f5eb3","line":13,"range":{"start_line":13,"start_character":38,"end_line":13,"end_character":40},"in_reply_to":"9fdfeff1_a38109c6","updated":"2019-02-07 09:09:29.000000000","message":"Done","commit_id":"5fc1f74cd2ec2f42b227086e87bd247059804064"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"622cb2471fe0dca9d3848dfdabd06047fa089cde","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        # we need to know further down the stack whether the \u0027all-tenants\u0027"},{"line_number":213,"context_line":"        # filter was passed with the true value or not. We pop this option in"},{"line_number":214,"context_line":"        # the compute API if its value is true."},{"line_number":215,"context_line":"        if not cell_down_support:"},{"line_number":216,"context_line":"            search_opts.pop(\u0027all_tenants\u0027, None)"},{"line_number":217,"context_line":"        else:"},{"line_number":218,"context_line":"            if not all_tenants:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_0366d552","line":215,"updated":"2019-02-06 13:57:32.000000000","message":"Let\u0027s get Dan\u0027s opinion but I kind of prefer what you suggested in the other patch that we continue to pop this as before but pass an explicit kwarg to the compute API - that way there is less funny business with checking the search_opts for the all_tenants filter - I like the more direct approach.","commit_id":"5fc1f74cd2ec2f42b227086e87bd247059804064"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"5e026c59d8e24f487082fd8ae32e3f6964572b8a","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        # we need to know further down the stack whether the \u0027all-tenants\u0027"},{"line_number":213,"context_line":"        # filter was passed with the true value or not. We pop this option in"},{"line_number":214,"context_line":"        # the compute API if its value is true."},{"line_number":215,"context_line":"        if not cell_down_support:"},{"line_number":216,"context_line":"            search_opts.pop(\u0027all_tenants\u0027, None)"},{"line_number":217,"context_line":"        else:"},{"line_number":218,"context_line":"            if not all_tenants:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_6051d20e","line":215,"in_reply_to":"9fdfeff1_0366d552","updated":"2019-02-07 09:09:29.000000000","message":"Done","commit_id":"5fc1f74cd2ec2f42b227086e87bd247059804064"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d75bbf99787f97a649533eb4f4fa2ed6c14cc55f","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        all_tenants \u003d common.is_all_tenants(search_opts)"},{"line_number":210,"context_line":"        # use the boolean from here on out so remove the entry from search_opts"},{"line_number":211,"context_line":"        # if it\u0027s present."},{"line_number":212,"context_line":"        # NOTE(tssurya): In case we support handling down cells in which case"},{"line_number":213,"context_line":"        # we need to know further down the stack whether the \u0027all-tenants\u0027"},{"line_number":214,"context_line":"        # filter was passed with the true value or not, we pass the flag"},{"line_number":215,"context_line":"        # further down the stack."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_fb72287c","line":212,"range":{"start_line":212,"start_character":64,"end_line":212,"end_character":77},"updated":"2019-02-08 14:00:17.000000000","message":"nix","commit_id":"12c38291b85a373905bd754bd210c7d1cac53662"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"2f35257b382d44d0baa53ddae43c54e8e3c28159","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        all_tenants \u003d common.is_all_tenants(search_opts)"},{"line_number":210,"context_line":"        # use the boolean from here on out so remove the entry from search_opts"},{"line_number":211,"context_line":"        # if it\u0027s present."},{"line_number":212,"context_line":"        # NOTE(tssurya): In case we support handling down cells in which case"},{"line_number":213,"context_line":"        # we need to know further down the stack whether the \u0027all-tenants\u0027"},{"line_number":214,"context_line":"        # filter was passed with the true value or not, we pass the flag"},{"line_number":215,"context_line":"        # further down the stack."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_7683af57","line":212,"range":{"start_line":212,"start_character":64,"end_line":212,"end_character":77},"in_reply_to":"9fdfeff1_fb72287c","updated":"2019-02-08 14:45:59.000000000","message":"Done","commit_id":"12c38291b85a373905bd754bd210c7d1cac53662"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d75bbf99787f97a649533eb4f4fa2ed6c14cc55f","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        # use the boolean from here on out so remove the entry from search_opts"},{"line_number":211,"context_line":"        # if it\u0027s present."},{"line_number":212,"context_line":"        # NOTE(tssurya): In case we support handling down cells in which case"},{"line_number":213,"context_line":"        # we need to know further down the stack whether the \u0027all-tenants\u0027"},{"line_number":214,"context_line":"        # filter was passed with the true value or not, we pass the flag"},{"line_number":215,"context_line":"        # further down the stack."},{"line_number":216,"context_line":"        search_opts.pop(\u0027all_tenants\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_1bf36ce9","line":213,"range":{"start_line":213,"start_character":62,"end_line":213,"end_character":73},"updated":"2019-02-08 14:00:17.000000000","message":"On the command line it\u0027s --all-tenants (for nova CLI) and --all-projects for openstack CLI. In the API it\u0027s just \"all_tenants\" so let\u0027s be consistent with the wording of this filter parameter and talk about it from the API parameter name, not the CLI.","commit_id":"12c38291b85a373905bd754bd210c7d1cac53662"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"2f35257b382d44d0baa53ddae43c54e8e3c28159","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        # use the boolean from here on out so remove the entry from search_opts"},{"line_number":211,"context_line":"        # if it\u0027s present."},{"line_number":212,"context_line":"        # NOTE(tssurya): In case we support handling down cells in which case"},{"line_number":213,"context_line":"        # we need to know further down the stack whether the \u0027all-tenants\u0027"},{"line_number":214,"context_line":"        # filter was passed with the true value or not, we pass the flag"},{"line_number":215,"context_line":"        # further down the stack."},{"line_number":216,"context_line":"        search_opts.pop(\u0027all_tenants\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_b6903797","line":213,"range":{"start_line":213,"start_character":62,"end_line":213,"end_character":73},"in_reply_to":"9fdfeff1_1bf36ce9","updated":"2019-02-08 14:45:59.000000000","message":"Done","commit_id":"12c38291b85a373905bd754bd210c7d1cac53662"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d75bbf99787f97a649533eb4f4fa2ed6c14cc55f","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        # if it\u0027s present."},{"line_number":212,"context_line":"        # NOTE(tssurya): In case we support handling down cells in which case"},{"line_number":213,"context_line":"        # we need to know further down the stack whether the \u0027all-tenants\u0027"},{"line_number":214,"context_line":"        # filter was passed with the true value or not, we pass the flag"},{"line_number":215,"context_line":"        # further down the stack."},{"line_number":216,"context_line":"        search_opts.pop(\u0027all_tenants\u0027, None)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_9b075cca","line":214,"range":{"start_line":214,"start_character":56,"end_line":214,"end_character":58},"updated":"2019-02-08 14:00:17.000000000","message":"so we","commit_id":"12c38291b85a373905bd754bd210c7d1cac53662"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"2f35257b382d44d0baa53ddae43c54e8e3c28159","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        # if it\u0027s present."},{"line_number":212,"context_line":"        # NOTE(tssurya): In case we support handling down cells in which case"},{"line_number":213,"context_line":"        # we need to know further down the stack whether the \u0027all-tenants\u0027"},{"line_number":214,"context_line":"        # filter was passed with the true value or not, we pass the flag"},{"line_number":215,"context_line":"        # further down the stack."},{"line_number":216,"context_line":"        search_opts.pop(\u0027all_tenants\u0027, None)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_169263a0","line":214,"range":{"start_line":214,"start_character":56,"end_line":214,"end_character":58},"in_reply_to":"9fdfeff1_9b075cca","updated":"2019-02-08 14:45:59.000000000","message":"Done","commit_id":"12c38291b85a373905bd754bd210c7d1cac53662"}],"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"622cb2471fe0dca9d3848dfdabd06047fa089cde","unresolved":false,"context_lines":[{"line_number":2421,"context_line":"                # and its id."},{"line_number":2422,"context_line":"                image_ref \u003d (rs.image.id if rs.image and"},{"line_number":2423,"context_line":"                             \u0027id\u0027 in rs.image else None)"},{"line_number":2424,"context_line":"                avz \u003d (rs.availability_zone"},{"line_number":2425,"context_line":"                       if rs.availability_zone is not None else \"UNKNOWN\")"},{"line_number":2426,"context_line":"                return objects.Instance(context\u003dcontext, power_state\u003d0,"},{"line_number":2427,"context_line":"                                        uuid\u003duuid,"},{"line_number":2428,"context_line":"                                        project_id\u003dim.project_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_e3c5d10b","line":2425,"range":{"start_line":2424,"start_character":16,"end_line":2425,"end_character":74},"updated":"2019-02-06 13:57:32.000000000","message":"This seems like something we should be handling in the view builder code rather than in the compute API code, I mean with the \"UNKNOWN\" value.","commit_id":"5fc1f74cd2ec2f42b227086e87bd247059804064"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"5e026c59d8e24f487082fd8ae32e3f6964572b8a","unresolved":false,"context_lines":[{"line_number":2421,"context_line":"                # and its id."},{"line_number":2422,"context_line":"                image_ref \u003d (rs.image.id if rs.image and"},{"line_number":2423,"context_line":"                             \u0027id\u0027 in rs.image else None)"},{"line_number":2424,"context_line":"                avz \u003d (rs.availability_zone"},{"line_number":2425,"context_line":"                       if rs.availability_zone is not None else \"UNKNOWN\")"},{"line_number":2426,"context_line":"                return objects.Instance(context\u003dcontext, power_state\u003d0,"},{"line_number":2427,"context_line":"                                        uuid\u003duuid,"},{"line_number":2428,"context_line":"                                        project_id\u003dim.project_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_9d73fd4d","line":2425,"range":{"start_line":2424,"start_character":16,"end_line":2425,"end_character":74},"in_reply_to":"9fdfeff1_23aaf918","updated":"2019-02-07 09:09:29.000000000","message":"Done","commit_id":"5fc1f74cd2ec2f42b227086e87bd247059804064"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9ddd555c32baa43ff2bac24828de6a26ee83f7d6","unresolved":false,"context_lines":[{"line_number":2421,"context_line":"                # and its id."},{"line_number":2422,"context_line":"                image_ref \u003d (rs.image.id if rs.image and"},{"line_number":2423,"context_line":"                             \u0027id\u0027 in rs.image else None)"},{"line_number":2424,"context_line":"                avz \u003d (rs.availability_zone"},{"line_number":2425,"context_line":"                       if rs.availability_zone is not None else \"UNKNOWN\")"},{"line_number":2426,"context_line":"                return objects.Instance(context\u003dcontext, power_state\u003d0,"},{"line_number":2427,"context_line":"                                        uuid\u003duuid,"},{"line_number":2428,"context_line":"                                        project_id\u003dim.project_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_23aaf918","line":2425,"range":{"start_line":2424,"start_character":16,"end_line":2425,"end_character":74},"in_reply_to":"9fdfeff1_e3c5d10b","updated":"2019-02-06 14:01:59.000000000","message":"Here:\n\nhttps://review.openstack.org/#/c/635146/1/nova/api/openstack/compute/views/servers.py@168","commit_id":"5fc1f74cd2ec2f42b227086e87bd247059804064"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d75bbf99787f97a649533eb4f4fa2ed6c14cc55f","unresolved":false,"context_lines":[{"line_number":2533,"context_line":"                                  construct if the relevant cell is"},{"line_number":2534,"context_line":"                                  down. If False, instances from"},{"line_number":2535,"context_line":"                                  unreachable cells will be omitted."},{"line_number":2536,"context_line":"        :param all_tenants: True if the \"--all-tenants\" filter was passed."},{"line_number":2537,"context_line":""},{"line_number":2538,"context_line":"        \"\"\""},{"line_number":2539,"context_line":"        if search_opts is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_9b30bca0","line":2536,"range":{"start_line":2536,"start_character":41,"end_line":2536,"end_character":54},"updated":"2019-02-08 14:00:17.000000000","message":"all_tenants","commit_id":"12c38291b85a373905bd754bd210c7d1cac53662"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"2f35257b382d44d0baa53ddae43c54e8e3c28159","unresolved":false,"context_lines":[{"line_number":2533,"context_line":"                                  construct if the relevant cell is"},{"line_number":2534,"context_line":"                                  down. If False, instances from"},{"line_number":2535,"context_line":"                                  unreachable cells will be omitted."},{"line_number":2536,"context_line":"        :param all_tenants: True if the \"--all-tenants\" filter was passed."},{"line_number":2537,"context_line":""},{"line_number":2538,"context_line":"        \"\"\""},{"line_number":2539,"context_line":"        if search_opts is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_56f54bec","line":2536,"range":{"start_line":2536,"start_character":41,"end_line":2536,"end_character":54},"in_reply_to":"9fdfeff1_9b30bca0","updated":"2019-02-08 14:45:59.000000000","message":"Done","commit_id":"12c38291b85a373905bd754bd210c7d1cac53662"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d75bbf99787f97a649533eb4f4fa2ed6c14cc55f","unresolved":false,"context_lines":[{"line_number":2698,"context_line":"            project \u003d search_opts.get(\u0027project_id\u0027, context.project_id)"},{"line_number":2699,"context_line":"            if all_tenants:"},{"line_number":2700,"context_line":"                # NOTE(tssurya): The only scenario where project has to be None"},{"line_number":2701,"context_line":"                # is when using \"--all-tenants\" in which case we do not want"},{"line_number":2702,"context_line":"                # the query to be restricted based on the project_id."},{"line_number":2703,"context_line":"                project \u003d None"},{"line_number":2704,"context_line":"            limit \u003d (orig_limit - len(instances)) if limit else limit"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_7b2dd844","line":2701,"range":{"start_line":2701,"start_character":33,"end_line":2701,"end_character":46},"updated":"2019-02-08 14:00:17.000000000","message":"all_tenants","commit_id":"12c38291b85a373905bd754bd210c7d1cac53662"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"2f35257b382d44d0baa53ddae43c54e8e3c28159","unresolved":false,"context_lines":[{"line_number":2698,"context_line":"            project \u003d search_opts.get(\u0027project_id\u0027, context.project_id)"},{"line_number":2699,"context_line":"            if all_tenants:"},{"line_number":2700,"context_line":"                # NOTE(tssurya): The only scenario where project has to be None"},{"line_number":2701,"context_line":"                # is when using \"--all-tenants\" in which case we do not want"},{"line_number":2702,"context_line":"                # the query to be restricted based on the project_id."},{"line_number":2703,"context_line":"                project \u003d None"},{"line_number":2704,"context_line":"            limit \u003d (orig_limit - len(instances)) if limit else limit"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_b6e5973a","line":2701,"range":{"start_line":2701,"start_character":33,"end_line":2701,"end_character":46},"in_reply_to":"9fdfeff1_7b2dd844","updated":"2019-02-08 14:45:59.000000000","message":"Done","commit_id":"12c38291b85a373905bd754bd210c7d1cac53662"}]}