)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"efd8922f431125b9f74eaa5a06c40355deaccafb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set bandwidth limits for generic vHost User interfaces"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is done for OVS vHost User interfaces but not for other types, such"},{"line_number":10,"context_line":"as those used by OpenContrail. This is a mistake. Correct it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id57e4c149616fe0896e80fca322ece79ec3bfd69"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_00aa4684","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":42},"updated":"2019-02-06 16:26:58.000000000","message":"Are you referring to this?\n\nhttps://github.com/openstack/nova/blob/b01da49dfc38057a751cb59f4a7a99dd7f20b6ff/nova/virt/libvirt/vif.py#L576","commit_id":"0ea52f6a2cc1f8474b4d2a835a2559434172d663"}],"nova/tests/unit/virt/libvirt/test_vif.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d87b1330a23bcf1c1815ad9fc550fb044bad1626","unresolved":false,"context_lines":[{"line_number":613,"context_line":"                                    flavor, CONF.libvirt.virt_type,"},{"line_number":614,"context_line":"                                    hostimpl)"},{"line_number":615,"context_line":"        # TODO(stephenfin): There doesn\u0027t appear to be any reason we should do"},{"line_number":616,"context_line":"        # this: just return \u0027nic.to_xml()\u0027 and remove \u0027_get_node\u0027"},{"line_number":617,"context_line":"        conf.add_device(nic)"},{"line_number":618,"context_line":"        return conf.to_xml()"},{"line_number":619,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_3d7ff666","line":616,"updated":"2019-02-13 15:18:06.000000000","message":"+1","commit_id":"f651ebc0ceeca70aba8c0f7e5054f598e491c848"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b1eff108155e077c61a530b4093868284c86172d","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        rx_queue_size, tx_queue_size \u003d self._get_virtio_queue_sizes(host)"},{"line_number":443,"context_line":"        designer.set_vif_host_backend_vhostuser_config("},{"line_number":444,"context_line":"            conf, mode, sock_path, rx_queue_size, tx_queue_size)"},{"line_number":445,"context_line":"        designer.set_vif_bandwidth_config(conf, inst_type)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        return conf"},{"line_number":448,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_c0cf5e55","line":445,"range":{"start_line":445,"start_character":5,"end_line":445,"end_character":58},"updated":"2019-02-06 16:30:09.000000000","message":"im pretty sure this will not work for vhost-user","commit_id":"0ea52f6a2cc1f8474b4d2a835a2559434172d663"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"6d2463c65ce0e7bebee35b2e6b6a53252ffdb203","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        rx_queue_size, tx_queue_size \u003d self._get_virtio_queue_sizes(host)"},{"line_number":443,"context_line":"        designer.set_vif_host_backend_vhostuser_config("},{"line_number":444,"context_line":"            conf, mode, sock_path, rx_queue_size, tx_queue_size)"},{"line_number":445,"context_line":"        designer.set_vif_bandwidth_config(conf, inst_type)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        return conf"},{"line_number":448,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_433618b7","line":445,"range":{"start_line":445,"start_character":5,"end_line":445,"end_character":58},"in_reply_to":"9fdfeff1_c0cf5e55","updated":"2019-02-06 16:56:24.000000000","message":"https://github.com/libvirt/libvirt/blob/568a417224e7b4656b9959b03154d45566480d65/src/conf/netdev_bandwidth_conf.h#L38\n\nWithout looking too deeply, it\u0027s highly likely that libvirt would just set kernel qdiscs to do rate limiting, and since vhost-user doesn\u0027t touch the kernel that would have to happen elsewhere.\n\nFor vhost-user the rate limiting would have to come from the bridge side or from QEMU.","commit_id":"0ea52f6a2cc1f8474b4d2a835a2559434172d663"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a55e44f2216755860365c4cc8f5de6d7fb4f46dd","unresolved":false,"context_lines":[{"line_number":575,"context_line":""},{"line_number":576,"context_line":"        # not all VIF types support bandwidth configuration"},{"line_number":577,"context_line":"        # https://github.com/libvirt/libvirt/blob/568a41722/src/conf/netdev_bandwidth_conf.h#L38"},{"line_number":578,"context_line":"        if vif.obj_name() not in (\u0027VIFVHostUser\u0027, \u0027VIFHostDevice\u0027):"},{"line_number":579,"context_line":"            designer.set_vif_bandwidth_config(conf, inst_type)"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"        if (\u0027network\u0027 in vif and \u0027mtu\u0027 in vif.network and"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_e23302aa","line":578,"updated":"2019-02-14 00:07:16.000000000","message":"I\u0027m a bit eww on this - seems like we could do better by adding a property on the vif objects in os-vif like:\n\n@property\nsupports_bw_config(self):\n    return True\n\nAnd then VIFVHostUser and VIFHostDevice would override that to return False and we could just check that value here rather than hard-code a blacklist.\n\nI realize that would require an os-vif release and all, but couldn\u0027t we do that in a follow up?","commit_id":"f651ebc0ceeca70aba8c0f7e5054f598e491c848"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"37ed8616108029da6543437844c4b282d61a9eaa","unresolved":false,"context_lines":[{"line_number":575,"context_line":""},{"line_number":576,"context_line":"        # not all VIF types support bandwidth configuration"},{"line_number":577,"context_line":"        # https://github.com/libvirt/libvirt/blob/568a41722/src/conf/netdev_bandwidth_conf.h#L38"},{"line_number":578,"context_line":"        if vif.obj_name() not in (\u0027VIFVHostUser\u0027, \u0027VIFHostDevice\u0027):"},{"line_number":579,"context_line":"            designer.set_vif_bandwidth_config(conf, inst_type)"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"        if (\u0027network\u0027 in vif and \u0027mtu\u0027 in vif.network and"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_ba00b535","line":578,"in_reply_to":"9fdfeff1_22c34a59","updated":"2019-02-14 11:54:29.000000000","message":"Sure. Proposed at [1]. Let\u0027s tackle it in a follow-up though (I\u0027m sure Sean may have other ideas about how to tackle this)\n\n[1] https://review.openstack.org/636933","commit_id":"f651ebc0ceeca70aba8c0f7e5054f598e491c848"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"beb95078e56c8d6a3fa75e6e02603898a9bc6740","unresolved":false,"context_lines":[{"line_number":575,"context_line":""},{"line_number":576,"context_line":"        # not all VIF types support bandwidth configuration"},{"line_number":577,"context_line":"        # https://github.com/libvirt/libvirt/blob/568a41722/src/conf/netdev_bandwidth_conf.h#L38"},{"line_number":578,"context_line":"        if vif.obj_name() not in (\u0027VIFVHostUser\u0027, \u0027VIFHostDevice\u0027):"},{"line_number":579,"context_line":"            designer.set_vif_bandwidth_config(conf, inst_type)"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"        if (\u0027network\u0027 in vif and \u0027mtu\u0027 in vif.network and"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_22c34a59","line":578,"in_reply_to":"9fdfeff1_e23302aa","updated":"2019-02-14 00:11:01.000000000","message":"Err doesn\u0027t really need to be a property, just a base class attribute that is overridden by the subclasses.","commit_id":"f651ebc0ceeca70aba8c0f7e5054f598e491c848"}]}