)]}'
{"nova/objects/instance_mapping.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f63d6d00fe0359cdc87a45d208555f19ec8ca1f5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027instance_uuid\u0027: fields.UUIDField(),"},{"line_number":36,"context_line":"        \u0027cell_mapping\u0027: fields.ObjectField(\u0027CellMapping\u0027, nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027project_id\u0027: fields.StringField(),"},{"line_number":38,"context_line":"        \u0027queued_for_delete\u0027: fields.BooleanField(default\u003dFalse),"},{"line_number":39,"context_line":"        }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_7df2d99c","line":38,"range":{"start_line":38,"start_character":49,"end_line":38,"end_character":62},"updated":"2019-02-06 16:00:34.000000000","message":"and this doesn\u0027t do it, huh?","commit_id":"ccec9ba82de7c9525981a34bb126e9ca98042d04"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c37dc99f32607238bbdebdc6e0b49e96eda1eb14","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027instance_uuid\u0027: fields.UUIDField(),"},{"line_number":36,"context_line":"        \u0027cell_mapping\u0027: fields.ObjectField(\u0027CellMapping\u0027, nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027project_id\u0027: fields.StringField(),"},{"line_number":38,"context_line":"        \u0027queued_for_delete\u0027: fields.BooleanField(default\u003dFalse),"},{"line_number":39,"context_line":"        }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_66932a51","line":38,"range":{"start_line":38,"start_character":49,"end_line":38,"end_character":62},"in_reply_to":"9fdfeff1_602f92f6","updated":"2019-02-06 17:54:31.000000000","message":"Because that doesn\u0027t mean the field is set, and what goes into the DB INSERT is based on changed fields, which comes from \"changes \u003d self.obj_get_changes()\" on L103.","commit_id":"ccec9ba82de7c9525981a34bb126e9ca98042d04"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ba556258d5428b4fdc08402055984da97c99e7ae","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027instance_uuid\u0027: fields.UUIDField(),"},{"line_number":36,"context_line":"        \u0027cell_mapping\u0027: fields.ObjectField(\u0027CellMapping\u0027, nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027project_id\u0027: fields.StringField(),"},{"line_number":38,"context_line":"        \u0027queued_for_delete\u0027: fields.BooleanField(default\u003dFalse),"},{"line_number":39,"context_line":"        }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_602f92f6","line":38,"range":{"start_line":38,"start_character":49,"end_line":38,"end_character":62},"in_reply_to":"9fdfeff1_7df2d99c","updated":"2019-02-06 16:31:50.000000000","message":"I too am wondering what does this do if it doesn\u0027t set a default value?","commit_id":"ccec9ba82de7c9525981a34bb126e9ca98042d04"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ed7c5991cbb16f0495c5d4e00a3acd878ee404ef","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    def create(self):"},{"line_number":103,"context_line":"        changes \u003d self.obj_get_changes()"},{"line_number":104,"context_line":"        changes \u003d self._update_with_cell_id(changes)"},{"line_number":105,"context_line":"        if \u0027queued_for_delete\u0027 not in changes:"},{"line_number":106,"context_line":"            # NOTE(danms): If we are creating a mapping, it should be"},{"line_number":107,"context_line":"            # not queued_for_delete (unless we are being asked to"},{"line_number":108,"context_line":"            # create one in deleted state for some reason)."}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_a6c11231","line":105,"updated":"2019-02-06 17:56:39.000000000","message":"Alternatively we could have just called:\n\nself.obj_set_defaults()\n\nWhich should set all fields to the default unless they are already set.","commit_id":"ccec9ba82de7c9525981a34bb126e9ca98042d04"}]}