)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e2e25f06a308ba852931404616cad7634ed51e63","unresolved":false,"context_lines":[{"line_number":2703,"context_line":"            PCI devices for SR-IOV ports"},{"line_number":2704,"context_line":"        \"\"\""},{"line_number":2705,"context_line":"        self.setup_instance_network_on_host("},{"line_number":2706,"context_line":"            context, instance, migration.dest_compute, migration\u003dmigration)"},{"line_number":2707,"context_line":""},{"line_number":2708,"context_line":"    def add_network_to_project(self, context, project_id, network_uuid\u003dNone):"},{"line_number":2709,"context_line":"        \"\"\"Force add a network to the project.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_5b0242b6","line":2706,"range":{"start_line":2706,"start_character":31,"end_line":2706,"end_character":53},"updated":"2019-02-10 20:54:02.000000000","message":"This doesn\u0027t work yet since finish_revert_resize still passes a dict.","commit_id":"da1bc7dcecb94d32da996a3437a5b99e42d61ffa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f286fa9ccd74d4725284b38476e8159a4640feed","unresolved":false,"context_lines":[{"line_number":2693,"context_line":"    def migrate_instance_finish(self, context, instance, migration):"},{"line_number":2694,"context_line":"        \"\"\"Finish migrating the network of an instance."},{"line_number":2695,"context_line":""},{"line_number":2696,"context_line":"        This is no different than calling ``setup_instance_network_on_host``"},{"line_number":2697,"context_line":"        with the destination compute service host."},{"line_number":2698,"context_line":""},{"line_number":2699,"context_line":"        :param context: nova auth request context"},{"line_number":2700,"context_line":"        :param instance: Instance object being migrated"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_0cca7f4e","line":2697,"range":{"start_line":2696,"start_character":7,"end_line":2697,"end_character":50},"updated":"2019-10-22 15:19:44.000000000","message":"This is no longer true because migrate_instance_finish now takes the provider_mappings kwarg and passes that through to setup_instance_network_on_host which setup_instance_network_on_host does not.","commit_id":"41dd86e21e60614a6996dc540d2abb23188fde12"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae744b68d579b18c65e5c83819b1f5c4df7d9f30","unresolved":false,"context_lines":[{"line_number":2693,"context_line":"    def migrate_instance_finish(self, context, instance, migration):"},{"line_number":2694,"context_line":"        \"\"\"Finish migrating the network of an instance."},{"line_number":2695,"context_line":""},{"line_number":2696,"context_line":"        This is no different than calling ``setup_instance_network_on_host``"},{"line_number":2697,"context_line":"        with the destination compute service host."},{"line_number":2698,"context_line":""},{"line_number":2699,"context_line":"        :param context: nova auth request context"},{"line_number":2700,"context_line":"        :param instance: Instance object being migrated"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_8b75c3ce","line":2697,"range":{"start_line":2696,"start_character":7,"end_line":2697,"end_character":50},"in_reply_to":"3fa7e38b_0cca7f4e","updated":"2019-10-24 20:10:57.000000000","message":"Actually with https://review.opendev.org/#/c/688387/6/nova/network/api.py they will be doing the same thing again, so there is still valid in unifying these at some point I think (after nova-network is dropped).","commit_id":"41dd86e21e60614a6996dc540d2abb23188fde12"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"285a5cf3f821b4d69bf140596fa0d025522ddd75","unresolved":false,"context_lines":[{"line_number":2703,"context_line":"            PCI devices for SR-IOV ports"},{"line_number":2704,"context_line":"        \"\"\""},{"line_number":2705,"context_line":"        self.setup_instance_network_on_host("},{"line_number":2706,"context_line":"            context, instance, migration.dest_compute, migration\u003dmigration)"},{"line_number":2707,"context_line":""},{"line_number":2708,"context_line":"    def add_network_to_project(self, context, project_id, network_uuid\u003dNone):"},{"line_number":2709,"context_line":"        \"\"\"Force add a network to the project.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_7a6c3208","line":2706,"range":{"start_line":2706,"start_character":31,"end_line":2706,"end_character":53},"updated":"2019-03-06 16:02:16.000000000","message":"Ah crap there is still stuff using a dict version of this:\n\nhttp://logs.openstack.org/43/635343/4/check/tempest-slow-py3/a2497ae/controller/logs/screen-n-cpu.txt.gz?level\u003dTRACE#_Mar_06_05_26_25_035103\n\nMar 06 05:26:25.035103 ubuntu-bionic-rax-iad-0003421801 nova-compute[20242]:   File \"/opt/stack/nova/nova/compute/manager.py\", line 6942, in post_live_migration_at_destination\nMar 06 05:26:25.035103 ubuntu-bionic-rax-iad-0003421801 nova-compute[20242]:     migration)\nMar 06 05:26:25.035103 ubuntu-bionic-rax-iad-0003421801 nova-compute[20242]:   File \"/opt/stack/nova/nova/network/neutronv2/api.py\", line 2815, in migrate_instance_finish\nMar 06 05:26:25.035103 ubuntu-bionic-rax-iad-0003421801 nova-compute[20242]:     context, instance, migration.dest_compute, migration\u003dmigration)\nMar 06 05:26:25.035103 ubuntu-bionic-rax-iad-0003421801 nova-compute[20242]: AttributeError: \u0027dict\u0027 object has no attribute \u0027dest_compute\u0027","commit_id":"41dd86e21e60614a6996dc540d2abb23188fde12"}],"nova/tests/unit/network/test_neutronv2.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0b4e53f279f7f5508cda601ff7f4ee1fb2b2f54e","unresolved":false,"context_lines":[{"line_number":5465,"context_line":"            mock.call(\u0027/v2.0/ports/%s/bindings/dest\u0027 % uuids.port2,"},{"line_number":5466,"context_line":"                      raise_exc\u003dFalse)])"},{"line_number":5467,"context_line":""},{"line_number":5468,"context_line":"    def test_migrate_instance_finish(self):"},{"line_number":5469,"context_line":"        \"\"\"Simply tests that migrate_instance_finish passes through to"},{"line_number":5470,"context_line":"        setup_instance_network_on_host."},{"line_number":5471,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_270d4690","line":5468,"updated":"2019-03-05 22:34:17.000000000","message":"This doesn\u0027t seem to be covered by bp/mox-removal-stein [1] so \\o/, but perhaps we should tag the change against that bp.\n\n[1] https://review.openstack.org/#/q/topic:bp/mox-removal-stein+(status:open+OR+status:merged)","commit_id":"41dd86e21e60614a6996dc540d2abb23188fde12"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"676d76a96a96d63dedc018b9ed955180df2fea1c","unresolved":false,"context_lines":[{"line_number":5465,"context_line":"            mock.call(\u0027/v2.0/ports/%s/bindings/dest\u0027 % uuids.port2,"},{"line_number":5466,"context_line":"                      raise_exc\u003dFalse)])"},{"line_number":5467,"context_line":""},{"line_number":5468,"context_line":"    def test_migrate_instance_finish(self):"},{"line_number":5469,"context_line":"        \"\"\"Simply tests that migrate_instance_finish passes through to"},{"line_number":5470,"context_line":"        setup_instance_network_on_host."},{"line_number":5471,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_422640ba","line":5468,"in_reply_to":"5fc1f717_270d4690","updated":"2019-03-05 22:49:03.000000000","message":"I wasn\u0027t thinking about that and that\u0027s not the reason I did it, I did it because the old tests were crap and this is much more clear for what the method does now which is simply being a pass-through.","commit_id":"41dd86e21e60614a6996dc540d2abb23188fde12"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"42fdd86dd7b5fb002b2d7caba04e19bd3a80cb96","unresolved":false,"context_lines":[{"line_number":5465,"context_line":"            mock.call(\u0027/v2.0/ports/%s/bindings/dest\u0027 % uuids.port2,"},{"line_number":5466,"context_line":"                      raise_exc\u003dFalse)])"},{"line_number":5467,"context_line":""},{"line_number":5468,"context_line":"    def test_migrate_instance_finish(self):"},{"line_number":5469,"context_line":"        \"\"\"Simply tests that migrate_instance_finish passes through to"},{"line_number":5470,"context_line":"        setup_instance_network_on_host."},{"line_number":5471,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_42a960dd","line":5468,"in_reply_to":"5fc1f717_422640ba","updated":"2019-03-05 22:56:49.000000000","message":"I understand. But I did want to check and make sure this wasn\u0027t going to blow Takashi\u0027s series out of the water, especially when I don\u0027t see the non-test side as an especially meaningful change.","commit_id":"41dd86e21e60614a6996dc540d2abb23188fde12"}]}