)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7f638a94e8641ebfca133e4b424438a7c44049e5","unresolved":false,"context_lines":[{"line_number":4078,"context_line":""},{"line_number":4079,"context_line":"            self.network_api.setup_networks_on_host(context, instance,"},{"line_number":4080,"context_line":"                                                    migration.source_compute)"},{"line_number":4081,"context_line":"            migration_p \u003d obj_base.obj_to_primitive(migration)"},{"line_number":4082,"context_line":"            # NOTE(hanrong): we need to change migration_p[\u0027dest_compute\u0027] to"},{"line_number":4083,"context_line":"            # source host temporarily. \"network_api.migrate_instance_finish\""},{"line_number":4084,"context_line":"            # will setup the network for the instance on the destination host."},{"line_number":4085,"context_line":"            # For revert resize, the instance will back to the source host, the"},{"line_number":4086,"context_line":"            # setup of the network for instance should be on the source host."},{"line_number":4087,"context_line":"            # So set the migration_p[\u0027dest_compute\u0027] to source host at here."},{"line_number":4088,"context_line":"            migration_p[\u0027dest_compute\u0027] \u003d migration.source_compute"},{"line_number":4089,"context_line":"            self.network_api.migrate_instance_finish(context,"},{"line_number":4090,"context_line":"                                                     instance,"},{"line_number":4091,"context_line":"                                                     migration_p)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_9bf8aac4","line":4088,"range":{"start_line":4081,"start_character":12,"end_line":4088,"end_character":66},"updated":"2019-02-10 20:53:43.000000000","message":"We can also drop this, but maybe in a separate change.","commit_id":"2ad333c54a8cf28a45bb263b24baac0e2ec81db5"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"b95ad9cf0dbb302fb0f6e8b0d9a2fb84e5f63a12","unresolved":false,"context_lines":[{"line_number":4474,"context_line":"    def _finish_resize(self, context, instance, migration, disk_info,"},{"line_number":4475,"context_line":"                       image_meta, bdms):"},{"line_number":4476,"context_line":"        resize_instance \u003d False  # indicates disks have been resized"},{"line_number":4477,"context_line":"        old_instance_type_id \u003d migration[\u0027old_instance_type_id\u0027]"},{"line_number":4478,"context_line":"        new_instance_type_id \u003d migration[\u0027new_instance_type_id\u0027]"},{"line_number":4479,"context_line":"        old_flavor \u003d instance.flavor  # the current flavor is now old"},{"line_number":4480,"context_line":"        # NOTE(mriedem): Get the old_vm_state so we know if we should"},{"line_number":4481,"context_line":"        # power on the instance. If old_vm_state is not set we need to default"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_96d081f9","line":4478,"range":{"start_line":4477,"start_character":8,"end_line":4478,"end_character":28},"updated":"2019-02-11 03:18:51.000000000","message":"could it be better to also change these to flavor? since you changed everything else.","commit_id":"2ad333c54a8cf28a45bb263b24baac0e2ec81db5"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d3c83a6c37c94bf33790ab381272a59d918c9867","unresolved":false,"context_lines":[{"line_number":4474,"context_line":"    def _finish_resize(self, context, instance, migration, disk_info,"},{"line_number":4475,"context_line":"                       image_meta, bdms):"},{"line_number":4476,"context_line":"        resize_instance \u003d False  # indicates disks have been resized"},{"line_number":4477,"context_line":"        old_instance_type_id \u003d migration[\u0027old_instance_type_id\u0027]"},{"line_number":4478,"context_line":"        new_instance_type_id \u003d migration[\u0027new_instance_type_id\u0027]"},{"line_number":4479,"context_line":"        old_flavor \u003d instance.flavor  # the current flavor is now old"},{"line_number":4480,"context_line":"        # NOTE(mriedem): Get the old_vm_state so we know if we should"},{"line_number":4481,"context_line":"        # power on the instance. If old_vm_state is not set we need to default"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_c7d29dfd","line":4478,"range":{"start_line":4477,"start_character":8,"end_line":4478,"end_character":28},"in_reply_to":"9fdfeff1_96d081f9","updated":"2019-02-26 20:47:06.000000000","message":"ugh, not pretty either way, considering changing the dict keys would be super gross.","commit_id":"2ad333c54a8cf28a45bb263b24baac0e2ec81db5"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d3c83a6c37c94bf33790ab381272a59d918c9867","unresolved":false,"context_lines":[{"line_number":4542,"context_line":"            # Note that we do not rollback port bindings to the source host"},{"line_number":4543,"context_line":"            # because resize_instance (on the source host) updated the"},{"line_number":4544,"context_line":"            # instance.host to point to *this* host (the destination host)"},{"line_number":4545,"context_line":"            # so the port bindings pointing at this host is correct even"},{"line_number":4546,"context_line":"            # though we failed to create the guest."},{"line_number":4547,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":4548,"context_line":"                # If we failed to create the guest on this host, reset the"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_672ad1e7","line":4545,"range":{"start_line":4545,"start_character":57,"end_line":4545,"end_character":59},"updated":"2019-02-26 20:47:06.000000000","message":"are","commit_id":"2ad333c54a8cf28a45bb263b24baac0e2ec81db5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cbe77f8898440ad6ac8d4e353ee2a78272117529","unresolved":false,"context_lines":[{"line_number":4542,"context_line":"            # Note that we do not rollback port bindings to the source host"},{"line_number":4543,"context_line":"            # because resize_instance (on the source host) updated the"},{"line_number":4544,"context_line":"            # instance.host to point to *this* host (the destination host)"},{"line_number":4545,"context_line":"            # so the port bindings pointing at this host is correct even"},{"line_number":4546,"context_line":"            # though we failed to create the guest."},{"line_number":4547,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":4548,"context_line":"                # If we failed to create the guest on this host, reset the"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_470df235","line":4545,"range":{"start_line":4545,"start_character":57,"end_line":4545,"end_character":59},"in_reply_to":"9fdfeff1_672ad1e7","updated":"2019-03-05 22:01:03.000000000","message":"Done","commit_id":"2ad333c54a8cf28a45bb263b24baac0e2ec81db5"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d3c83a6c37c94bf33790ab381272a59d918c9867","unresolved":false,"context_lines":[{"line_number":4567,"context_line":"    @wrap_exception()"},{"line_number":4568,"context_line":"    @reverts_task_state"},{"line_number":4569,"context_line":"    @wrap_instance_event(prefix\u003d\u0027compute\u0027)"},{"line_number":4570,"context_line":"    @errors_out_migration"},{"line_number":4571,"context_line":"    @wrap_instance_fault"},{"line_number":4572,"context_line":"    def finish_resize(self, context, disk_info, image, instance,"},{"line_number":4573,"context_line":"                      migration):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_e726c116","line":4570,"range":{"start_line":4570,"start_character":0,"end_line":4570,"end_character":25},"updated":"2019-02-26 20:47:06.000000000","message":"This is a behavior change, whereas the rest is refactor. Seems like maybe it would be safer to split this into its own change in case it goes kaflooey - or wants to be backported to rocky where that other change hasn\u0027t generated a bug yet :)","commit_id":"2ad333c54a8cf28a45bb263b24baac0e2ec81db5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"640b4879394c443e1a31cc11b2d58336a3f7c9a8","unresolved":false,"context_lines":[{"line_number":4567,"context_line":"    @wrap_exception()"},{"line_number":4568,"context_line":"    @reverts_task_state"},{"line_number":4569,"context_line":"    @wrap_instance_event(prefix\u003d\u0027compute\u0027)"},{"line_number":4570,"context_line":"    @errors_out_migration"},{"line_number":4571,"context_line":"    @wrap_instance_fault"},{"line_number":4572,"context_line":"    def finish_resize(self, context, disk_info, image, instance,"},{"line_number":4573,"context_line":"                      migration):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_f4464921","line":4570,"range":{"start_line":4570,"start_character":0,"end_line":4570,"end_character":25},"in_reply_to":"9fdfeff1_e726c116","updated":"2019-02-28 00:35:24.000000000","message":"Yeah I can do that.","commit_id":"2ad333c54a8cf28a45bb263b24baac0e2ec81db5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cbe77f8898440ad6ac8d4e353ee2a78272117529","unresolved":false,"context_lines":[{"line_number":4567,"context_line":"    @wrap_exception()"},{"line_number":4568,"context_line":"    @reverts_task_state"},{"line_number":4569,"context_line":"    @wrap_instance_event(prefix\u003d\u0027compute\u0027)"},{"line_number":4570,"context_line":"    @errors_out_migration"},{"line_number":4571,"context_line":"    @wrap_instance_fault"},{"line_number":4572,"context_line":"    def finish_resize(self, context, disk_info, image, instance,"},{"line_number":4573,"context_line":"                      migration):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_a71b7671","line":4570,"range":{"start_line":4570,"start_character":0,"end_line":4570,"end_character":25},"in_reply_to":"9fdfeff1_f4464921","updated":"2019-03-05 22:01:03.000000000","message":"Split out here: https://review.openstack.org/#/c/641138/","commit_id":"2ad333c54a8cf28a45bb263b24baac0e2ec81db5"}]}