)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"18d0949d4826e6d68b4062b638824224c185da48","unresolved":false,"context_lines":[{"line_number":10,"context_line":"driver will report the hypervisor type as \"QEMU\".  So we need to"},{"line_number":11,"context_line":"fix up the hypervisor type check in the live migration code that"},{"line_number":12,"context_line":"checks whether the instance has a NUMA topology."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5127227a1e3d76dd413a820b048547ba578aff6b"},{"line_number":15,"context_line":"Signed-off-by: Chris Friesen \u003cchris.friesen@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fdfeff1_c13d778e","line":13,"updated":"2019-02-28 15:01:33.000000000","message":"We should have a bug reported for this because it\u0027s already been backported to stable/rocky:\n\nhttps://review.openstack.org/#/q/I217fba9138132b107e9d62895d699d238392e761","commit_id":"701d653b5ac9a85fe691c77d6d0611f690d00d3a"}],"nova/conductor/tasks/live_migrate.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3f24fcc57153a6cff78f8e1034af84713094a6d9","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        # HyperV\u0027s vNUMA feature doesn\u0027t allow specific pinning"},{"line_number":164,"context_line":"        hypervisor_type \u003d objects.ComputeNode.get_by_host_and_nodename("},{"line_number":165,"context_line":"            self.context, self.source, self.instance.node).hypervisor_type"},{"line_number":166,"context_line":"        if hypervisor_type !\u003d obj_fields.HVType.QEMU:"},{"line_number":167,"context_line":"            return"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        msg \u003d (\u0027Instance has an associated NUMA topology. \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_3c676a28","line":166,"range":{"start_line":166,"start_character":6,"end_line":166,"end_character":53},"updated":"2019-02-06 23:00:19.000000000","message":"nit: it might be nice to add a comment to say that kvm is not a hypervior and when using virt_type kvm the hypervior_type will be qemu","commit_id":"d087e7833297e9c6ded8c569574665798a957b80"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"e0c4a522ae6b0adeb9e59fa6e03f814133ef2e74","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        # HyperV\u0027s vNUMA feature doesn\u0027t allow specific pinning"},{"line_number":164,"context_line":"        hypervisor_type \u003d objects.ComputeNode.get_by_host_and_nodename("},{"line_number":165,"context_line":"            self.context, self.source, self.instance.node).hypervisor_type"},{"line_number":166,"context_line":"        if hypervisor_type !\u003d obj_fields.HVType.QEMU:"},{"line_number":167,"context_line":"            return"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        msg \u003d (\u0027Instance has an associated NUMA topology. \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_fc98f575","line":166,"range":{"start_line":166,"start_character":6,"end_line":166,"end_character":53},"in_reply_to":"9fdfeff1_3c676a28","updated":"2019-02-07 15:20:17.000000000","message":"Done","commit_id":"d087e7833297e9c6ded8c569574665798a957b80"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"5cf80864daeec212fbe614804367eaa021766b3a","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        hypervisor_type \u003d objects.ComputeNode.get_by_host_and_nodename("},{"line_number":165,"context_line":"            self.context, self.source, self.instance.node).hypervisor_type"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        # KVM is not a hypervisor, so when using a virt_type of \"kvm\" the"},{"line_number":168,"context_line":"        # hypervior_type will still be \"QEMU\"."},{"line_number":169,"context_line":"        if hypervisor_type !\u003d \"QEMU\""},{"line_number":170,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_216483b8","line":167,"range":{"start_line":167,"start_character":23,"end_line":167,"end_character":33},"updated":"2019-02-28 15:04:34.000000000","message":"nit: hypervisor","commit_id":"701d653b5ac9a85fe691c77d6d0611f690d00d3a"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"5cf80864daeec212fbe614804367eaa021766b3a","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            self.context, self.source, self.instance.node).hypervisor_type"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        # KVM is not a hypervisor, so when using a virt_type of \"kvm\" the"},{"line_number":168,"context_line":"        # hypervior_type will still be \"QEMU\"."},{"line_number":169,"context_line":"        if hypervisor_type !\u003d \"QEMU\""},{"line_number":170,"context_line":"            return"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_81744f69","line":168,"range":{"start_line":168,"start_character":10,"end_line":168,"end_character":24},"updated":"2019-02-28 15:04:34.000000000","message":"nit: hypervisor_type","commit_id":"701d653b5ac9a85fe691c77d6d0611f690d00d3a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b92e40e9d2a7a00011eb52c2ddbc4e2eeb449272","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        hypervisor_type \u003d objects.ComputeNode.get_by_host_and_nodename("},{"line_number":165,"context_line":"            self.context, self.source, self.instance.node).hypervisor_type"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        # KVM is not a hypervisor, so when using a virt_type of \"kvm\" the"},{"line_number":168,"context_line":"        # hypervior_type will still be \"QEMU\"."},{"line_number":169,"context_line":"        if hypervisor_type !\u003d \"QEMU\""},{"line_number":170,"context_line":"            return"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        msg \u003d (\u0027Instance has an associated NUMA topology. \u0027"},{"line_number":173,"context_line":"               \u0027Instance NUMA topologies, including related attributes \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_8e064120","line":170,"range":{"start_line":167,"start_character":0,"end_line":170,"end_character":18},"updated":"2019-02-08 10:50:56.000000000","message":"I wonder if there\u0027s some other way we should be checking this that doesn\u0027t rely on a free-form field?  I see the \u0027HV_DRIVER_QEMU\u0027 attribute defined in nova/virt/libvirt/host.py but I imagine we don\u0027t want to be importing libvirt specific code here","commit_id":"701d653b5ac9a85fe691c77d6d0611f690d00d3a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a923bec03ed8e0a13f6b643cd6e79d5dcb569a09","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        # KVM is not a hypervisor, so when using a virt_type of \"kvm\" the"},{"line_number":168,"context_line":"        # hypervisor_type will still be \"QEMU\"."},{"line_number":169,"context_line":"        if hypervisor_type !\u003d \"QEMU\":"},{"line_number":170,"context_line":"            return"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        msg \u003d (\u0027Instance has an associated NUMA topology. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_933a60e3","line":169,"range":{"start_line":169,"start_character":30,"end_line":169,"end_character":36},"updated":"2019-02-28 16:35:43.000000000","message":"Why not use obj_fields.HVType.QEMU here and do a case insensitive check?","commit_id":"fee7f24f26c803bab1a52adef8eb01947c4fbe12"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"19052054a9f48e3df33d87c05c342d8aa9452dca","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        # KVM is not a hypervisor, so when using a virt_type of \"kvm\" the"},{"line_number":168,"context_line":"        # hypervisor_type will still be \"QEMU\"."},{"line_number":169,"context_line":"        if hypervisor_type.lower() !\u003d obj_fields.HVType.QEMU:"},{"line_number":170,"context_line":"            return"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        msg \u003d (\u0027Instance has an associated NUMA topology. \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_1f3f4a25","line":169,"range":{"start_line":169,"start_character":37,"end_line":169,"end_character":60},"updated":"2019-02-28 22:45:54.000000000","message":"I would lower this too to be safe, but I guess it\u0027s not going to change.","commit_id":"4da058723332a58323640fabce3d95902946a07d"}]}