)]}'
{"nova/tests/unit/network/test_linux_net.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7df6d8aef2891f387ead7a16fa4d8e024ba39ed8","unresolved":false,"context_lines":[{"line_number":1281,"context_line":"        self.assertEqual(\"vlan_name\", interface)"},{"line_number":1282,"context_line":"        mock_device_exists.assert_called_once_with(\u0027vlan_name\u0027)"},{"line_number":1283,"context_line":""},{"line_number":1284,"context_line":"        expected_execute_args \u003d ["},{"line_number":1285,"context_line":"            mock.call(\u0027ip\u0027, \u0027link\u0027, \u0027add\u0027, \u0027link\u0027, \u0027eth0\u0027, \u0027name\u0027, \u0027vlan_name\u0027,"},{"line_number":1286,"context_line":"                      \u0027type\u0027, \u0027vlan\u0027, \u0027id\u0027, 1, check_exit_code\u003d[0, 2, 254],"},{"line_number":1287,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":1288,"context_line":"            ]"},{"line_number":1289,"context_line":"        self.assertEqual(expected_execute_args, mock_execute.mock_calls)"},{"line_number":1290,"context_line":"        mock_set_device_mtu.assert_called_once_with(\u0027vlan_name\u0027, \u0027MTU\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_3a5417ca","side":"PARENT","line":1287,"range":{"start_line":1284,"start_character":0,"end_line":1287,"end_character":39},"updated":"2019-07-29 17:27:21.000000000","message":"I agree with Takashi-san in that, as with earlier revs of other patches in this series, we lost the assertion of the exec arguments.","commit_id":"4007d7a8b5da599db892c7395c480dc10ec15cdf"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4bdf7e1acb12d8a847107143b9ead3e1cd6cad79","unresolved":false,"context_lines":[{"line_number":1281,"context_line":"        self.assertEqual(\"vlan_name\", interface)"},{"line_number":1282,"context_line":"        mock_device_exists.assert_called_once_with(\u0027vlan_name\u0027)"},{"line_number":1283,"context_line":""},{"line_number":1284,"context_line":"        expected_execute_args \u003d ["},{"line_number":1285,"context_line":"            mock.call(\u0027ip\u0027, \u0027link\u0027, \u0027add\u0027, \u0027link\u0027, \u0027eth0\u0027, \u0027name\u0027, \u0027vlan_name\u0027,"},{"line_number":1286,"context_line":"                      \u0027type\u0027, \u0027vlan\u0027, \u0027id\u0027, 1, check_exit_code\u003d[0, 2, 254],"},{"line_number":1287,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":1288,"context_line":"            ]"},{"line_number":1289,"context_line":"        self.assertEqual(expected_execute_args, mock_execute.mock_calls)"},{"line_number":1290,"context_line":"        mock_set_device_mtu.assert_called_once_with(\u0027vlan_name\u0027, \u0027MTU\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_5afd53af","side":"PARENT","line":1287,"range":{"start_line":1284,"start_character":0,"end_line":1287,"end_character":39},"in_reply_to":"7faddb67_3a5417ca","updated":"2019-07-29 17:36:22.000000000","message":"Addressed this by adding https://review.opendev.org/#/c/635436/25/nova/tests/unit/privsep/test_linux_net.py","commit_id":"4007d7a8b5da599db892c7395c480dc10ec15cdf"}],"nova/tests/unit/network/test_manager.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"1b20fb6032ce096c64785a720f28a95366cc6a74","unresolved":false,"context_lines":[{"line_number":2895,"context_line":"    @mock.patch(\u0027nova.privsep.linux_net._enable_ipv4_forwarding_inner\u0027)"},{"line_number":2896,"context_line":"    @mock.patch(\u0027nova.privsep.linux_net.modify_ebtables\u0027)"},{"line_number":2897,"context_line":"    @mock.patch(\u0027nova.privsep.linux_net.add_vlan\u0027)"},{"line_number":2898,"context_line":"    def test_allocate_for_instance(self, mock_add_vlan,"},{"line_number":2899,"context_line":"                                   mock_modify_ebtables,"},{"line_number":2900,"context_line":"                                   mock_forwarding_enable,"},{"line_number":2901,"context_line":"                                   mock_forwarding_check,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_a1c6ca15","line":2898,"range":{"start_line":2898,"start_character":41,"end_line":2898,"end_character":54},"updated":"2019-02-07 14:50:04.000000000","message":"The assertion for mock_add_vlan call should be added.","commit_id":"7079917451deab02811fb17c5716e3fe070fd6cb"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"1bc1453b4e36b9f33961491f15be4f4d8a8d47a9","unresolved":false,"context_lines":[{"line_number":2895,"context_line":"    @mock.patch(\u0027nova.privsep.linux_net._enable_ipv4_forwarding_inner\u0027)"},{"line_number":2896,"context_line":"    @mock.patch(\u0027nova.privsep.linux_net.modify_ebtables\u0027)"},{"line_number":2897,"context_line":"    @mock.patch(\u0027nova.privsep.linux_net.add_vlan\u0027)"},{"line_number":2898,"context_line":"    def test_allocate_for_instance(self, mock_add_vlan,"},{"line_number":2899,"context_line":"                                   mock_modify_ebtables,"},{"line_number":2900,"context_line":"                                   mock_forwarding_enable,"},{"line_number":2901,"context_line":"                                   mock_forwarding_check,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_ff9c5d5c","line":2898,"range":{"start_line":2898,"start_character":41,"end_line":2898,"end_character":54},"in_reply_to":"9fdfeff1_a1c6ca15","updated":"2019-02-08 00:28:58.000000000","message":"I disagree in that the previous version of the test did not assert a call to this code at all. Its a side effect more directly tested elsewhere.","commit_id":"7079917451deab02811fb17c5716e3fe070fd6cb"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4bdf7e1acb12d8a847107143b9ead3e1cd6cad79","unresolved":false,"context_lines":[{"line_number":2895,"context_line":"    @mock.patch(\u0027nova.privsep.linux_net._enable_ipv4_forwarding_inner\u0027)"},{"line_number":2896,"context_line":"    @mock.patch(\u0027nova.privsep.linux_net.modify_ebtables\u0027)"},{"line_number":2897,"context_line":"    @mock.patch(\u0027nova.privsep.linux_net.add_vlan\u0027)"},{"line_number":2898,"context_line":"    def test_allocate_for_instance(self, mock_add_vlan,"},{"line_number":2899,"context_line":"                                   mock_modify_ebtables,"},{"line_number":2900,"context_line":"                                   mock_forwarding_enable,"},{"line_number":2901,"context_line":"                                   mock_forwarding_check,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_3a02d7b5","line":2898,"range":{"start_line":2898,"start_character":41,"end_line":2898,"end_character":54},"in_reply_to":"9fdfeff1_ff9c5d5c","updated":"2019-07-29 17:36:22.000000000","message":"Addressed this by adding https://review.opendev.org/#/c/635436/25/nova/tests/unit/privsep/test_linux_net.py","commit_id":"7079917451deab02811fb17c5716e3fe070fd6cb"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"1b20fb6032ce096c64785a720f28a95366cc6a74","unresolved":false,"context_lines":[{"line_number":2980,"context_line":"                return_value\u003dFalse)"},{"line_number":2981,"context_line":"    @mock.patch(\u0027nova.privsep.linux_net._enable_ipv4_forwarding_inner\u0027)"},{"line_number":2982,"context_line":"    @mock.patch(\u0027nova.privsep.linux_net.add_vlan\u0027)"},{"line_number":2983,"context_line":"    def test_allocate_for_instance_with_mac(self, mock_add_vlan,"},{"line_number":2984,"context_line":"                                            mock_forwarding_enable,"},{"line_number":2985,"context_line":"                                            mock_forwarding_check,"},{"line_number":2986,"context_line":"                                            mock_address_command,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_81d386d5","line":2983,"range":{"start_line":2983,"start_character":50,"end_line":2983,"end_character":63},"updated":"2019-02-07 14:50:04.000000000","message":"ditto","commit_id":"7079917451deab02811fb17c5716e3fe070fd6cb"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"1bc1453b4e36b9f33961491f15be4f4d8a8d47a9","unresolved":false,"context_lines":[{"line_number":2980,"context_line":"                return_value\u003dFalse)"},{"line_number":2981,"context_line":"    @mock.patch(\u0027nova.privsep.linux_net._enable_ipv4_forwarding_inner\u0027)"},{"line_number":2982,"context_line":"    @mock.patch(\u0027nova.privsep.linux_net.add_vlan\u0027)"},{"line_number":2983,"context_line":"    def test_allocate_for_instance_with_mac(self, mock_add_vlan,"},{"line_number":2984,"context_line":"                                            mock_forwarding_enable,"},{"line_number":2985,"context_line":"                                            mock_forwarding_check,"},{"line_number":2986,"context_line":"                                            mock_address_command,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_9fabd173","line":2983,"range":{"start_line":2983,"start_character":50,"end_line":2983,"end_character":63},"in_reply_to":"9fdfeff1_81d386d5","updated":"2019-02-08 00:28:58.000000000","message":"I disagree in that the previous version of the test did not assert a call to this code at all. Its a side effect more directly tested elsewhere.","commit_id":"7079917451deab02811fb17c5716e3fe070fd6cb"}],"nova/tests/unit/virt/xenapi/test_xenapi.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"1b20fb6032ce096c64785a720f28a95366cc6a74","unresolved":false,"context_lines":[{"line_number":1145,"context_line":"                return_value\u003dFalse)"},{"line_number":1146,"context_line":"    @mock.patch(\u0027nova.privsep.linux_net._enable_ipv4_forwarding_inner\u0027)"},{"line_number":1147,"context_line":"    @mock.patch(\u0027nova.privsep.linux_net.add_vlan\u0027)"},{"line_number":1148,"context_line":"    def test_spawn_vlanmanager(self, mock_add_vlan, mock_forwarding_enable,"},{"line_number":1149,"context_line":"                               mock_forwarding_check,"},{"line_number":1150,"context_line":"                               mock_address_command_horrid,"},{"line_number":1151,"context_line":"                               mock_change_ip, mock_set_macaddr,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_21dadae8","line":1148,"range":{"start_line":1148,"start_character":37,"end_line":1148,"end_character":50},"updated":"2019-02-07 14:50:04.000000000","message":"ditto","commit_id":"7079917451deab02811fb17c5716e3fe070fd6cb"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"1bc1453b4e36b9f33961491f15be4f4d8a8d47a9","unresolved":false,"context_lines":[{"line_number":1145,"context_line":"                return_value\u003dFalse)"},{"line_number":1146,"context_line":"    @mock.patch(\u0027nova.privsep.linux_net._enable_ipv4_forwarding_inner\u0027)"},{"line_number":1147,"context_line":"    @mock.patch(\u0027nova.privsep.linux_net.add_vlan\u0027)"},{"line_number":1148,"context_line":"    def test_spawn_vlanmanager(self, mock_add_vlan, mock_forwarding_enable,"},{"line_number":1149,"context_line":"                               mock_forwarding_check,"},{"line_number":1150,"context_line":"                               mock_address_command_horrid,"},{"line_number":1151,"context_line":"                               mock_change_ip, mock_set_macaddr,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_bfa6d5aa","line":1148,"range":{"start_line":1148,"start_character":37,"end_line":1148,"end_character":50},"in_reply_to":"9fdfeff1_21dadae8","updated":"2019-02-08 00:28:58.000000000","message":"I disagree in that the previous version of the test did not assert a call to this code at all. Its a side effect more directly tested elsewhere.","commit_id":"7079917451deab02811fb17c5716e3fe070fd6cb"}]}