)]}'
{"nova/scheduler/filter_scheduler.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8d4e89aeb1db15c4a7a5be8ee30e79b56be3907f","unresolved":false,"context_lines":[{"line_number":490,"context_line":"            for provider_summary in provider_summaries.keys():"},{"line_number":491,"context_line":"                rp \u003d self.placement_client._get_resource_provider(context,"},{"line_number":492,"context_line":"                    provider_summary)"},{"line_number":493,"context_line":"                compute_uuids[provider_summary] \u003d rp[\u0027name\u0027]"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        return self.host_manager.get_host_states_by_uuids(context,"},{"line_number":496,"context_line":"                                                          compute_uuids,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_5bd6dec5","line":493,"updated":"2019-06-05 16:21:29.000000000","message":"I was thinking it might be better here to just query for all resource providers (one call to placement instead of several) and then do the name matching after.","commit_id":"a1d78b1e6d9ef3f06755916d7a05257d8c4164b4"}],"nova/scheduler/host_manager.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8d4e89aeb1db15c4a7a5be8ee30e79b56be3907f","unresolved":false,"context_lines":[{"line_number":630,"context_line":"            for compute_name in compute_uuids.values():"},{"line_number":631,"context_line":"                try:"},{"line_number":632,"context_line":"                    hm \u003d objects.HostMapping.get_by_host(context,"},{"line_number":633,"context_line":"                                                         compute_name)"},{"line_number":634,"context_line":"                    if not hm.cell_mapping.disabled:"},{"line_number":635,"context_line":"                        cells[hm.cell_mapping.id] \u003d hm.cell_mapping"},{"line_number":636,"context_line":"                except exception.HostMappingNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_9b11b6af","line":633,"updated":"2019-06-05 16:21:29.000000000","message":"Maybe it would be worth adding a new HostMappingList.get_by_hosts method to avoid having to loop like this.","commit_id":"a1d78b1e6d9ef3f06755916d7a05257d8c4164b4"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"3ddf9dedb5d425b79720b4c970c76f2e64386c92","unresolved":false,"context_lines":[{"line_number":633,"context_line":"                                                         compute_name)"},{"line_number":634,"context_line":"                    if not hm.cell_mapping.disabled:"},{"line_number":635,"context_line":"                        cells[hm.cell_mapping.id] \u003d hm.cell_mapping"},{"line_number":636,"context_line":"                except exception.HostMappingNotFound:"},{"line_number":637,"context_line":"                    LOG.error(\"HM not found for %s\", compute_name)"},{"line_number":638,"context_line":"            results \u003d context_module.scatter_gather_cells(context,"},{"line_number":639,"context_line":"                                                          cells.values(),"},{"line_number":640,"context_line":"                                                          timeout,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_f093d04d","line":637,"range":{"start_line":636,"start_character":16,"end_line":637,"end_character":65},"updated":"2019-02-27 05:59:42.000000000","message":"handle the ironic use case, since for the ironic nodes only the compute hosting them virtually would have a mapping.","commit_id":"a1d78b1e6d9ef3f06755916d7a05257d8c4164b4"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"3ddf9dedb5d425b79720b4c970c76f2e64386c92","unresolved":false,"context_lines":[{"line_number":636,"context_line":"                except exception.HostMappingNotFound:"},{"line_number":637,"context_line":"                    LOG.error(\"HM not found for %s\", compute_name)"},{"line_number":638,"context_line":"            results \u003d context_module.scatter_gather_cells(context,"},{"line_number":639,"context_line":"                                                          cells.values(),"},{"line_number":640,"context_line":"                                                          timeout,"},{"line_number":641,"context_line":"                                                          targeted_operation)"},{"line_number":642,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_f0bc30bc","line":639,"range":{"start_line":639,"start_character":58,"end_line":639,"end_character":72},"updated":"2019-02-27 05:59:42.000000000","message":"probably this is a very cern centric use case and people with a single cell deployment might not fancy doing this to just get to the same one cell they would have got through querying the cell_mappings.. :/","commit_id":"a1d78b1e6d9ef3f06755916d7a05257d8c4164b4"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8d4e89aeb1db15c4a7a5be8ee30e79b56be3907f","unresolved":false,"context_lines":[{"line_number":636,"context_line":"                except exception.HostMappingNotFound:"},{"line_number":637,"context_line":"                    LOG.error(\"HM not found for %s\", compute_name)"},{"line_number":638,"context_line":"            results \u003d context_module.scatter_gather_cells(context,"},{"line_number":639,"context_line":"                                                          cells.values(),"},{"line_number":640,"context_line":"                                                          timeout,"},{"line_number":641,"context_line":"                                                          targeted_operation)"},{"line_number":642,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_db2e4ef9","line":639,"range":{"start_line":639,"start_character":58,"end_line":639,"end_character":72},"in_reply_to":"9fdfeff1_f0bc30bc","updated":"2019-06-05 16:21:29.000000000","message":"Fair, but I\u0027m reminded of another conf option we have CONF.api.instance_list_per_project_cells which is a similar thing where single cell ppl can not enable it. Maybe we could have another conf option for this?","commit_id":"a1d78b1e6d9ef3f06755916d7a05257d8c4164b4"}]}