)]}'
{"nova/tests/test_libvirt.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"67aa970f616a2730dc7954f667095f7927944a57","unresolved":false,"context_lines":[{"line_number":2315,"context_line":"        instances \u003d [{\u0027uuid\u0027: \u0027fake_uuid1\u0027, \u0027vm_state\u0027: vm_states.ACTIVE,"},{"line_number":2316,"context_line":"                      \u0027task_state\u0027: task_states.RESIZE_VERIFY},"},{"line_number":2317,"context_line":"                     {\u0027uuid\u0027: \u0027noexist\u0027},"},{"line_number":2318,"context_line":"                     {\u0027uuid\u0027: \u0027fake_uuid1\u0027, \u0027vm_state\u0027: vm_states.DELETED,"},{"line_number":2319,"context_line":"                      \u0027task_state\u0027: None},"},{"line_number":2320,"context_line":"                     {\u0027uuid\u0027: \u0027fake_uuid3\u0027, \u0027vm_state\u0027: vm_states.ACTIVE,"},{"line_number":2321,"context_line":"                      \u0027task_state\u0027: task_states.RESIZE_VERIFY}]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAFX%2F%2F%2FMI%3D","line":2318,"updated":"2012-04-09 14:59:42.000000000","message":"This has the same UUID as the first... not sure if that will affect the results before (and if it doesn\u0027t, should it?)","commit_id":"7dfa8bda46a6dc7c5e4f8fccd0e9a22d15bb06fe"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"67aa970f616a2730dc7954f667095f7927944a57","unresolved":false,"context_lines":[{"line_number":2331,"context_line":""},{"line_number":2332,"context_line":"        # test success (ACTIVE/RESIZE_VERIFY)"},{"line_number":2333,"context_line":"        instance \u003d instances.pop(0)"},{"line_number":2334,"context_line":"        #vmops.LOG.info(mox.IgnoreArg())"},{"line_number":2335,"context_line":"        db.instance_get_by_uuid(fake_context,"},{"line_number":2336,"context_line":"                instance[\u0027uuid\u0027]).AndReturn(instance)"},{"line_number":2337,"context_line":"        self.libvirtconnection.compute_api.confirm_resize(fake_context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAFX%2F%2F%2FME%3D","line":2334,"updated":"2012-04-09 14:59:42.000000000","message":"You will want to remove this debug leftover :)","commit_id":"7dfa8bda46a6dc7c5e4f8fccd0e9a22d15bb06fe"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"67aa970f616a2730dc7954f667095f7927944a57","unresolved":false,"context_lines":[{"line_number":2358,"context_line":"                instance)"},{"line_number":2359,"context_line":""},{"line_number":2360,"context_line":"        self.mox.ReplayAll()"},{"line_number":2361,"context_line":"        self.libvirtconnection.poll_unconfirmed_resizes(resize_confirm_window)"},{"line_number":2362,"context_line":""},{"line_number":2363,"context_line":"    def test_migrate_disk_and_power_off_exception(self):"},{"line_number":2364,"context_line":"        \"\"\"Test for nova.virt.libvirt.connection.LivirtConnection"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAFX%2F%2F%2FL4%3D","line":2361,"updated":"2012-04-09 14:59:42.000000000","message":"How is the above code actually asserting anything? I\u0027m having a tough time understanding how the stubbing out of methods above without any assertions is validating the code. Could you advise?","commit_id":"7dfa8bda46a6dc7c5e4f8fccd0e9a22d15bb06fe"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"f4726b997af19257c95c2f92bbe30d576f9e2a77","unresolved":false,"context_lines":[{"line_number":37,"context_line":"from nova.api.ec2 import cloud"},{"line_number":38,"context_line":"from nova.compute import instance_types"},{"line_number":39,"context_line":"from nova.compute import power_state"},{"line_number":40,"context_line":"from nova.compute import task_states"},{"line_number":41,"context_line":"from nova.compute import utils as compute_utils"},{"line_number":42,"context_line":"from nova.compute import vm_states"},{"line_number":43,"context_line":"from nova.virt import images"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAGX%2F%2F%2F9E%3D","line":40,"updated":"2012-04-13 02:40:48.000000000","message":"This appears to be unused","commit_id":"3983828a07a0142756a3487b20eda4c98c695691"},{"author":{"_account_id":1633,"name":"unmesh-gurjar","email":"unmesh.gurjar@hp.com","username":"unmesh-gurjar"},"change_message_id":"5be38cc76251247675ecafc29527de997bc400b6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"from nova.api.ec2 import cloud"},{"line_number":38,"context_line":"from nova.compute import instance_types"},{"line_number":39,"context_line":"from nova.compute import power_state"},{"line_number":40,"context_line":"from nova.compute import task_states"},{"line_number":41,"context_line":"from nova.compute import utils as compute_utils"},{"line_number":42,"context_line":"from nova.compute import vm_states"},{"line_number":43,"context_line":"from nova.virt import images"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAGX%2F%2F%2F6Q%3D","line":40,"in_reply_to":"AAAAGX%2F%2F%2F9E%3D","updated":"2012-04-13 07:36:32.000000000","message":"Done","commit_id":"3983828a07a0142756a3487b20eda4c98c695691"}],"nova/virt/libvirt/connection.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"67aa970f616a2730dc7954f667095f7927944a57","unresolved":false,"context_lines":[{"line_number":872,"context_line":"        for migration in migrations:"},{"line_number":873,"context_line":"            migration_id \u003d migration[\u0027id\u0027]"},{"line_number":874,"context_line":"            instance_uuid \u003d migration[\u0027instance_uuid\u0027]"},{"line_number":875,"context_line":"            LOG.info(_(\"Automatically confirming migration %d\"), migration_id)"},{"line_number":876,"context_line":"            try:"},{"line_number":877,"context_line":"                instance \u003d db.instance_get_by_uuid(ctxt, instance_uuid)"},{"line_number":878,"context_line":"            except exception.InstanceNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAFX%2F%2F%2FL0%3D","line":875,"updated":"2012-04-09 14:59:42.000000000","message":"Might be good to also include the instance_uuid in the above message.","commit_id":"7dfa8bda46a6dc7c5e4f8fccd0e9a22d15bb06fe"}]}