)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"49bbe721a15f64a21aeb4a5cf1b6ad61eacca3a7","unresolved":false,"context_lines":[{"line_number":4312,"context_line":"        except exception.NotFound:"},{"line_number":4313,"context_line":"            LOG.exception(_(\u0027Failed to get compute_info for %s\u0027) % self.host)"},{"line_number":4314,"context_line":"        finally:"},{"line_number":4315,"context_line":"            instance[\u0027host\u0027] \u003d self.host"},{"line_number":4316,"context_line":"            instance[\u0027power_state\u0027] \u003d current_power_state"},{"line_number":4317,"context_line":"            instance[\u0027vm_state\u0027] \u003d vm_states.ACTIVE"},{"line_number":4318,"context_line":"            instance[\u0027task_state\u0027] \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F8tOs%3D","line":4315,"updated":"2013-12-22 07:48:55.000000000","message":"this should be instance.host \u003d\nand similarly with all below","commit_id":"8df11e59b4b622ef2a12de464d163e1965af54f8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"69f0d869d77fd9d8464f752cd81c570f26b93916","unresolved":false,"context_lines":[{"line_number":4316,"context_line":"            instance[\u0027power_state\u0027] \u003d current_power_state"},{"line_number":4317,"context_line":"            instance[\u0027vm_state\u0027] \u003d vm_states.ACTIVE"},{"line_number":4318,"context_line":"            instance[\u0027task_state\u0027] \u003d None"},{"line_number":4319,"context_line":"            instance[\u0027expected_task_state\u0027] \u003d task_states.MIGRATING"},{"line_number":4320,"context_line":"            instance[\u0027node\u0027] \u003d node_name"},{"line_number":4321,"context_line":"            instance.save()"},{"line_number":4322,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F8qKY%3D","line":4319,"updated":"2013-12-23 15:48:51.000000000","message":"...schmeep!","commit_id":"8df11e59b4b622ef2a12de464d163e1965af54f8"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"d56fbcb4409015ce6b8803c54e3026816ac82b99","unresolved":false,"context_lines":[{"line_number":4305,"context_line":"            instance.vm_state \u003d vm_states.ACTIVE"},{"line_number":4306,"context_line":"            instance.task_state \u003d None"},{"line_number":4307,"context_line":"            instance.node \u003d node_name"},{"line_number":4308,"context_line":"            instance.save(expected_task_state\u003dtask_states.MIGRATING)"},{"line_number":4309,"context_line":""},{"line_number":4310,"context_line":"        # NOTE(vish): this is necessary to update dhcp"},{"line_number":4311,"context_line":"        self.network_api.setup_networks_on_host(context, instance, self.host)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2Fqt0%3D","line":4308,"updated":"2014-01-03 20:17:33.000000000","message":"I think original invocation of _instance_update() will also update the resource tracker while the instance.save() will not update it?\n\nI\u0027d suggest to change the _instance_update to use instance object instead of the instance_uuid. I think most of the caller of the _instance_update already has the instance object already.","commit_id":"f4bc249f16bc7c5de6f7d9f46beb6e113112b80c"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"f8ba7fd26a3ff7813a79258d9d612ce2cf4cca53","unresolved":false,"context_lines":[{"line_number":4346,"context_line":"        #                  multi_host does not create the bridge in"},{"line_number":4347,"context_line":"        #                  plug_vifs"},{"line_number":4348,"context_line":"        self.network_api.setup_networks_on_host(context, instance,"},{"line_number":4349,"context_line":"                                                         self.host)"},{"line_number":4350,"context_line":"        migration \u003d {\u0027source_compute\u0027: instance[\u0027host\u0027],"},{"line_number":4351,"context_line":"                     \u0027dest_compute\u0027: self.host, }"},{"line_number":4352,"context_line":"        self.conductor_api.network_migrate_instance_finish(context,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F9lUw%3D","line":4349,"updated":"2014-02-05 21:43:31.000000000","message":"instance.host","commit_id":"5dc906358a00e53b107e8d2e3fedc34c56f8b2e9"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"0789de16469d1ea9635a6bec308d9d9b99e1d459","unresolved":false,"context_lines":[{"line_number":4900,"context_line":"                False,"},{"line_number":4901,"context_line":"                fake_block_dev_info)"},{"line_number":4902,"context_line":"        self.compute._get_power_state(self.admin_ctxt,"},{"line_number":4903,"context_line":"                                      self.instance).AndReturn(10001)"},{"line_number":4904,"context_line":""},{"line_number":4905,"context_line":"    def _finish_post_live_migration_at_destination(self):"},{"line_number":4906,"context_line":"        self.compute.network_api.setup_networks_on_host(self.admin_ctxt,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2FzpM%3D","line":4903,"updated":"2013-12-31 05:38:17.000000000","message":"Why update the fake return value here?","commit_id":"d99486d3b6daa046f0d808960ba769d9fd5a0182"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"d56fbcb4409015ce6b8803c54e3026816ac82b99","unresolved":false,"context_lines":[{"line_number":4901,"context_line":"                fake_block_dev_info)"},{"line_number":4902,"context_line":"        self.compute._get_power_state(self.admin_ctxt,"},{"line_number":4903,"context_line":"                                      self.instance).AndReturn(10001)"},{"line_number":4904,"context_line":""},{"line_number":4905,"context_line":"    def _finish_post_live_migration_at_destination(self):"},{"line_number":4906,"context_line":"        self.compute.network_api.setup_networks_on_host(self.admin_ctxt,"},{"line_number":4907,"context_line":"                mox.IgnoreArg(), self.compute.host)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2Fqts%3D","line":4904,"updated":"2014-01-03 20:17:33.000000000","message":"Why the magic number of 10001?","commit_id":"f4bc249f16bc7c5de6f7d9f46beb6e113112b80c"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"ce4aa996f65cc1d8cd8994f273019e4251b0c044","unresolved":false,"context_lines":[{"line_number":5053,"context_line":"                False,"},{"line_number":5054,"context_line":"                fake_block_dev_info)"},{"line_number":5055,"context_line":"        self.compute._get_power_state(self.admin_ctxt,"},{"line_number":5056,"context_line":"                                      self.instance).AndReturn(10001)"},{"line_number":5057,"context_line":""},{"line_number":5058,"context_line":"    def _finish_post_live_migration_at_destination(self):"},{"line_number":5059,"context_line":"        self.compute.network_api.setup_networks_on_host(self.admin_ctxt,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUX%2F%2Fcw4%3D","line":5056,"updated":"2014-02-13 05:27:47.000000000","message":"May I know why here return 10001, I noticed that someone also asked this question but did not get answer.","commit_id":"4a590df136ce9aa61bc7dc3bdca5e5bf1e5eb63e"}]}