)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"b384a69dfe63934a257380decb5699071ddd92eb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix memtune parameters according to libvirt docs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"LibvirtConfigGuestMemoryTune created memtune element with attribute \"units\","},{"line_number":10,"context_line":"although libvirt docs mention that it should be \"unit\". It did not cause"},{"line_number":11,"context_line":"any issues, because LibvirtConfigGuestMemoryTune is not used anywhere"},{"line_number":12,"context_line":"yet."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_8daff0e1","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":54},"updated":"2019-02-12 14:16:51.000000000","message":"Maybe link to https://libvirt.org/formatdomain.html#elementsMemoryTuning here in case anyone wants to check this themselves?","commit_id":"8d222d8a13bfffa6e5bd6d2d9c8713be46e32c5a"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"a52c1b30bfe8485ceb2a4fbf8092bd9cab62eb0e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix memtune parameters according to libvirt docs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"LibvirtConfigGuestMemoryTune created memtune element with attribute \"units\","},{"line_number":10,"context_line":"although libvirt docs mention that it should be \"unit\". It did not cause"},{"line_number":11,"context_line":"any issues, because LibvirtConfigGuestMemoryTune is not used anywhere"},{"line_number":12,"context_line":"yet."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_f85052d7","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":54},"in_reply_to":"9fdfeff1_6dfc0cb5","updated":"2019-08-21 13:47:13.000000000","message":"Done","commit_id":"8d222d8a13bfffa6e5bd6d2d9c8713be46e32c5a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6a499a8f9b5ae03c1610b23ff716b49cdb369446","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix memtune parameters according to libvirt docs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"LibvirtConfigGuestMemoryTune created memtune element with attribute \"units\","},{"line_number":10,"context_line":"although libvirt docs mention that it should be \"unit\". It did not cause"},{"line_number":11,"context_line":"any issues, because LibvirtConfigGuestMemoryTune is not used anywhere"},{"line_number":12,"context_line":"yet."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_6dfc0cb5","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":54},"in_reply_to":"9fdfeff1_8daff0e1","updated":"2019-02-12 14:28:19.000000000","message":"Agree","commit_id":"8d222d8a13bfffa6e5bd6d2d9c8713be46e32c5a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6a499a8f9b5ae03c1610b23ff716b49cdb369446","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"LibvirtConfigGuestMemoryTune created memtune element with attribute \"units\","},{"line_number":10,"context_line":"although libvirt docs mention that it should be \"unit\". It did not cause"},{"line_number":11,"context_line":"any issues, because LibvirtConfigGuestMemoryTune is not used anywhere"},{"line_number":12,"context_line":"yet."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Rename the attribute from \"units\" to \"unit\" and use the same unit format"},{"line_number":15,"context_line":"as everywhere else in the code."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_ad1f5406","line":12,"range":{"start_line":11,"start_character":12,"end_line":12,"end_character":4},"updated":"2019-02-12 14:28:19.000000000","message":"or because the default is KiB anyway (per the docs)? Is the XML strictly schema-checked to where an unrecognized attribute name (\"units\") would blow it up, or would it just be ignored?","commit_id":"8d222d8a13bfffa6e5bd6d2d9c8713be46e32c5a"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"a52c1b30bfe8485ceb2a4fbf8092bd9cab62eb0e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"LibvirtConfigGuestMemoryTune created memtune element with attribute \"units\","},{"line_number":10,"context_line":"although libvirt docs mention that it should be \"unit\". It did not cause"},{"line_number":11,"context_line":"any issues, because LibvirtConfigGuestMemoryTune is not used anywhere"},{"line_number":12,"context_line":"yet."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Rename the attribute from \"units\" to \"unit\" and use the same unit format"},{"line_number":15,"context_line":"as everywhere else in the code."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_b805fac3","line":12,"range":{"start_line":11,"start_character":12,"end_line":12,"end_character":4},"in_reply_to":"9fdfeff1_716066d0","updated":"2019-08-21 13:47:13.000000000","message":"I tested and \"units\" is actually accepted, as is \"K\", but they get automatically converted into \"unit\" and \"KiB\".  Updated the commit message to reflect this.","commit_id":"8d222d8a13bfffa6e5bd6d2d9c8713be46e32c5a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"db8d117e79f3421e3cc8a32ec72e7a1934fabbab","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"LibvirtConfigGuestMemoryTune created memtune element with attribute \"units\","},{"line_number":10,"context_line":"although libvirt docs mention that it should be \"unit\". It did not cause"},{"line_number":11,"context_line":"any issues, because LibvirtConfigGuestMemoryTune is not used anywhere"},{"line_number":12,"context_line":"yet."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Rename the attribute from \"units\" to \"unit\" and use the same unit format"},{"line_number":15,"context_line":"as everywhere else in the code."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_716066d0","line":12,"range":{"start_line":11,"start_character":12,"end_line":12,"end_character":4},"in_reply_to":"9fdfeff1_ad1f5406","updated":"2019-02-12 15:12:43.000000000","message":"^ yeah, maybe note this too","commit_id":"8d222d8a13bfffa6e5bd6d2d9c8713be46e32c5a"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"db8d117e79f3421e3cc8a32ec72e7a1934fabbab","unresolved":false,"context_lines":[{"line_number":2116,"context_line":"        if self.hard_limit is not None:"},{"line_number":2117,"context_line":"            root.append(self._text_node(\"hard_limit\","},{"line_number":2118,"context_line":"                                        str(self.hard_limit),"},{"line_number":2119,"context_line":"                                        unit\u003d\"KiB\"))"},{"line_number":2120,"context_line":"        if self.soft_limit is not None:"},{"line_number":2121,"context_line":"            root.append(self._text_node(\"soft_limit\","},{"line_number":2122,"context_line":"                                        str(self.soft_limit),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_1111da04","line":2119,"range":{"start_line":2119,"start_character":46,"end_line":2119,"end_character":49},"updated":"2019-02-12 15:12:43.000000000","message":"Can you call this out in the commit message. Far as I can tell, both are valid so I\u0027m not sure why we\u0027re doing this","commit_id":"8d222d8a13bfffa6e5bd6d2d9c8713be46e32c5a"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"a52c1b30bfe8485ceb2a4fbf8092bd9cab62eb0e","unresolved":false,"context_lines":[{"line_number":2116,"context_line":"        if self.hard_limit is not None:"},{"line_number":2117,"context_line":"            root.append(self._text_node(\"hard_limit\","},{"line_number":2118,"context_line":"                                        str(self.hard_limit),"},{"line_number":2119,"context_line":"                                        unit\u003d\"KiB\"))"},{"line_number":2120,"context_line":"        if self.soft_limit is not None:"},{"line_number":2121,"context_line":"            root.append(self._text_node(\"soft_limit\","},{"line_number":2122,"context_line":"                                        str(self.soft_limit),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_980efee1","line":2119,"range":{"start_line":2119,"start_character":46,"end_line":2119,"end_character":49},"in_reply_to":"9fdfeff1_1111da04","updated":"2019-08-21 13:47:13.000000000","message":"Done","commit_id":"8d222d8a13bfffa6e5bd6d2d9c8713be46e32c5a"}]}