)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff64724eba42ffebe0ea7bd91fa54c3261e18992","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support server create with ports having resource request"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A new API microversion, 2.72, is added that enables support for Neutron"},{"line_number":10,"context_line":"ports having resource request during server create, delete and interface"},{"line_number":11,"context_line":"detach operations."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I7555914473e16782d8ba4513a09ce45679962c14"},{"line_number":14,"context_line":"blueprint: bandwidth-resource-provider"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"9fdfeff1_8653a939","line":11,"range":{"start_line":10,"start_character":59,"end_line":11,"end_character":18},"updated":"2019-03-05 15:29:27.000000000","message":"Huh? You just mean that if the user creates a server with a pre-existing port with resource requests, and allocations are made to some provider based on those resource requests, that if the port is detached then the underlying allocations are removed. That\u0027s true. I read this as you\u0027d have a microversion change for detaching these types of ports, which isn\u0027t true and could be misleading (same for delete honestly). So it\u0027s a nit, but I\u0027d just say \"during server create\".\n\nIf you wanted, you could say that server delete and interface detach operations will cleanup port allocations.\n\nIt might also be worth reminding that move operations for servers with these types of ports is not yet supported and will result in a 400 error response from the API.","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"354813453eefd203e8fb92044429cd9c3551b4d8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support server create with ports having resource request"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A new API microversion, 2.72, is added that enables support for Neutron"},{"line_number":10,"context_line":"ports having resource request during server create, delete and interface"},{"line_number":11,"context_line":"detach operations."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I7555914473e16782d8ba4513a09ce45679962c14"},{"line_number":14,"context_line":"blueprint: bandwidth-resource-provider"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"9fdfeff1_a9f55ece","line":11,"range":{"start_line":10,"start_character":59,"end_line":11,"end_character":18},"in_reply_to":"9fdfeff1_8653a939","updated":"2019-03-05 16:40:35.000000000","message":"Done.","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"}],"nova/api/openstack/api_version_request.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff64724eba42ffebe0ea7bd91fa54c3261e18992","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    * 2.71 - Adds the ``server_groups`` field to ``GET /servers/{id}``,"},{"line_number":176,"context_line":"            ``PUT /servers/{server_id}`` and"},{"line_number":177,"context_line":"            ``POST /servers/{server_id}/action`` (rebuild) responses."},{"line_number":178,"context_line":"    * 2.72 - Add support for neutron ports with resource request"},{"line_number":179,"context_line":"\"\"\""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":21,"id":"9fdfeff1_49015204","line":178,"range":{"start_line":178,"start_character":13,"end_line":178,"end_character":64},"updated":"2019-03-05 15:29:27.000000000","message":"This is too generic, make it clear it\u0027s only for server create and move operations for servers with these types of ports are not yet supported.","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"354813453eefd203e8fb92044429cd9c3551b4d8","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    * 2.71 - Adds the ``server_groups`` field to ``GET /servers/{id}``,"},{"line_number":176,"context_line":"            ``PUT /servers/{server_id}`` and"},{"line_number":177,"context_line":"            ``POST /servers/{server_id}/action`` (rebuild) responses."},{"line_number":178,"context_line":"    * 2.72 - Add support for neutron ports with resource request"},{"line_number":179,"context_line":"\"\"\""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":21,"id":"9fdfeff1_3c30ca9e","line":178,"range":{"start_line":178,"start_character":13,"end_line":178,"end_character":64},"in_reply_to":"9fdfeff1_49015204","updated":"2019-03-05 16:40:35.000000000","message":"Done","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"}],"nova/api/openstack/common.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1d18a3342d10392fd048880571d6bd1602150a78","unresolved":false,"context_lines":[{"line_number":564,"context_line":"    return False"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"def instance_has_port_with_resource_request("},{"line_number":568,"context_line":"        context, instance_uuid, network_api):"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    # If we ever store any information about resource requests in the"}],"source_content_type":"text/x-python","patch_set":21,"id":"9fdfeff1_894e5a36","line":567,"range":{"start_line":567,"start_character":4,"end_line":567,"end_character":43},"updated":"2019-03-05 15:30:45.000000000","message":"Side nit for future thinking - could we re-write this to just check the instance info cache for VIFs with a profile entry that has the \u0027allocation\u0027 key now?","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"70bd2b54f6cfdb4e1e0b6fd82e17e75e662c3d3f","unresolved":false,"context_lines":[{"line_number":564,"context_line":"    return False"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"def instance_has_port_with_resource_request("},{"line_number":568,"context_line":"        context, instance_uuid, network_api):"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    # If we ever store any information about resource requests in the"}],"source_content_type":"text/x-python","patch_set":21,"id":"9fdfeff1_e9d92656","line":567,"range":{"start_line":567,"start_character":4,"end_line":567,"end_character":43},"in_reply_to":"9fdfeff1_894e5a36","updated":"2019-03-05 15:35:10.000000000","message":"Sean Mooney reminded me that relying on the cache here would probably not work for an instance that is shelved...","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"354813453eefd203e8fb92044429cd9c3551b4d8","unresolved":false,"context_lines":[{"line_number":564,"context_line":"    return False"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"def instance_has_port_with_resource_request("},{"line_number":568,"context_line":"        context, instance_uuid, network_api):"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    # If we ever store any information about resource requests in the"}],"source_content_type":"text/x-python","patch_set":21,"id":"9fdfeff1_bc1b5a1a","line":567,"range":{"start_line":567,"start_character":4,"end_line":567,"end_character":43},"in_reply_to":"9fdfeff1_e9d92656","updated":"2019-03-05 16:40:35.000000000","message":"Added a TODO here","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"eab6f911e620811f2bbdd109c1aad223654f9e72","unresolved":false,"context_lines":[{"line_number":567,"context_line":"def instance_has_port_with_resource_request("},{"line_number":568,"context_line":"        context, instance_uuid, network_api):"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    # TODO(gibi): Use instance.info_cache to see if there is VIFs with"},{"line_number":571,"context_line":"    # allocation key in the profile. If there is no such VIF for an instance"},{"line_number":572,"context_line":"    # and the instance is not shelve offloaded then we can be sure that the"},{"line_number":573,"context_line":"    # instance has no port with resource request. If the instance is shelve"}],"source_content_type":"text/x-python","patch_set":23,"id":"7fc4fb27_8e345be0","line":570,"range":{"start_line":570,"start_character":58,"end_line":570,"end_character":60},"updated":"2019-03-05 17:20:40.000000000","message":"nit: are","commit_id":"3225fb61f92e0fd736943acd2987710c569ba14f"}],"nova/api/openstack/compute/rest_api_version_history.rst":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"d1c2071434312b34c84a68b67c5d7679a1279055","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9fdfeff1_42334d63","line":888,"updated":"2019-02-22 01:32:31.000000000","message":"Descriptions for detaching an interface and the API limitations should be added, shouldn\u0027t they?","commit_id":"46f6d57a39f5e301c804b613811482668203bc68"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"86c4bbc17e5c142713eabd5a52296df7ac2fe5a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9fdfeff1_2fdc8e72","line":888,"in_reply_to":"9fdfeff1_3e8c02d6","updated":"2019-02-27 13:26:15.000000000","message":"Good points. Rubasov started a networking guide chapter for this. I will create something under the compute API guide that will add the nova specific parts like the passthrogh_whitelist and the group_policy. And also I will link to the networking guide.","commit_id":"46f6d57a39f5e301c804b613811482668203bc68"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ec4ea772d6ee777329fb68e3ede2f114159bede6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9fdfeff1_3e8c02d6","line":888,"in_reply_to":"9fdfeff1_42334d63","updated":"2019-02-24 17:59:12.000000000","message":"Yeah probably, but what I would suggest is starting an new document in the compute API guide for these types of ports and go into the details about API support and limitations there, then you can link to it from here. The API guide is more discoverable for end users than the REST API version history.","commit_id":"46f6d57a39f5e301c804b613811482668203bc68"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff64724eba42ffebe0ea7bd91fa54c3261e18992","unresolved":false,"context_lines":[{"line_number":913,"context_line":"----"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"From this version of the API users can create servers with neutron ports that"},{"line_number":916,"context_line":"have resource request (e.g. ports with QoS minimum bandwidth rule)."}],"source_content_type":"text/x-rst","patch_set":21,"id":"9fdfeff1_89165a49","line":916,"updated":"2019-03-05 15:29:27.000000000","message":"Note the restrictions on move operations in here and what, if anything, can be done for those types of servers. I guess nothing really, because you can\u0027t detach the port with the resource request, move the server, and then re-attach the port because we don\u0027t support attaching ports with resource requests.","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"354813453eefd203e8fb92044429cd9c3551b4d8","unresolved":false,"context_lines":[{"line_number":913,"context_line":"----"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"From this version of the API users can create servers with neutron ports that"},{"line_number":916,"context_line":"have resource request (e.g. ports with QoS minimum bandwidth rule)."}],"source_content_type":"text/x-rst","patch_set":21,"id":"9fdfeff1_3c91aa47","line":916,"in_reply_to":"9fdfeff1_89165a49","updated":"2019-03-05 16:40:35.000000000","message":"Done","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"eab6f911e620811f2bbdd109c1aad223654f9e72","unresolved":false,"context_lines":[{"line_number":913,"context_line":"----"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"API microversion 2.72 adds support for creating servers with neutron ports"},{"line_number":916,"context_line":"that has resource request, e.g. neutron ports with"},{"line_number":917,"context_line":"`QoS minimum bandwidth rule`_. Deleting servers with such ports have"},{"line_number":918,"context_line":"already been handled properly as well as detaching these type of ports."},{"line_number":919,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"7fc4fb27_0e562b08","line":916,"range":{"start_line":916,"start_character":5,"end_line":916,"end_character":25},"updated":"2019-03-05 17:20:40.000000000","message":"have resource requests","commit_id":"3225fb61f92e0fd736943acd2987710c569ba14f"}],"nova/exception.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff64724eba42ffebe0ea7bd91fa54c3261e18992","unresolved":false,"context_lines":[{"line_number":2162,"context_line":"class CreateWithPortResourceRequestOldVersion(Invalid):"},{"line_number":2163,"context_line":"    msg_fmt \u003d _(\"Creating servers with ports having resource requests, like a \""},{"line_number":2164,"context_line":"                \"port with a QoS minimum bandwidth policy, is not supported \""},{"line_number":2165,"context_line":"                \"with microversion \u003c 2.72\")"},{"line_number":2166,"context_line":""},{"line_number":2167,"context_line":""},{"line_number":2168,"context_line":"class InvalidReservedMemoryPagesOption(Invalid):"}],"source_content_type":"text/x-python","patch_set":21,"id":"9fdfeff1_a93d5ebd","line":2165,"range":{"start_line":2165,"start_character":17,"end_line":2165,"end_character":41},"updated":"2019-03-05 15:29:27.000000000","message":"nit: I\u0027d like to avoid the less than symbol in the error message. Could we instead say, \"is not supported until microversion 2.72.\"","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"354813453eefd203e8fb92044429cd9c3551b4d8","unresolved":false,"context_lines":[{"line_number":2162,"context_line":"class CreateWithPortResourceRequestOldVersion(Invalid):"},{"line_number":2163,"context_line":"    msg_fmt \u003d _(\"Creating servers with ports having resource requests, like a \""},{"line_number":2164,"context_line":"                \"port with a QoS minimum bandwidth policy, is not supported \""},{"line_number":2165,"context_line":"                \"with microversion \u003c 2.72\")"},{"line_number":2166,"context_line":""},{"line_number":2167,"context_line":""},{"line_number":2168,"context_line":"class InvalidReservedMemoryPagesOption(Invalid):"}],"source_content_type":"text/x-python","patch_set":21,"id":"9fdfeff1_1cb5c6d0","line":2165,"range":{"start_line":2165,"start_character":17,"end_line":2165,"end_character":41},"in_reply_to":"9fdfeff1_a93d5ebd","updated":"2019-03-05 16:40:35.000000000","message":"Done","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff64724eba42ffebe0ea7bd91fa54c3261e18992","unresolved":false,"context_lines":[{"line_number":5975,"context_line":""},{"line_number":5976,"context_line":"    def test_create_server_with_port_resource_request_old_microversion(self):"},{"line_number":5977,"context_line":""},{"line_number":5978,"context_line":"        # NOTE(gibi): 2.67 is the last microversion where nova does not support"},{"line_number":5979,"context_line":"        # this kind of create server"},{"line_number":5980,"context_line":"        self.api.microversion \u003d \u00272.67\u0027"},{"line_number":5981,"context_line":"        ex \u003d self.assertRaises("}],"source_content_type":"text/x-python","patch_set":21,"id":"9fdfeff1_c96302dd","line":5978,"range":{"start_line":5978,"start_character":24,"end_line":5978,"end_character":26},"updated":"2019-03-05 15:29:27.000000000","message":"71?","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"354813453eefd203e8fb92044429cd9c3551b4d8","unresolved":false,"context_lines":[{"line_number":5975,"context_line":""},{"line_number":5976,"context_line":"    def test_create_server_with_port_resource_request_old_microversion(self):"},{"line_number":5977,"context_line":""},{"line_number":5978,"context_line":"        # NOTE(gibi): 2.67 is the last microversion where nova does not support"},{"line_number":5979,"context_line":"        # this kind of create server"},{"line_number":5980,"context_line":"        self.api.microversion \u003d \u00272.67\u0027"},{"line_number":5981,"context_line":"        ex \u003d self.assertRaises("}],"source_content_type":"text/x-python","patch_set":21,"id":"9fdfeff1_fcb322e8","line":5978,"range":{"start_line":5978,"start_character":24,"end_line":5978,"end_character":26},"in_reply_to":"9fdfeff1_c96302dd","updated":"2019-03-05 16:40:35.000000000","message":"Done","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"}],"releasenotes/notes/support-neutron-ports-with-resource-request-cb9ad5e9757792d0.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff64724eba42ffebe0ea7bd91fa54c3261e18992","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    API microversion 2.72 adds support for creating and deleting servers with"},{"line_number":5,"context_line":"    Neutron ports that has resource request. E.g. Neutron ports with"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fdfeff1_29340eac","line":2,"updated":"2019-03-05 15:29:27.000000000","message":"The information in here should probably also be in the REST API version history doc for this microversion because release notes are per-release and easily lost over time, but the REST API version history is always \"current\" and is what people will be using for this until we have some more comprehensive documentation, either in neutron or nova docs (and we should have something in the nova docs that references the neutron docs if the majority of the documentation for this feature lives in neutron).","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"354813453eefd203e8fb92044429cd9c3551b4d8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    API microversion 2.72 adds support for creating and deleting servers with"},{"line_number":5,"context_line":"    Neutron ports that has resource request. E.g. Neutron ports with"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fdfeff1_9ccd3660","line":2,"in_reply_to":"9fdfeff1_29340eac","updated":"2019-03-05 16:40:35.000000000","message":"Good point. I\u0027ve synced the api version history doc with this reno. The is already a WIP doc patch[1] on neutron side and I will make sure that nova specific things is documented in the api guide that will also refer the neutron doc.\n\n[1]https://review.openstack.org/#/c/640390/","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff64724eba42ffebe0ea7bd91fa54c3261e18992","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    API microversion 2.72 adds support for creating and deleting servers with"},{"line_number":5,"context_line":"    Neutron ports that has resource request. E.g. Neutron ports with"},{"line_number":6,"context_line":"    `QoS minimum bandwidth rule`_. Also detaching such port with"},{"line_number":7,"context_line":"    ``DELETE /servers/{server_id}/os-interface/{port_id}`` call is supported"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fdfeff1_49863268","line":4,"range":{"start_line":4,"start_character":52,"end_line":4,"end_character":65},"updated":"2019-03-05 15:29:27.000000000","message":"This should be implied so I would remove it.","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"354813453eefd203e8fb92044429cd9c3551b4d8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    API microversion 2.72 adds support for creating and deleting servers with"},{"line_number":5,"context_line":"    Neutron ports that has resource request. E.g. Neutron ports with"},{"line_number":6,"context_line":"    `QoS minimum bandwidth rule`_. Also detaching such port with"},{"line_number":7,"context_line":"    ``DELETE /servers/{server_id}/os-interface/{port_id}`` call is supported"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fdfeff1_5cf02e92","line":4,"range":{"start_line":4,"start_character":52,"end_line":4,"end_character":65},"in_reply_to":"9fdfeff1_49863268","updated":"2019-03-05 16:40:35.000000000","message":"Done","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff64724eba42ffebe0ea7bd91fa54c3261e18992","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    API microversion 2.72 adds support for creating and deleting servers with"},{"line_number":5,"context_line":"    Neutron ports that has resource request. E.g. Neutron ports with"},{"line_number":6,"context_line":"    `QoS minimum bandwidth rule`_. Also detaching such port with"},{"line_number":7,"context_line":"    ``DELETE /servers/{server_id}/os-interface/{port_id}`` call is supported"},{"line_number":8,"context_line":"    with this microversion."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fdfeff1_69b53632","line":5,"range":{"start_line":5,"start_character":23,"end_line":5,"end_character":43},"updated":"2019-03-05 15:29:27.000000000","message":"have resource requests, e.g. Neutron...","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"354813453eefd203e8fb92044429cd9c3551b4d8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    API microversion 2.72 adds support for creating and deleting servers with"},{"line_number":5,"context_line":"    Neutron ports that has resource request. E.g. Neutron ports with"},{"line_number":6,"context_line":"    `QoS minimum bandwidth rule`_. Also detaching such port with"},{"line_number":7,"context_line":"    ``DELETE /servers/{server_id}/os-interface/{port_id}`` call is supported"},{"line_number":8,"context_line":"    with this microversion."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fdfeff1_7cedf2b5","line":5,"range":{"start_line":5,"start_character":23,"end_line":5,"end_character":43},"in_reply_to":"9fdfeff1_69b53632","updated":"2019-03-05 16:40:35.000000000","message":"Done","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff64724eba42ffebe0ea7bd91fa54c3261e18992","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    API microversion 2.72 adds support for creating and deleting servers with"},{"line_number":5,"context_line":"    Neutron ports that has resource request. E.g. Neutron ports with"},{"line_number":6,"context_line":"    `QoS minimum bandwidth rule`_. Also detaching such port with"},{"line_number":7,"context_line":"    ``DELETE /servers/{server_id}/os-interface/{port_id}`` call is supported"},{"line_number":8,"context_line":"    with this microversion."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    API limitations:"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fdfeff1_29816e4e","line":8,"range":{"start_line":6,"start_character":35,"end_line":8,"end_character":27},"updated":"2019-03-05 15:29:27.000000000","message":"Again this is confusing and could be interpreted to mean you need to specify 2.72 to detach these types of ports, which is not true.","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"354813453eefd203e8fb92044429cd9c3551b4d8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    API microversion 2.72 adds support for creating and deleting servers with"},{"line_number":5,"context_line":"    Neutron ports that has resource request. E.g. Neutron ports with"},{"line_number":6,"context_line":"    `QoS minimum bandwidth rule`_. Also detaching such port with"},{"line_number":7,"context_line":"    ``DELETE /servers/{server_id}/os-interface/{port_id}`` call is supported"},{"line_number":8,"context_line":"    with this microversion."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    API limitations:"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fdfeff1_5ce10e9b","line":8,"range":{"start_line":6,"start_character":35,"end_line":8,"end_character":27},"in_reply_to":"9fdfeff1_29816e4e","updated":"2019-03-05 16:40:35.000000000","message":"OK. Now I try to be more specific.","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff64724eba42ffebe0ea7bd91fa54c3261e18992","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    * Creating servers with Neutron networks having QoS minimum bandwidth rule"},{"line_number":13,"context_line":"      is not supported."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    * Attaching Neutron ports having resource request is not supported."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    * Attaching Neutron networks having QoS minimum bandwidth rule is not"},{"line_number":18,"context_line":"      supported."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    * Moving (resizing, migrating, live-migrating, evacuating,"},{"line_number":21,"context_line":"      unshelving after shelve offload) servers with ports having resource"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fdfeff1_898bba66","line":18,"range":{"start_line":15,"start_character":3,"end_line":18,"end_character":16},"updated":"2019-03-05 15:29:27.000000000","message":"nit: these could be combined by saying \"Neutron ports or networks having\"","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"354813453eefd203e8fb92044429cd9c3551b4d8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    * Creating servers with Neutron networks having QoS minimum bandwidth rule"},{"line_number":13,"context_line":"      is not supported."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    * Attaching Neutron ports having resource request is not supported."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    * Attaching Neutron networks having QoS minimum bandwidth rule is not"},{"line_number":18,"context_line":"      supported."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    * Moving (resizing, migrating, live-migrating, evacuating,"},{"line_number":21,"context_line":"      unshelving after shelve offload) servers with ports having resource"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fdfeff1_dce65eb1","line":18,"range":{"start_line":15,"start_character":3,"end_line":18,"end_character":16},"in_reply_to":"9fdfeff1_898bba66","updated":"2019-03-05 16:40:35.000000000","message":"Done","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff64724eba42ffebe0ea7bd91fa54c3261e18992","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      supported."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    * Moving (resizing, migrating, live-migrating, evacuating,"},{"line_number":21,"context_line":"      unshelving after shelve offload) servers with ports having resource"},{"line_number":22,"context_line":"      request is not supported in the current microversion."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    .. _QoS minimum bandwidth rule: https://docs.openstack.org/neutron/latest/admin/config-qos.html"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fdfeff1_e9efe61a","line":21,"range":{"start_line":21,"start_character":17,"end_line":21,"end_character":37},"updated":"2019-03-05 15:29:27.000000000","message":"nix - unshelving is only possible after shelve offload so the latter is implied","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3a7aa03e281b873b317a95499ca3dd2d64e9d466","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      supported."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    * Moving (resizing, migrating, live-migrating, evacuating,"},{"line_number":21,"context_line":"      unshelving after shelve offload) servers with ports having resource"},{"line_number":22,"context_line":"      request is not supported in the current microversion."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    .. _QoS minimum bandwidth rule: https://docs.openstack.org/neutron/latest/admin/config-qos.html"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fdfeff1_9f38c8d4","line":21,"range":{"start_line":21,"start_character":17,"end_line":21,"end_character":37},"in_reply_to":"9fdfeff1_e9efe61a","updated":"2019-03-05 16:33:12.000000000","message":"(10:27:04 AM) gibi: mriedem: regarding https://review.openstack.org/#/c/636360/21/releasenotes/notes/support-neutron-ports-with-resource-request-cb9ad5e9757792d0.yaml@21 I think unshelving is possible after a simple shelve without offload. And that operation is supported with bandwith as that does not need a new scheduling\n(10:30:22 AM) mriedem: gibi: yeah true","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"354813453eefd203e8fb92044429cd9c3551b4d8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      supported."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    * Moving (resizing, migrating, live-migrating, evacuating,"},{"line_number":21,"context_line":"      unshelving after shelve offload) servers with ports having resource"},{"line_number":22,"context_line":"      request is not supported in the current microversion."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    .. _QoS minimum bandwidth rule: https://docs.openstack.org/neutron/latest/admin/config-qos.html"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fdfeff1_7c7ad2ba","line":21,"range":{"start_line":21,"start_character":17,"end_line":21,"end_character":37},"in_reply_to":"9fdfeff1_e9efe61a","updated":"2019-03-05 16:40:35.000000000","message":"I think we can unshelve an instance without offloading it first. And unshelving a shelve but not offloaded instance is supported with bandwidth as it does not need a new scheduling.","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff64724eba42ffebe0ea7bd91fa54c3261e18992","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    * Moving (resizing, migrating, live-migrating, evacuating,"},{"line_number":21,"context_line":"      unshelving after shelve offload) servers with ports having resource"},{"line_number":22,"context_line":"      request is not supported in the current microversion."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    .. _QoS minimum bandwidth rule: https://docs.openstack.org/neutron/latest/admin/config-qos.html"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fdfeff1_c9d6a254","line":22,"range":{"start_line":22,"start_character":17,"end_line":22,"end_character":59},"updated":"2019-03-05 15:29:27.000000000","message":"nit: I\u0027d say, \"is not yet supported.\"","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"354813453eefd203e8fb92044429cd9c3551b4d8","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    * Moving (resizing, migrating, live-migrating, evacuating,"},{"line_number":21,"context_line":"      unshelving after shelve offload) servers with ports having resource"},{"line_number":22,"context_line":"      request is not supported in the current microversion."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    .. _QoS minimum bandwidth rule: https://docs.openstack.org/neutron/latest/admin/config-qos.html"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fdfeff1_5ca82e1f","line":22,"range":{"start_line":22,"start_character":17,"end_line":22,"end_character":59},"in_reply_to":"9fdfeff1_c9d6a254","updated":"2019-03-05 16:40:35.000000000","message":"Done","commit_id":"35cbe9290cef244142522f6bcc253888460d09ea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"eab6f911e620811f2bbdd109c1aad223654f9e72","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    API microversion 2.72 adds support for creating servers with neutron ports"},{"line_number":5,"context_line":"    that has resource request, e.g. neutron ports with"},{"line_number":6,"context_line":"    `QoS minimum bandwidth rule`_. Deleting servers with such ports have"},{"line_number":7,"context_line":"    already been handled properly as well as detaching these type of ports."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"7fc4fb27_8e49bb61","line":5,"range":{"start_line":5,"start_character":9,"end_line":5,"end_character":29},"updated":"2019-03-05 17:20:40.000000000","message":"have resource requests","commit_id":"3225fb61f92e0fd736943acd2987710c569ba14f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"eab6f911e620811f2bbdd109c1aad223654f9e72","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    * Creating servers with Neutron networks having QoS minimum bandwidth rule"},{"line_number":12,"context_line":"      is not supported."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    * Attaching Neutron ports and networks having QoS minimum bandwidth rule"},{"line_number":15,"context_line":"      is not supported."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    * Moving (resizing, migrating, live-migrating, evacuating,"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"5fc1f717_6d03350f","line":14,"range":{"start_line":14,"start_character":30,"end_line":14,"end_character":33},"updated":"2019-03-05 17:20:40.000000000","message":"nit: seems this should be \u0027or\u0027 to me but probably doesn\u0027t matter","commit_id":"3225fb61f92e0fd736943acd2987710c569ba14f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"dd74f6c30998e69a867d103a6b38747fef0c5efe","unresolved":false,"context_lines":[{"line_number":19,"context_line":"      request is not yet supported."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    .. _QoS minimum bandwidth rule: https://docs.openstack.org/neutron/latest/admin/config-qos.html"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"5fc1f717_75ee8a89","line":22,"updated":"2019-03-06 13:45:05.000000000","message":"Ideally, I\u0027d love to see some admin docs for this feature like we did for https://docs.openstack.org/nova/latest/admin/virtual-gpu.html but that can be done in a follow-up.","commit_id":"3225fb61f92e0fd736943acd2987710c569ba14f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f3234721650e9ea2d3390ff51aa5e4726ff171da","unresolved":false,"context_lines":[{"line_number":19,"context_line":"      request is not yet supported."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    .. _QoS minimum bandwidth rule: https://docs.openstack.org/neutron/latest/admin/config-qos.html"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"5fc1f717_1012b459","line":22,"in_reply_to":"5fc1f717_75ee8a89","updated":"2019-03-06 13:51:36.000000000","message":"I will FUP the nits. And there will be doc. There is a WIP patch on neutron side[1] that will cover most of the admin things, and I will add an api guide from the nova side too.\n\n[1]https://review.openstack.org/#/c/640390/","commit_id":"3225fb61f92e0fd736943acd2987710c569ba14f"}]}