)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0d32c3a90f98b2860cc20a96b5d9fc753167365a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make Claim._claim_test handle SchedulerLimits object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The _claim_test() code expects a dict but we should be able"},{"line_number":10,"context_line":"to pass is a SchedulerLimits object which is what we get"},{"line_number":11,"context_line":"back from the scheduler service and should be able to pass"},{"line_number":12,"context_line":"through to the compute."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_9333caf6","line":10,"updated":"2019-02-21 22:14:40.000000000","message":"nit: ... we should be able to it a ...","commit_id":"743d9e4dc7117412047d76c0fca6ed281265d5c7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4ed22a8ab56add909c7ea5beaeb0727c6866d574","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make Claim._claim_test handle SchedulerLimits object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The _claim_test() code expects a dict but we should be able"},{"line_number":10,"context_line":"to pass is a SchedulerLimits object which is what we get"},{"line_number":11,"context_line":"back from the scheduler service and should be able to pass"},{"line_number":12,"context_line":"through to the compute."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_137ad175","line":10,"in_reply_to":"9fdfeff1_9333caf6","updated":"2019-03-01 18:41:59.000000000","message":"I\u0027m not sure about Sean\u0027s nit, but I think you wanted /pass is/pass it/","commit_id":"743d9e4dc7117412047d76c0fca6ed281265d5c7"}],"nova/compute/claims.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"28435cea04377b03362d78db8cd23b5dc9b039bc","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self.tracker.abort_instance_claim(self.context, self.instance,"},{"line_number":125,"context_line":"                                          self.nodename)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _claim_test(self, resources, limits\u003dNone):"},{"line_number":128,"context_line":"        \"\"\"Test if this claim can be satisfied given available resources and"},{"line_number":129,"context_line":"        optional oversubscription limits"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_d88a7862","line":127,"range":{"start_line":127,"start_character":43,"end_line":127,"end_character":48},"updated":"2019-02-13 15:59:06.000000000","message":"afaict this is only called from Claim.__init__, and it\u0027s called with limits specified. Can we remove the kwarg-ness and the word \"Optional\" from the docstring while we\u0027re here?","commit_id":"743d9e4dc7117412047d76c0fca6ed281265d5c7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"835e7a3bdc51c8f4c9dd09980d39d287aff070d8","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self.tracker.abort_instance_claim(self.context, self.instance,"},{"line_number":125,"context_line":"                                          self.nodename)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _claim_test(self, resources, limits\u003dNone):"},{"line_number":128,"context_line":"        \"\"\"Test if this claim can be satisfied given available resources and"},{"line_number":129,"context_line":"        optional oversubscription limits"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_e921b04e","line":127,"range":{"start_line":127,"start_character":43,"end_line":127,"end_character":48},"in_reply_to":"9fdfeff1_d88a7862","updated":"2019-02-13 17:39:03.000000000","message":"It\u0027s always called yes so it doesn\u0027t need to be a kwarg. The \u0027optional\u0027 bit is I think more about the fact it can be empty if there are not scheduler filters which actually populate the limits.","commit_id":"743d9e4dc7117412047d76c0fca6ed281265d5c7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0d32c3a90f98b2860cc20a96b5d9fc753167365a","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            limits \u003d {}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        if isinstance(limits, objects.SchedulerLimits):"},{"line_number":144,"context_line":"            limits \u003d limits.to_dict()"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        # If an individual limit is None, the resource will be considered"},{"line_number":147,"context_line":"        # unlimited:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_b32e0e8a","line":144,"updated":"2019-02-21 22:14:40.000000000","message":"so dumb question but long term should we move this code to useing schedulerLimit objects instead of dicts.\ni assume if i did some clean up of this code at a later date to just\nuse object that would be fine?","commit_id":"743d9e4dc7117412047d76c0fca6ed281265d5c7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"01f9041d59126611354691bb655b5b74f30859c1","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            limits \u003d {}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        if isinstance(limits, objects.SchedulerLimits):"},{"line_number":144,"context_line":"            limits \u003d limits.to_dict()"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        # If an individual limit is None, the resource will be considered"},{"line_number":147,"context_line":"        # unlimited:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_98b2f548","line":144,"in_reply_to":"9fdfeff1_b32e0e8a","updated":"2019-02-22 16:54:54.000000000","message":"We probably should but it would be kind of a mess because currently the top layers (conductor) is converting the SchedulerLimits to a primitive dict for backward compat [1] for the compute service code (like this), so we\u0027d have to do quite a bit of unwinding and compat code where it matters.\n\n[1] https://github.com/openstack/nova/blob/27617ee1931b3240dbd0ad4c7d8ffd64cc202bc9/nova/scheduler/utils.py#L701","commit_id":"743d9e4dc7117412047d76c0fca6ed281265d5c7"}]}