)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82fec1986a8a48234d923039a6e8e3a00c887403","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                     migration, image_meta\u003dNone, limits\u003dNone):"},{"line_number":250,"context_line":"        \"\"\"Create a claim for a resize or cold-migration move."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        Note that this code assumes ``instance.new_flavor`` is set when"},{"line_number":253,"context_line":"        resizing with a new flavor."},{"line_number":254,"context_line":"        \"\"\""},{"line_number":255,"context_line":"        return self._move_claim(context, instance, instance_type, nodename,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_335d3e79","line":252,"updated":"2019-02-21 22:56:06.000000000","message":"+1\n\ni would have assumed from the signiture of this function that since we are passing presuable the new flaovr as the instance_type paramater that invoking self._move_claim would have use that instead of the  instance.new_flavor so it non obvious that instance.new_flavor would need to be set.\n\nso just a general question. i have wonderd why we have instance.flavor .old_flavor and .new_flavor in the past and lookin at the patch that intoduced them it was non obviobious to me. \nhttps://github.com/openstack/nova/commit/8b6a22e0e132d8dac6c280c1cd8aed2bbe980760\n\nam i correct in my understanding that instance.flavor is the current flavor the instace is useing. instance.new_flavor is the target  falvor for a resize and instance.old_flavor is used to store the current flavor so that we can restore it if we revert the resize?","commit_id":"20a46ece5701c9798a5e0df12c944237cb1ece3e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f1b4fc1c02aa5d579ba22e85de03368b3a079d79","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                     migration, image_meta\u003dNone, limits\u003dNone):"},{"line_number":250,"context_line":"        \"\"\"Create a claim for a resize or cold-migration move."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        Note that this code assumes ``instance.new_flavor`` is set when"},{"line_number":253,"context_line":"        resizing with a new flavor."},{"line_number":254,"context_line":"        \"\"\""},{"line_number":255,"context_line":"        return self._move_claim(context, instance, instance_type, nodename,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_38d18958","line":252,"in_reply_to":"9fdfeff1_335d3e79","updated":"2019-02-22 16:56:42.000000000","message":"\u003e i would have assumed from the signiture of this function that since we are passing presuable the new flaovr as the instance_type paramater that invoking self._move_claim would have use that instead of the instance.new_flavor so it non obvious that instance.new_flavor would need to be set.\n\nSame for me. Ideally that\u0027s what we\u0027d do, but it\u0027s a bigger refactor.\n\n\u003e am i correct in my understanding that instance.flavor is the current flavor the instace is useing. instance.new_flavor is the target falvor for a resize and instance.old_flavor is used to store the current flavor so that we can restore it if we revert the resize?\n\nCorrect.","commit_id":"20a46ece5701c9798a5e0df12c944237cb1ece3e"}]}