)]}'
{"nova/conductor/tasks/live_migrate.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"50681a87cdaa9f3b79a5262fa49baf023efdf14b","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        \"\"\"Return the list of hosts that have VM\u0027s from the group.\"\"\""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        # The system_metadata \u0027group\u0027 will be filtered"},{"line_number":154,"context_line":"        members \u003d db.instance_get_all_by_filters(context,"},{"line_number":155,"context_line":"                   {\u0027deleted\u0027: False, \u0027system_metadata\u0027: {\u0027group\u0027: group}})"},{"line_number":156,"context_line":"        return [member[\u0027host\u0027]"},{"line_number":157,"context_line":"                for member in members"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2F3ps%3D","line":154,"updated":"2013-12-29 08:43:06.000000000","message":"it is worth considering using the instance group object here","commit_id":"4424f3c7aabc5f70ad3ba6a7d7eebba4b91962b6"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"24c35927cf536ee0f4f3ee21031a06a29019a4b6","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        \"\"\"Return the list of hosts that have VM\u0027s from the group.\"\"\""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        # The system_metadata \u0027group\u0027 will be filtered"},{"line_number":154,"context_line":"        members \u003d db.instance_get_all_by_filters(context,"},{"line_number":155,"context_line":"                   {\u0027deleted\u0027: False, \u0027system_metadata\u0027: {\u0027group\u0027: group}})"},{"line_number":156,"context_line":"        return [member[\u0027host\u0027]"},{"line_number":157,"context_line":"                for member in members"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2F%2FZg%3D","line":154,"in_reply_to":"AAAAT3%2F%2F3ps%3D","updated":"2014-01-04 16:42:59.000000000","message":"Done","commit_id":"4424f3c7aabc5f70ad3ba6a7d7eebba4b91962b6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"50681a87cdaa9f3b79a5262fa49baf023efdf14b","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                   {\u0027deleted\u0027: False, \u0027system_metadata\u0027: {\u0027group\u0027: group}})"},{"line_number":156,"context_line":"        return [member[\u0027host\u0027]"},{"line_number":157,"context_line":"                for member in members"},{"line_number":158,"context_line":"                if member.get(\u0027host\u0027) is not None]"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def _get_filter_properties(self):"},{"line_number":161,"context_line":"        \"\"\"Populate and get filter_properties structure.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2F3po%3D","line":158,"updated":"2013-12-29 08:43:06.000000000","message":"you can drop the \u0027is not None\u0027","commit_id":"4424f3c7aabc5f70ad3ba6a7d7eebba4b91962b6"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"24c35927cf536ee0f4f3ee21031a06a29019a4b6","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                   {\u0027deleted\u0027: False, \u0027system_metadata\u0027: {\u0027group\u0027: group}})"},{"line_number":156,"context_line":"        return [member[\u0027host\u0027]"},{"line_number":157,"context_line":"                for member in members"},{"line_number":158,"context_line":"                if member.get(\u0027host\u0027) is not None]"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def _get_filter_properties(self):"},{"line_number":161,"context_line":"        \"\"\"Populate and get filter_properties structure.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2F%2FZ8%3D","line":158,"in_reply_to":"AAAAT3%2F%2F3po%3D","updated":"2014-01-04 16:42:59.000000000","message":"Done","commit_id":"4424f3c7aabc5f70ad3ba6a7d7eebba4b91962b6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"50681a87cdaa9f3b79a5262fa49baf023efdf14b","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        \"\"\"Populate and get filter_properties structure.\"\"\""},{"line_number":162,"context_line":"        # Get scheduler hints attached to the instance (which are persisted"},{"line_number":163,"context_line":"        # into the database)."},{"line_number":164,"context_line":"        scheduler_hints \u003d jsonutils.loads(self.instance.scheduler_hints)"},{"line_number":165,"context_line":"        filter_properties \u003d {\u0027scheduler_hints\u0027: scheduler_hints}"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        image \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAT3%2F%2F3pU%3D","line":164,"updated":"2013-12-29 08:43:06.000000000","message":"i have a few issues with the scheduler hints being persisted in the database. not sure if this is related to this patch set. in most cases the instance groups can solve these issues. issues that i have when say hosts are passed as a hint. will this be updated?","commit_id":"4424f3c7aabc5f70ad3ba6a7d7eebba4b91962b6"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"24c35927cf536ee0f4f3ee21031a06a29019a4b6","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        \"\"\"Populate and get filter_properties structure.\"\"\""},{"line_number":162,"context_line":"        # Get scheduler hints attached to the instance (which are persisted"},{"line_number":163,"context_line":"        # into the database)."},{"line_number":164,"context_line":"        scheduler_hints \u003d jsonutils.loads(self.instance.scheduler_hints)"},{"line_number":165,"context_line":"        filter_properties \u003d {\u0027scheduler_hints\u0027: scheduler_hints}"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        image \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2F%2FY0%3D","line":164,"in_reply_to":"AAAAT3%2F%2F3pU%3D","updated":"2014-01-04 16:42:59.000000000","message":"Gary, sorry, I\u0027m not quite catch your point, can you pls help explain it? :-)\n\nThis patch was resolving the issue that when live migrate a VM with target host, we want scheduler to help validate the host before send the request to nova compute.\n\nScheduler will go through all filters to check if the host pass all the filters with scheduler hints.\n\nNot sure if I understand correctly, seems no scheduler filter is handling host as scheduler hints.","commit_id":"4424f3c7aabc5f70ad3ba6a7d7eebba4b91962b6"}]}