)]}'
{"nova/utils.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6bf248c4d5582784d77541090d7f4213175026ff","unresolved":false,"context_lines":[{"line_number":293,"context_line":"    else:"},{"line_number":294,"context_line":"        rightnow \u003d timeutils.utcnow()"},{"line_number":295,"context_line":"    if unit not in (\u0027month\u0027, \u0027day\u0027, \u0027year\u0027, \u0027hour\u0027):"},{"line_number":296,"context_line":"        raise ValueError(_(\u0027Time period must be hour, day, month or year\u0027))"},{"line_number":297,"context_line":"    if unit \u003d\u003d \u0027month\u0027:"},{"line_number":298,"context_line":"        if offset \u003d\u003d 0:"},{"line_number":299,"context_line":"            offset \u003d 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_bedfdc38","side":"PARENT","line":296,"updated":"2019-02-20 10:12:57.000000000","message":"we stop returning a ValueError and we rather now check whether it\u0027s either one of the tuple items by conditionals.\n\nShould we raise ValueError then after all of the conditionals ?","commit_id":"9cb825b0147af3b191ea2989e5187e4afdadcb15"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f2ac9a6c6cb524492e60b4dd171984a530b01b90","unresolved":false,"context_lines":[{"line_number":293,"context_line":"    else:"},{"line_number":294,"context_line":"        rightnow \u003d timeutils.utcnow()"},{"line_number":295,"context_line":"    if unit not in (\u0027month\u0027, \u0027day\u0027, \u0027year\u0027, \u0027hour\u0027):"},{"line_number":296,"context_line":"        raise ValueError(_(\u0027Time period must be hour, day, month or year\u0027))"},{"line_number":297,"context_line":"    if unit \u003d\u003d \u0027month\u0027:"},{"line_number":298,"context_line":"        if offset \u003d\u003d 0:"},{"line_number":299,"context_line":"            offset \u003d 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_de874012","side":"PARENT","line":296,"in_reply_to":"9fdfeff1_bedfdc38","updated":"2019-02-20 10:17:46.000000000","message":"I don\u0027t think there\u0027s any need, since the value of unit is limited by our regex:\n\nhttps://review.openstack.org/#/c/636627/1/nova/conf/base.py@29","commit_id":"9cb825b0147af3b191ea2989e5187e4afdadcb15"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d69a32d9afd67dbef4d49c34393fc89944e3b1e9","unresolved":false,"context_lines":[{"line_number":293,"context_line":"    else:"},{"line_number":294,"context_line":"        rightnow \u003d timeutils.utcnow()"},{"line_number":295,"context_line":"    if unit not in (\u0027month\u0027, \u0027day\u0027, \u0027year\u0027, \u0027hour\u0027):"},{"line_number":296,"context_line":"        raise ValueError(_(\u0027Time period must be hour, day, month or year\u0027))"},{"line_number":297,"context_line":"    if unit \u003d\u003d \u0027month\u0027:"},{"line_number":298,"context_line":"        if offset \u003d\u003d 0:"},{"line_number":299,"context_line":"            offset \u003d 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_5ef7d08d","side":"PARENT","line":296,"in_reply_to":"9fdfeff1_de874012","updated":"2019-02-20 10:22:24.000000000","message":"\u003e I don\u0027t think there\u0027s any need, since the value of unit is limited\n \u003e by our regex:\n \u003e \n \u003e https://review.openstack.org/#/c/636627/1/nova/conf/base.py@29\n\nAll good then.","commit_id":"9cb825b0147af3b191ea2989e5187e4afdadcb15"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6bf248c4d5582784d77541090d7f4213175026ff","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        end \u003d rightnow.replace(minute\u003doffset, second\u003d0, microsecond\u003d0)"},{"line_number":346,"context_line":"        if end \u003e\u003d rightnow:"},{"line_number":347,"context_line":"            end \u003d end - datetime.timedelta(hours\u003d1)"},{"line_number":348,"context_line":"        begin \u003d end - datetime.timedelta(hours\u003d1)"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    return (begin, end)"},{"line_number":351,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_7ee174fc","line":348,"updated":"2019-02-20 10:12:57.000000000","message":"I mean, we could raise ValueError here to not change the behaviour.","commit_id":"f3b7b972ddea69649cfa6c79cad5a4220a2588c7"}]}