)]}'
{"nova/tests/functional/regressions/test_bug_1671648.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"e9ad05779b898f8be20330000a494d5e095c7bac","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        self.addCleanup(fake.restore_nodes)"},{"line_number":78,"context_line":"        self.start_service(\u0027compute\u0027, host\u003d\u0027host1\u0027)"},{"line_number":79,"context_line":"        fake.set_nodes([\u0027host2\u0027])"},{"line_number":80,"context_line":"        self.addCleanup(fake.restore_nodes)"},{"line_number":81,"context_line":"        self.start_service(\u0027compute\u0027, host\u003d\u0027host2\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        self.scheduler_service \u003d self.start_service(\u0027scheduler\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_afddccdd","side":"PARENT","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":43},"updated":"2019-02-14 21:13:04.000000000","message":"The way this is used makes a guy wonder whether the intent was to call the method, rather than waiting until the end of the test case.\n\n[Later] FWIW, the test still passes when I do that ^\n\nSeems to me like the overridden node list is just there for the compute service to pick up during start_service. If it were going to have an impact anywhere else in the test case, it would have screwed things up by always being set to the *last* node list we set_nodes()d.","commit_id":"ee57c92e8b675adf3f35de29f7cea9c9d042d44b"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"15ae8f770ed6839f8343ab67f34b7a518b4f9018","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        self.addCleanup(fake.restore_nodes)"},{"line_number":78,"context_line":"        self.start_service(\u0027compute\u0027, host\u003d\u0027host1\u0027)"},{"line_number":79,"context_line":"        fake.set_nodes([\u0027host2\u0027])"},{"line_number":80,"context_line":"        self.addCleanup(fake.restore_nodes)"},{"line_number":81,"context_line":"        self.start_service(\u0027compute\u0027, host\u003d\u0027host2\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        self.scheduler_service \u003d self.start_service(\u0027scheduler\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_90c7e498","side":"PARENT","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":43},"in_reply_to":"9fdfeff1_afddccdd","updated":"2019-02-27 05:37:41.000000000","message":"Using addClenup method is better because there is a possiblity to raise an error(exception) in start_service method.","commit_id":"ee57c92e8b675adf3f35de29f7cea9c9d042d44b"}]}