)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f72830109e562085b8e599e3428d0ee688761cde","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix query method for nova compute services by compute_driver types"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the nova compute services that been changed types of compute_driver"},{"line_number":10,"context_line":"can still be queried by old type"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1815849"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_5cfe2906","line":9,"updated":"2019-03-05 21:09:24.000000000","message":"This does not really explain the bug or how this fixes it. Please explain the issue in the commit message and how this addresses it.","commit_id":"cb4b6eb239a21520841cf035b93ce095472278fe"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"522f1f9d2aeebe755e00ea67fccb1ad61c11930c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"bug:the nova compute services have been changed types of compute_driver"},{"line_number":10,"context_line":"with old host name can still be queried by old type."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The sevice is not deleted  in the \u0027Service\u0027 table, due to  it\u0027s host "},{"line_number":13,"context_line":"name dosen\u0027t change. But the old \u0027hv_type\u0027 compute nodes which once been"},{"line_number":14,"context_line":"managed by the sevice are deleted in the \u0027ComputeNode\u0027 table."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7faddb67_d697fe8f","line":12,"updated":"2019-07-09 21:41:48.000000000","message":"This seems like an operational error. If you changed the underlying compute driver used by the nova-compute service, I\u0027d expect the service to be disabled, evacuated of any instances, stopped and then deleted (via the API) before restarting it with a new configuration. Or am I missing something?\n\nAlso, I would expect a test with this change if we consider it a valid bug.","commit_id":"46f4c160f09e8d7b632c0ae9ac6bd87bb9679b9c"}],"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f72830109e562085b8e599e3428d0ee688761cde","unresolved":false,"context_lines":[{"line_number":482,"context_line":"@pick_context_manager_reader"},{"line_number":483,"context_line":"def service_get_all_computes_by_hv_type(context, hv_type,"},{"line_number":484,"context_line":"                                        include_disabled\u003dFalse):"},{"line_number":485,"context_line":"    query \u003d model_query(context, models.Service, read_deleted\u003d\"no\").\\"},{"line_number":486,"context_line":"                    filter_by(binary\u003d\u0027nova-compute\u0027)"},{"line_number":487,"context_line":"    if not include_disabled:"},{"line_number":488,"context_line":"        query \u003d query.filter_by(disabled\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_c103120f","line":485,"range":{"start_line":485,"start_character":49,"end_line":485,"end_character":66},"updated":"2019-03-05 21:09:24.000000000","message":"You are explicitly changing this, so rather than add a new filter, why not just remove this? Note that by model_query will use context.read_deleted which defaults to \u0027no\u0027 so if you really need to read deleted services somewhere, you\u0027d have to mutate the context to read deleted services.","commit_id":"cb4b6eb239a21520841cf035b93ce095472278fe"},{"author":{"_account_id":28354,"name":"lynn","email":"yuanliu_yewu@cmss.chinamobile.com","username":"yuanliu"},"change_message_id":"891050a160456b9881891129a585ed580baa3dd3","unresolved":false,"context_lines":[{"line_number":482,"context_line":"@pick_context_manager_reader"},{"line_number":483,"context_line":"def service_get_all_computes_by_hv_type(context, hv_type,"},{"line_number":484,"context_line":"                                        include_disabled\u003dFalse):"},{"line_number":485,"context_line":"    query \u003d model_query(context, models.Service, read_deleted\u003d\"no\").\\"},{"line_number":486,"context_line":"                    filter_by(binary\u003d\u0027nova-compute\u0027)"},{"line_number":487,"context_line":"    if not include_disabled:"},{"line_number":488,"context_line":"        query \u003d query.filter_by(disabled\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_b33c3ce1","line":485,"range":{"start_line":485,"start_character":49,"end_line":485,"end_character":66},"in_reply_to":"5fc1f717_c103120f","updated":"2019-04-29 01:06:56.000000000","message":"I have fix it with a new patch","commit_id":"cb4b6eb239a21520841cf035b93ce095472278fe"},{"author":{"_account_id":28354,"name":"lynn","email":"yuanliu_yewu@cmss.chinamobile.com","username":"yuanliu"},"change_message_id":"1a8f944673377a6b7438609bb1df199a3703ffba","unresolved":false,"context_lines":[{"line_number":482,"context_line":"@pick_context_manager_reader"},{"line_number":483,"context_line":"def service_get_all_computes_by_hv_type(context, hv_type,"},{"line_number":484,"context_line":"                                        include_disabled\u003dFalse):"},{"line_number":485,"context_line":"    query \u003d model_query(context, models.Service, read_deleted\u003d\"no\").\\"},{"line_number":486,"context_line":"                    filter_by(binary\u003d\u0027nova-compute\u0027)"},{"line_number":487,"context_line":"    if not include_disabled:"},{"line_number":488,"context_line":"        query \u003d query.filter_by(disabled\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_058ae8bd","line":485,"range":{"start_line":485,"start_character":49,"end_line":485,"end_character":66},"in_reply_to":"5fc1f717_c103120f","updated":"2019-07-10 08:36:21.000000000","message":"I think this method aims to get services that are not deleted. When the service hv_type has been changed and the service name is same, the service is not deleted in modes.Service table. We still  can get service by old hv_type, If not add a new filter.","commit_id":"cb4b6eb239a21520841cf035b93ce095472278fe"}]}