)]}'
{"nova/virt/ironic/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cb7d8f1e32696193b64dafe7240a7ae621cf88ca","unresolved":false,"context_lines":[{"line_number":511,"context_line":"        self._refresh_hash_ring(nova_context.get_admin_context())"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"    @staticmethod"},{"line_number":514,"context_line":"    def _pike_flavor_migration_for_node(ctx, node_rc, instance_uuid):"},{"line_number":515,"context_line":"        normalized_rc \u003d utils.normalize_rc_name(node_rc)"},{"line_number":516,"context_line":"        instance \u003d objects.Instance.get_by_uuid(ctx, instance_uuid,"},{"line_number":517,"context_line":"                                                expected_attrs\u003d[\"flavor\"])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_f3906d50","line":514,"range":{"start_line":514,"start_character":8,"end_line":514,"end_character":39},"updated":"2019-02-18 14:26:32.000000000","message":"Note for stable branches, this will have to take into account the value of CONF.workarounds.report_ironic_standard_resource_class_inventory because if we still report standard resource class inventory then we likely should still report the standard resource class allocations from the flavor - but I haven\u0027t thought too hard about it.","commit_id":"ca9335c6bea33acd7f585cb2be4c4ae303d1f41e"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1a1f7efa96ea213ff0b11aa439b437f4db50a564","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        # Are both the custom and standard resource class handled?"},{"line_number":524,"context_line":"        if custom_rc_resource_key in specs and vcpu_resource_key in specs:"},{"line_number":525,"context_line":"            # The compute must have been restarted, and the instance.flavor"},{"line_number":526,"context_line":"            # has already been migrated"},{"line_number":527,"context_line":"            return False"},{"line_number":528,"context_line":"        # Has the custom resource class been handled?"},{"line_number":529,"context_line":"        if custom_rc_resource_key not in specs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_8243e86b","line":526,"updated":"2019-02-15 21:12:02.000000000","message":"Does that mean they were already zeroed? Is it possible they\u0027re in extra_specs, but nonzero? (Would that just be a user error?)","commit_id":"ca9335c6bea33acd7f585cb2be4c4ae303d1f41e"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b672bed50ac36e00e04a1dfab4de19a5c70bff9f","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        # Are both the custom and standard resource class handled?"},{"line_number":524,"context_line":"        if custom_rc_resource_key in specs and vcpu_resource_key in specs:"},{"line_number":525,"context_line":"            # The compute must have been restarted, and the instance.flavor"},{"line_number":526,"context_line":"            # has already been migrated"},{"line_number":527,"context_line":"            return False"},{"line_number":528,"context_line":"        # Has the custom resource class been handled?"},{"line_number":529,"context_line":"        if custom_rc_resource_key not in specs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_b313c500","line":526,"in_reply_to":"9fdfeff1_8243e86b","updated":"2019-02-18 14:21:13.000000000","message":"I think I agree here. I would expect a non-zero value for vcpus to already be here for an older instance, right? Feels like we should check if it\u0027s 0.","commit_id":"ca9335c6bea33acd7f585cb2be4c4ae303d1f41e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cb7d8f1e32696193b64dafe7240a7ae621cf88ca","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        # Are both the custom and standard resource class handled?"},{"line_number":524,"context_line":"        if custom_rc_resource_key in specs and vcpu_resource_key in specs:"},{"line_number":525,"context_line":"            # The compute must have been restarted, and the instance.flavor"},{"line_number":526,"context_line":"            # has already been migrated"},{"line_number":527,"context_line":"            return False"},{"line_number":528,"context_line":"        # Has the custom resource class been handled?"},{"line_number":529,"context_line":"        if custom_rc_resource_key not in specs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_d3e76911","line":526,"in_reply_to":"9fdfeff1_8243e86b","updated":"2019-02-18 14:26:32.000000000","message":"This code runs on compute startup in a separate thread and builds a cache of which instances have been processed and migrated already. So either an instance hasn\u0027t been migrated and we catch it and migrate it here, or the instance was created from a flavor that was already properly setup per the ironic flavor docs:\n\nhttps://docs.openstack.org/ironic/latest/install/configure-nova-flavors.html","commit_id":"ca9335c6bea33acd7f585cb2be4c4ae303d1f41e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cb7d8f1e32696193b64dafe7240a7ae621cf88ca","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        # Are both the custom and standard resource class handled?"},{"line_number":524,"context_line":"        if custom_rc_resource_key in specs and vcpu_resource_key in specs:"},{"line_number":525,"context_line":"            # The compute must have been restarted, and the instance.flavor"},{"line_number":526,"context_line":"            # has already been migrated"},{"line_number":527,"context_line":"            return False"},{"line_number":528,"context_line":"        # Has the custom resource class been handled?"},{"line_number":529,"context_line":"        if custom_rc_resource_key not in specs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_b3966548","line":526,"in_reply_to":"9fdfeff1_b313c500","updated":"2019-02-18 14:26:32.000000000","message":"What do you mean? The bug is that we migrated older instances and set the custom resource class value in extra specs but did not zero out their standard resource classes in extra specs, which once you set report_ironic_standard_resource_class_inventory\u003dFalse on stable branches makes the bug appear because we\u0027re no longer reporting standard resource class inventory but we\u0027ll be trying to report standard resource class allocations. This is for instances created with flavors before their standard resource classes were zeroed out.\n\n(later)\n\nOh I get your guys\u0027 question now - if we\u0027ve already migrated this instance and zeroed out the standard resource class. We don\u0027t want to hit that one again if we\u0027ve already zeroed it. I\u0027ll add a test.","commit_id":"ca9335c6bea33acd7f585cb2be4c4ae303d1f41e"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"0398ad2e1a7135030bec0cf23b18c6abc3ffd076","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        # Are both the custom and standard resource class handled?"},{"line_number":524,"context_line":"        if custom_rc_resource_key in specs and vcpu_resource_key in specs:"},{"line_number":525,"context_line":"            # The compute must have been restarted, and the instance.flavor"},{"line_number":526,"context_line":"            # has already been migrated"},{"line_number":527,"context_line":"            return False"},{"line_number":528,"context_line":"        # Has the custom resource class been handled?"},{"line_number":529,"context_line":"        if custom_rc_resource_key not in specs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_5315b99a","line":526,"in_reply_to":"9fdfeff1_b3966548","updated":"2019-02-18 14:37:27.000000000","message":"Oh right, this is extra_specs, so it shouldn\u0027t be set. Sorry, I was thinking of \"regular\" specs. My bad. But, per Eric\u0027s last comment, we probably want to check anyway, right?\n \n \u003e Oh I get your guys\u0027 question now - if we\u0027ve already migrated this\n \u003e instance and zeroed out the standard resource class. We don\u0027t want\n \u003e to hit that one again if we\u0027ve already zeroed it. I\u0027ll add a test.\n\n+1, good point.","commit_id":"ca9335c6bea33acd7f585cb2be4c4ae303d1f41e"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0e00cbfc60bb355558c4e9e9aa50cbf4b36b0526","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        # Are both the custom and standard resource class handled?"},{"line_number":524,"context_line":"        if custom_rc_resource_key in specs and vcpu_resource_key in specs:"},{"line_number":525,"context_line":"            # The compute must have been restarted, and the instance.flavor"},{"line_number":526,"context_line":"            # has already been migrated"},{"line_number":527,"context_line":"            return False"},{"line_number":528,"context_line":"        # Has the custom resource class been handled?"},{"line_number":529,"context_line":"        if custom_rc_resource_key not in specs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_f3cced61","line":526,"in_reply_to":"9fdfeff1_d3e76911","updated":"2019-02-18 14:31:28.000000000","message":"What I was talking about is if they\u0027re in extra_specs but nonzero. Presumably because some operator set up their flavor that way for some reason? Perhaps that\u0027s their fault, but does the world explode as a result?","commit_id":"ca9335c6bea33acd7f585cb2be4c4ae303d1f41e"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"c7196fe1817158b5d9643a1d6bf4b2f34e3f6646","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        # Are both the custom and standard resource class handled?"},{"line_number":524,"context_line":"        if custom_rc_resource_key in specs and vcpu_resource_key in specs:"},{"line_number":525,"context_line":"            # The compute must have been restarted, and the instance.flavor"},{"line_number":526,"context_line":"            # has already been migrated"},{"line_number":527,"context_line":"            return False"},{"line_number":528,"context_line":"        # Has the custom resource class been handled?"},{"line_number":529,"context_line":"        if custom_rc_resource_key not in specs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_b1394ad9","line":526,"in_reply_to":"9fdfeff1_f3cced61","updated":"2019-02-20 15:21:25.000000000","message":"\u003e What I was talking about is if they\u0027re in extra_specs but nonzero.\n \u003e Presumably because some operator set up their flavor that way for\n \u003e some reason? Perhaps that\u0027s their fault, but does the world explode\n \u003e as a result?\n\nIMHO, we shouldn\u0027t care if the user/operator sets a non-zero value through their flavor extra_specs. I mean its their fault like you said. I think we should only consider those ones that didn\u0027t migrate as far as this bug goes. Sure the world would explode for them but they did explicitly put the non-zero values after all.","commit_id":"ca9335c6bea33acd7f585cb2be4c4ae303d1f41e"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b672bed50ac36e00e04a1dfab4de19a5c70bff9f","unresolved":false,"context_lines":[{"line_number":529,"context_line":"        if custom_rc_resource_key not in specs:"},{"line_number":530,"context_line":"            specs[custom_rc_resource_key] \u003d \"1\""},{"line_number":531,"context_line":"        # Have the standard resource classes been handled?"},{"line_number":532,"context_line":"        if vcpu_resource_key not in specs:"},{"line_number":533,"context_line":"            # We override the standard resource classes so that we can still"},{"line_number":534,"context_line":"            # display the embedded instance.flavor attributes to the user like"},{"line_number":535,"context_line":"            # vcpus, ram and disk, but override the actual allocated value to"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_33dd9540","line":532,"updated":"2019-02-18 14:21:13.000000000","message":"Ditto, need to check if we\u0027re zeroed here, not that the key doesn\u0027t exist.","commit_id":"ca9335c6bea33acd7f585cb2be4c4ae303d1f41e"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"c7196fe1817158b5d9643a1d6bf4b2f34e3f6646","unresolved":false,"context_lines":[{"line_number":529,"context_line":"        if custom_rc_resource_key not in specs:"},{"line_number":530,"context_line":"            specs[custom_rc_resource_key] \u003d \"1\""},{"line_number":531,"context_line":"        # Have the standard resource classes been handled?"},{"line_number":532,"context_line":"        if vcpu_resource_key not in specs:"},{"line_number":533,"context_line":"            # We override the standard resource classes so that we can still"},{"line_number":534,"context_line":"            # display the embedded instance.flavor attributes to the user like"},{"line_number":535,"context_line":"            # vcpus, ram and disk, but override the actual allocated value to"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_5187be62","line":532,"in_reply_to":"9fdfeff1_33dd9540","updated":"2019-02-20 15:21:25.000000000","message":"I am not sure why we need to check for the non-zero values.. am I missing something ?","commit_id":"ca9335c6bea33acd7f585cb2be4c4ae303d1f41e"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6c12b21fce141834d7510fb221dc34fe656d3296","unresolved":false,"context_lines":[{"line_number":529,"context_line":"        if custom_rc_resource_key not in specs:"},{"line_number":530,"context_line":"            specs[custom_rc_resource_key] \u003d \"1\""},{"line_number":531,"context_line":"        # Have the standard resource classes been handled?"},{"line_number":532,"context_line":"        if vcpu_resource_key not in specs:"},{"line_number":533,"context_line":"            # We override the standard resource classes so that we can still"},{"line_number":534,"context_line":"            # display the embedded instance.flavor attributes to the user like"},{"line_number":535,"context_line":"            # vcpus, ram and disk, but override the actual allocated value to"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_b7c93a5b","line":532,"in_reply_to":"9fdfeff1_4c8de52f","updated":"2019-02-20 16:54:13.000000000","message":"My thought was along the lines of... if we know we\u0027re in a situation where things will explode, and we can fix it, why not?\n\nI\u0027m fine with a warning if we want to let it blow up, I just don\u0027t see why we wouldn\u0027t want to help the operator.","commit_id":"ca9335c6bea33acd7f585cb2be4c4ae303d1f41e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b67e3c78e9ed9d3851b7a137d85d260506a94748","unresolved":false,"context_lines":[{"line_number":529,"context_line":"        if custom_rc_resource_key not in specs:"},{"line_number":530,"context_line":"            specs[custom_rc_resource_key] \u003d \"1\""},{"line_number":531,"context_line":"        # Have the standard resource classes been handled?"},{"line_number":532,"context_line":"        if vcpu_resource_key not in specs:"},{"line_number":533,"context_line":"            # We override the standard resource classes so that we can still"},{"line_number":534,"context_line":"            # display the embedded instance.flavor attributes to the user like"},{"line_number":535,"context_line":"            # vcpus, ram and disk, but override the actual allocated value to"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_4c8de52f","line":532,"in_reply_to":"9fdfeff1_5187be62","updated":"2019-02-20 16:09:06.000000000","message":"I don\u0027t think we would - we want to check if the standard resource class key exists in extra specs and if it\u0027s already 0, we consider that instance migrated; if it\u0027s non-zero, then I guess we log a warning and still consider it migrated.","commit_id":"ca9335c6bea33acd7f585cb2be4c4ae303d1f41e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ddf21ba553a70eec81ff299a6bc5957eb15e140f","unresolved":false,"context_lines":[{"line_number":529,"context_line":"        if custom_rc_resource_key not in specs:"},{"line_number":530,"context_line":"            specs[custom_rc_resource_key] \u003d \"1\""},{"line_number":531,"context_line":"        # Have the standard resource classes been handled?"},{"line_number":532,"context_line":"        if vcpu_resource_key not in specs:"},{"line_number":533,"context_line":"            # We override the standard resource classes so that we can still"},{"line_number":534,"context_line":"            # display the embedded instance.flavor attributes to the user like"},{"line_number":535,"context_line":"            # vcpus, ram and disk, but override the actual allocated value to"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_5fda1be9","line":532,"in_reply_to":"9fdfeff1_b7c93a5b","updated":"2019-02-25 10:13:14.000000000","message":"I definitely like helping operators, but this code is temporary, right? Any help provided won\u0027t be around for long, so perhaps we shouldn\u0027t dwell on it.","commit_id":"ca9335c6bea33acd7f585cb2be4c4ae303d1f41e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8dc1b092d9c5688e9922a454f4e60083b6dcd3d8","unresolved":false,"context_lines":[{"line_number":533,"context_line":"            # We override the standard resource classes so that we can still"},{"line_number":534,"context_line":"            # display the embedded instance.flavor attributes to the user like"},{"line_number":535,"context_line":"            # vcpus, ram and disk, but override the actual allocated value to"},{"line_number":536,"context_line":"            # 0 which is what the ResourceTracker will report to placement."},{"line_number":537,"context_line":"            specs[vcpu_resource_key] \u003d \"0\""},{"line_number":538,"context_line":"            specs[\"resources:%s\" % orc.MEMORY_MB] \u003d \"0\""},{"line_number":539,"context_line":"            specs[\"resources:%s\" % orc.DISK_GB] \u003d \"0\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_9747ad1d","line":536,"range":{"start_line":536,"start_character":22,"end_line":536,"end_character":75},"updated":"2019-02-15 16:16:42.000000000","message":"This should probably be, \"causes these resource classes to be filtered out from what is reported to placement\".","commit_id":"ca9335c6bea33acd7f585cb2be4c4ae303d1f41e"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b672bed50ac36e00e04a1dfab4de19a5c70bff9f","unresolved":false,"context_lines":[{"line_number":549,"context_line":"        extra_specs, the periodic call to update_available_resources() will add"},{"line_number":550,"context_line":"        an allocation against the custom resource class, and prevent placement"},{"line_number":551,"context_line":"        from thinking that that node is available. This code can be removed in"},{"line_number":552,"context_line":"        Queens."},{"line_number":553,"context_line":"        \"\"\""},{"line_number":554,"context_line":"        ctx \u003d nova_context.get_admin_context()"},{"line_number":555,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_330fd5e0","line":552,"updated":"2019-02-18 14:21:13.000000000","message":"We now shouldn\u0027t remove this code until Train, right?","commit_id":"ca9335c6bea33acd7f585cb2be4c4ae303d1f41e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"892c61855eda3ad5a35426c9b75031f6dc7c10bf","unresolved":false,"context_lines":[{"line_number":549,"context_line":"        extra_specs, the periodic call to update_available_resources() will add"},{"line_number":550,"context_line":"        an allocation against the custom resource class, and prevent placement"},{"line_number":551,"context_line":"        from thinking that that node is available. This code can be removed in"},{"line_number":552,"context_line":"        Queens."},{"line_number":553,"context_line":"        \"\"\""},{"line_number":554,"context_line":"        ctx \u003d nova_context.get_admin_context()"},{"line_number":555,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_f3c70d44","line":552,"in_reply_to":"9fdfeff1_330fd5e0","updated":"2019-02-18 14:29:44.000000000","message":"At the earliest I guess yeah. We do have a nova-status upgrade check for the custom resource class migration:\n\nhttps://github.com/openstack/nova/blob/e3c24da89aa3e6462f1b07e00659c87f252ba4ba/nova/cmd/status.py#L200\n\nWe shouldn\u0027t really drop this code until we\u0027re ready to drop that as well, and this might mean that check should also be updated to account for zeroed out standard resource classes.","commit_id":"ca9335c6bea33acd7f585cb2be4c4ae303d1f41e"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"0398ad2e1a7135030bec0cf23b18c6abc3ffd076","unresolved":false,"context_lines":[{"line_number":549,"context_line":"        extra_specs, the periodic call to update_available_resources() will add"},{"line_number":550,"context_line":"        an allocation against the custom resource class, and prevent placement"},{"line_number":551,"context_line":"        from thinking that that node is available. This code can be removed in"},{"line_number":552,"context_line":"        Queens."},{"line_number":553,"context_line":"        \"\"\""},{"line_number":554,"context_line":"        ctx \u003d nova_context.get_admin_context()"},{"line_number":555,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_931ec1b8","line":552,"in_reply_to":"9fdfeff1_f3c70d44","updated":"2019-02-18 14:37:27.000000000","message":"Okay, let\u0027s update this docstring then.","commit_id":"ca9335c6bea33acd7f585cb2be4c4ae303d1f41e"}],"releasenotes/notes/bug-1816034-ironic-partial-flavor-migration-daa7ce20f9a934c8.yaml":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1a1f7efa96ea213ff0b11aa439b437f4db50a564","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Ironic instances have had their embedded flavor data migrated since the"},{"line_number":5,"context_line":"    16.0.0 Pike in order to report custom resource class allocations to the"},{"line_number":6,"context_line":"    Placement service. However, that data migration did not zero out the"},{"line_number":7,"context_line":"    standard resource classes (``VCPU``, ``MEMORY_MB``, ``DISK_GB``) on the"},{"line_number":8,"context_line":"    embedded flavor which meant trying to report allocations for those classes"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fdfeff1_4278a0c2","line":5,"updated":"2019-02-15 21:12:02.000000000","message":"release","commit_id":"ca9335c6bea33acd7f585cb2be4c4ae303d1f41e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cb7d8f1e32696193b64dafe7240a7ae621cf88ca","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Ironic instances have had their embedded flavor data migrated since the"},{"line_number":5,"context_line":"    16.0.0 Pike in order to report custom resource class allocations to the"},{"line_number":6,"context_line":"    Placement service. However, that data migration did not zero out the"},{"line_number":7,"context_line":"    standard resource classes (``VCPU``, ``MEMORY_MB``, ``DISK_GB``) on the"},{"line_number":8,"context_line":"    embedded flavor which meant trying to report allocations for those classes"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fdfeff1_f3cb8d6e","line":5,"in_reply_to":"9fdfeff1_4278a0c2","updated":"2019-02-18 14:26:32.000000000","message":"Yup - I even remember putting \"the\" ahead of this for calling out \u0027release\u0027 but must have forgot.","commit_id":"ca9335c6bea33acd7f585cb2be4c4ae303d1f41e"}]}