)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f2fbc0fc9c8271f5e2af654eb2eb59d33192cebd","unresolved":false,"context_lines":[{"line_number":4953,"context_line":"        if virt_type \u003d\u003d \u0027parallels\u0027:"},{"line_number":4954,"context_line":"            pass"},{"line_number":4955,"context_line":"        elif virt_type not in (\"qemu\", \"kvm\"):"},{"line_number":4956,"context_line":"            log_path \u003d self._get_console_log_path(instance)"},{"line_number":4957,"context_line":"            self._create_pty_device(guest_cfg,"},{"line_number":4958,"context_line":"                                    vconfig.LibvirtConfigGuestConsole,"},{"line_number":4959,"context_line":"                                    log_path\u003dlog_path)"},{"line_number":4960,"context_line":"        elif (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4961,"context_line":"                  self._is_s390x_guest(image_meta)):"},{"line_number":4962,"context_line":"            self._create_consoles_s390x(guest_cfg, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_2d175a48","line":4959,"range":{"start_line":4956,"start_character":0,"end_line":4959,"end_character":54},"updated":"2019-02-19 15:08:04.000000000","message":"As an aside, dragging this out to a \u0027_create_consoles_non_qumu_kvm\u0027 function might not be a bad idea for a future change","commit_id":"c0fd216780cfa9c17da385af63fa743d40434fa0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"13ead60833e78435193ffdaa8f8673f3f4f053af","unresolved":false,"context_lines":[{"line_number":4954,"context_line":"            pass"},{"line_number":4955,"context_line":"        elif virt_type not in (\"qemu\", \"kvm\"):"},{"line_number":4956,"context_line":"            log_path \u003d self._get_console_log_path(instance)"},{"line_number":4957,"context_line":"            self._create_pty_device(guest_cfg,"},{"line_number":4958,"context_line":"                                    vconfig.LibvirtConfigGuestConsole,"},{"line_number":4959,"context_line":"                                    log_path\u003dlog_path)"},{"line_number":4960,"context_line":"        elif (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4961,"context_line":"                  self._is_s390x_guest(image_meta)):"},{"line_number":4962,"context_line":"            self._create_consoles_s390x(guest_cfg, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_8a72f1ac","line":4959,"range":{"start_line":4957,"start_character":0,"end_line":4959,"end_character":54},"updated":"2019-02-19 10:18:59.000000000","message":"Looks like we\u0027re dropping the check for \u0027CONF.serial_console.enabled\u0027 from this code path? I\u0027m guessing we shouldn\u0027t do that","commit_id":"c0fd216780cfa9c17da385af63fa743d40434fa0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6c9b49c4cb0c813e90e22792d8c33c4f07a12286","unresolved":false,"context_lines":[{"line_number":4954,"context_line":"            pass"},{"line_number":4955,"context_line":"        elif virt_type not in (\"qemu\", \"kvm\"):"},{"line_number":4956,"context_line":"            log_path \u003d self._get_console_log_path(instance)"},{"line_number":4957,"context_line":"            self._create_pty_device(guest_cfg,"},{"line_number":4958,"context_line":"                                    vconfig.LibvirtConfigGuestConsole,"},{"line_number":4959,"context_line":"                                    log_path\u003dlog_path)"},{"line_number":4960,"context_line":"        elif (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4961,"context_line":"                  self._is_s390x_guest(image_meta)):"},{"line_number":4962,"context_line":"            self._create_consoles_s390x(guest_cfg, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_2a542021","line":4959,"range":{"start_line":4957,"start_character":0,"end_line":4959,"end_character":54},"in_reply_to":"9fdfeff1_16f7088f","updated":"2019-02-19 15:02:34.000000000","message":"Good point. I guess a bug against this would be very helpful. I also suspect a UT might be needed after all","commit_id":"c0fd216780cfa9c17da385af63fa743d40434fa0"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"20d54f3c83e2aa3f359a8c9c843ede7027493373","unresolved":false,"context_lines":[{"line_number":4954,"context_line":"            pass"},{"line_number":4955,"context_line":"        elif virt_type not in (\"qemu\", \"kvm\"):"},{"line_number":4956,"context_line":"            log_path \u003d self._get_console_log_path(instance)"},{"line_number":4957,"context_line":"            self._create_pty_device(guest_cfg,"},{"line_number":4958,"context_line":"                                    vconfig.LibvirtConfigGuestConsole,"},{"line_number":4959,"context_line":"                                    log_path\u003dlog_path)"},{"line_number":4960,"context_line":"        elif (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4961,"context_line":"                  self._is_s390x_guest(image_meta)):"},{"line_number":4962,"context_line":"            self._create_consoles_s390x(guest_cfg, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_be803c48","line":4959,"range":{"start_line":4957,"start_character":0,"end_line":4959,"end_character":54},"in_reply_to":"9fdfeff1_16f7088f","updated":"2019-02-20 10:03:05.000000000","message":"Yeah, this is the simplified new table, which still captures the fact that non-QEMU/KVM hypervisors (except Parallels) provide a PTY device by default):\n\n        # case | is serial | is qemu | resulting\n        #      | enabled?  | or kvm? | devices\n        # -------------------------------------------\n        #    1 |        no |     no  | pty*\n        #    2 |        no |     yes | pty with logd\n        #    3 |       yes |      no | see case 1\n        #    4 |       yes |     yes | tcp with logd\n        #\n        #    * exception: `virt_type\u003dparallels` doesn\u0027t create a device","commit_id":"c0fd216780cfa9c17da385af63fa743d40434fa0"},{"author":{"_account_id":28454,"name":"Georg Hoesch","email":"georg_hoesch@genua.de","username":"georghoesch"},"change_message_id":"de155aef33f5099aeb7b8bf9db5489428d710562","unresolved":false,"context_lines":[{"line_number":4954,"context_line":"            pass"},{"line_number":4955,"context_line":"        elif virt_type not in (\"qemu\", \"kvm\"):"},{"line_number":4956,"context_line":"            log_path \u003d self._get_console_log_path(instance)"},{"line_number":4957,"context_line":"            self._create_pty_device(guest_cfg,"},{"line_number":4958,"context_line":"                                    vconfig.LibvirtConfigGuestConsole,"},{"line_number":4959,"context_line":"                                    log_path\u003dlog_path)"},{"line_number":4960,"context_line":"        elif (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4961,"context_line":"                  self._is_s390x_guest(image_meta)):"},{"line_number":4962,"context_line":"            self._create_consoles_s390x(guest_cfg, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_fef2446f","line":4959,"range":{"start_line":4957,"start_character":0,"end_line":4959,"end_character":54},"in_reply_to":"9fdfeff1_2a542021","updated":"2019-02-20 10:31:55.000000000","message":"Kayhyap: I don\u0027t know if we need a bug here, Stephen proposed it. We only deducted that the old behavior might be a bug and it will be \"fixed\" here by changing the behavior to what seemed to be the original intention.\n\nPlus: the fixed bug is just a side effect here, not the purpose of the change.","commit_id":"c0fd216780cfa9c17da385af63fa743d40434fa0"},{"author":{"_account_id":28454,"name":"Georg Hoesch","email":"georg_hoesch@genua.de","username":"georghoesch"},"change_message_id":"4fb328525f52668fa089fb74be9da997a9922b49","unresolved":false,"context_lines":[{"line_number":4954,"context_line":"            pass"},{"line_number":4955,"context_line":"        elif virt_type not in (\"qemu\", \"kvm\"):"},{"line_number":4956,"context_line":"            log_path \u003d self._get_console_log_path(instance)"},{"line_number":4957,"context_line":"            self._create_pty_device(guest_cfg,"},{"line_number":4958,"context_line":"                                    vconfig.LibvirtConfigGuestConsole,"},{"line_number":4959,"context_line":"                                    log_path\u003dlog_path)"},{"line_number":4960,"context_line":"        elif (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4961,"context_line":"                  self._is_s390x_guest(image_meta)):"},{"line_number":4962,"context_line":"            self._create_consoles_s390x(guest_cfg, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_16f7088f","line":4959,"range":{"start_line":4957,"start_character":0,"end_line":4959,"end_character":54},"in_reply_to":"9fdfeff1_8a72f1ac","updated":"2019-02-19 14:07:28.000000000","message":"good question.\n\nAccording to the code: yes.\nOld code didn\u0027t create a serial device for this case.\n\nAccording to the deleted table, non-kvm hypervisors\nshould always have a pty device. As such I assume that\nthe old code is broken and the new code is ok.","commit_id":"c0fd216780cfa9c17da385af63fa743d40434fa0"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"1a9996af48d7371e4c108063e1e4f8a21f6160a1","unresolved":false,"context_lines":[{"line_number":4954,"context_line":"            pass"},{"line_number":4955,"context_line":"        elif virt_type not in (\"qemu\", \"kvm\"):"},{"line_number":4956,"context_line":"            log_path \u003d self._get_console_log_path(instance)"},{"line_number":4957,"context_line":"            self._create_pty_device(guest_cfg,"},{"line_number":4958,"context_line":"                                    vconfig.LibvirtConfigGuestConsole,"},{"line_number":4959,"context_line":"                                    log_path\u003dlog_path)"},{"line_number":4960,"context_line":"        elif (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4961,"context_line":"                  self._is_s390x_guest(image_meta)):"},{"line_number":4962,"context_line":"            self._create_consoles_s390x(guest_cfg, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_031a0316","line":4959,"range":{"start_line":4957,"start_character":0,"end_line":4959,"end_character":54},"in_reply_to":"9fdfeff1_fef2446f","updated":"2019-02-25 08:46:28.000000000","message":"Yep, noted.  The refactoring suggested will be done in a separate change, so that we stick to the \"one logical change per commit\" rule in this patch. :-)","commit_id":"c0fd216780cfa9c17da385af63fa743d40434fa0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f2fbc0fc9c8271f5e2af654eb2eb59d33192cebd","unresolved":false,"context_lines":[{"line_number":4958,"context_line":"                                    vconfig.LibvirtConfigGuestConsole,"},{"line_number":4959,"context_line":"                                    log_path\u003dlog_path)"},{"line_number":4960,"context_line":"        elif (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4961,"context_line":"                  self._is_s390x_guest(image_meta)):"},{"line_number":4962,"context_line":"            self._create_consoles_s390x(guest_cfg, instance,"},{"line_number":4963,"context_line":"                                        flavor, image_meta)"},{"line_number":4964,"context_line":"        elif virt_type in (\"qemu\", \"kvm\"):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_0a059c14","line":4961,"range":{"start_line":4961,"start_character":18,"end_line":4961,"end_character":52},"updated":"2019-02-19 15:08:04.000000000","message":"As an aside, and assuming you\u0027d doing further untangling of this nest, bringing this down a level (in a future patch) would make this easier to read:\n\n  if virt_type \u003d\u003d \u0027parallels\u0027:\n      pass\n  elif virt_type not in (\"qemu\", \"kvm\"):\n      self._create_consoles_non_qemu_kvm(...)\n  else:\n      if self._is_s390x_guest(image_meta):\n          self._create_consoles_s390x(guest_cfg, instance,\n                                      flavor, image_meta)\n      else:\n          self._create_consoles_qemu_kvm(guest_cfg, instance,\n                                         flavor, image_meta)\n\nBut maybe that\u0027s just me","commit_id":"c0fd216780cfa9c17da385af63fa743d40434fa0"},{"author":{"_account_id":28454,"name":"Georg Hoesch","email":"georg_hoesch@genua.de","username":"georghoesch"},"change_message_id":"5f7cb0f101b1b396628471c99e0ca691943b6e6e","unresolved":false,"context_lines":[{"line_number":4958,"context_line":"                                    vconfig.LibvirtConfigGuestConsole,"},{"line_number":4959,"context_line":"                                    log_path\u003dlog_path)"},{"line_number":4960,"context_line":"        elif (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4961,"context_line":"                  self._is_s390x_guest(image_meta)):"},{"line_number":4962,"context_line":"            self._create_consoles_s390x(guest_cfg, instance,"},{"line_number":4963,"context_line":"                                        flavor, image_meta)"},{"line_number":4964,"context_line":"        elif virt_type in (\"qemu\", \"kvm\"):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_237bebbe","line":4961,"range":{"start_line":4961,"start_character":18,"end_line":4961,"end_character":52},"in_reply_to":"9fdfeff1_0a059c14","updated":"2019-02-19 16:14:17.000000000","message":"I\u0027d go the reverse way and move all functionality here.\n_create_consoles_qemu_kvm() and _create_consoles_s390x are very similar and the same goes for the non-kvm snippet.\n\nI\u0027d rather have one case for tcp-based consoles and\none for pty-based consoles, with a minor special case\nfor sclp in s390x ptys.\n\nBut thats only a suggestion and not in the scope of this change.","commit_id":"c0fd216780cfa9c17da385af63fa743d40434fa0"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"a5c8a4df2763ff8a8af6c7bb02fb7efa24f9b44e","unresolved":false,"context_lines":[{"line_number":4958,"context_line":"                                    vconfig.LibvirtConfigGuestConsole,"},{"line_number":4959,"context_line":"                                    log_path\u003dlog_path)"},{"line_number":4960,"context_line":"        elif (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4961,"context_line":"                  self._is_s390x_guest(image_meta)):"},{"line_number":4962,"context_line":"            self._create_consoles_s390x(guest_cfg, instance,"},{"line_number":4963,"context_line":"                                        flavor, image_meta)"},{"line_number":4964,"context_line":"        elif virt_type in (\"qemu\", \"kvm\"):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_7ec0947d","line":4961,"range":{"start_line":4961,"start_character":18,"end_line":4961,"end_character":52},"in_reply_to":"9fdfeff1_237bebbe","updated":"2019-02-20 10:06:51.000000000","message":"Right, I\u0027ll queue this up for a future change.\n\nSo back to this patch: We are still fine to remove the \u0027CONF.serial_console.enabled\u0027 here.  I\u0027ll file a bug to note the brokenness that Georg pointed out above.","commit_id":"c0fd216780cfa9c17da385af63fa743d40434fa0"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"da3e327013b67c97db6ca51a0bba979cf622d601","unresolved":false,"context_lines":[{"line_number":4958,"context_line":"                                    vconfig.LibvirtConfigGuestConsole,"},{"line_number":4959,"context_line":"                                    log_path\u003dlog_path)"},{"line_number":4960,"context_line":"        elif (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4961,"context_line":"                  self._is_s390x_guest(image_meta)):"},{"line_number":4962,"context_line":"            self._create_consoles_s390x(guest_cfg, instance,"},{"line_number":4963,"context_line":"                                        flavor, image_meta)"},{"line_number":4964,"context_line":"        elif virt_type in (\"qemu\", \"kvm\"):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_feba44be","line":4961,"range":{"start_line":4961,"start_character":18,"end_line":4961,"end_character":52},"in_reply_to":"9fdfeff1_7ec0947d","updated":"2019-02-20 10:18:58.000000000","message":"Georg: Re-thinking, I\u0027m not sure if it\u0027s required to file a bug here, is it?  If so, what precisely do we want to capture in it?","commit_id":"c0fd216780cfa9c17da385af63fa743d40434fa0"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"135c187c5fa1e12a00b457eb156d010a014658aa","unresolved":false,"context_lines":[{"line_number":4958,"context_line":"                                    vconfig.LibvirtConfigGuestConsole,"},{"line_number":4959,"context_line":"                                    log_path\u003dlog_path)"},{"line_number":4960,"context_line":"        elif (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4961,"context_line":"                  self._is_s390x_guest(image_meta)):"},{"line_number":4962,"context_line":"            self._create_consoles_s390x(guest_cfg, instance,"},{"line_number":4963,"context_line":"                                        flavor, image_meta)"},{"line_number":4964,"context_line":"        elif virt_type in (\"qemu\", \"kvm\"):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_5ecef05b","line":4961,"range":{"start_line":4961,"start_character":18,"end_line":4961,"end_character":52},"in_reply_to":"9fdfeff1_feba44be","updated":"2019-02-20 10:21:22.000000000","message":"Darn, by \"here\", I meant the discussion on lines 4957-4959 above.","commit_id":"c0fd216780cfa9c17da385af63fa743d40434fa0"}]}