)]}'
{"nova/compute/utils.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c963bad83d6915bf7f5fcc3101186cec42b9e91e","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"def delete_image(context, instance, image_api, image_id, log_exc_info\u003dFalse):"},{"line_number":1227,"context_line":"    \"\"\"Deletes the image if it still exists."},{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"    Ignores ImageNotFound if the instance is already gone."},{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"    :param context: the nova auth request context where the context.project_id"},{"line_number":1232,"context_line":"        matches the owner of the image"}],"source_content_type":"text/x-python","patch_set":28,"id":"9fb8cfa7_c2f6ec8f","line":1229,"range":{"start_line":1229,"start_character":33,"end_line":1229,"end_character":41},"updated":"2019-06-27 15:37:43.000000000","message":"nit: image","commit_id":"d34ead31d7482d7483f41883db13afa6844c450d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2fc948cbef440a16e1476e69d3b039a267394ab5","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"def delete_image(context, instance, image_api, image_id, log_exc_info\u003dFalse):"},{"line_number":1227,"context_line":"    \"\"\"Deletes the image if it still exists."},{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"    Ignores ImageNotFound if the instance is already gone."},{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"    :param context: the nova auth request context where the context.project_id"},{"line_number":1232,"context_line":"        matches the owner of the image"}],"source_content_type":"text/x-python","patch_set":30,"id":"9fb8cfa7_adcb7b1b","line":1229,"range":{"start_line":1229,"start_character":33,"end_line":1229,"end_character":41},"updated":"2019-07-01 16:53:34.000000000","message":"gibi\u0027s nit from earlier:\n\nhttps://review.opendev.org/#/c/637605/28/nova/compute/utils.py@1229\n\nShould be \u0027image\u0027.","commit_id":"631520df2ac278e741d666a7f69d207dee75d3dd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"82b61fee18d933a46f0cc35db735bdd8a7867d57","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"def delete_image(context, instance, image_api, image_id, log_exc_info\u003dFalse):"},{"line_number":1227,"context_line":"    \"\"\"Deletes the image if it still exists."},{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"    Ignores ImageNotFound if the instance is already gone."},{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"    :param context: the nova auth request context where the context.project_id"},{"line_number":1232,"context_line":"        matches the owner of the image"}],"source_content_type":"text/x-python","patch_set":30,"id":"7faddb67_5abb85e4","line":1229,"range":{"start_line":1229,"start_character":33,"end_line":1229,"end_character":41},"in_reply_to":"9fb8cfa7_adcb7b1b","updated":"2019-08-08 19:47:54.000000000","message":"Done","commit_id":"631520df2ac278e741d666a7f69d207dee75d3dd"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a26f571b04b0a31b4753200dce3b66c12b150e0a","unresolved":false,"context_lines":[{"line_number":1269,"context_line":"        pass"},{"line_number":1270,"context_line":"    except Exception:"},{"line_number":1271,"context_line":"        LOG.exception(\"Error while trying to clean up image %s\","},{"line_number":1272,"context_line":"                      image_id, instance\u003dinstance)"},{"line_number":1273,"context_line":""},{"line_number":1274,"context_line":""},{"line_number":1275,"context_line":"def may_have_ports_or_volumes(instance):"}],"source_content_type":"text/x-python","patch_set":37,"id":"7faddb67_c695fe89","line":1272,"updated":"2019-08-28 13:46:15.000000000","message":"Would it have made sense to merge this into the actual \u0027delete\u0027 function? (\u0027nova.image.api.API.delete\u0027, I assume)","commit_id":"44130b03a685eac0404b383fb863525478288e3b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5a72eb4ade00e13f77376537497b11aee212319e","unresolved":false,"context_lines":[{"line_number":1269,"context_line":"        pass"},{"line_number":1270,"context_line":"    except Exception:"},{"line_number":1271,"context_line":"        LOG.exception(\"Error while trying to clean up image %s\","},{"line_number":1272,"context_line":"                      image_id, instance\u003dinstance)"},{"line_number":1273,"context_line":""},{"line_number":1274,"context_line":""},{"line_number":1275,"context_line":"def may_have_ports_or_volumes(instance):"}],"source_content_type":"text/x-python","patch_set":37,"id":"7faddb67_4126d8bc","line":1272,"in_reply_to":"7faddb67_065a3682","updated":"2019-08-28 14:25:21.000000000","message":"Ah, I meant make merge this but make the catching optional (a \u0027should_raise\u0027 parameter or something). It\u0027s a nit though","commit_id":"44130b03a685eac0404b383fb863525478288e3b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"67db4d78ce3d30fe0d3ebb3e08f19719294ce04d","unresolved":false,"context_lines":[{"line_number":1269,"context_line":"        pass"},{"line_number":1270,"context_line":"    except Exception:"},{"line_number":1271,"context_line":"        LOG.exception(\"Error while trying to clean up image %s\","},{"line_number":1272,"context_line":"                      image_id, instance\u003dinstance)"},{"line_number":1273,"context_line":""},{"line_number":1274,"context_line":""},{"line_number":1275,"context_line":"def may_have_ports_or_volumes(instance):"}],"source_content_type":"text/x-python","patch_set":37,"id":"7faddb67_065a3682","line":1272,"in_reply_to":"7faddb67_c695fe89","updated":"2019-08-28 14:09:15.000000000","message":"I don\u0027t think so, because another caller may want image_api.delete to re-raise to the caller, but here we\u0027re catching and logging it so the caller doesn\u0027t blow up (it\u0027s best effort but not critical). Now that you mention it, the docstring should probably mention that as well, but I\u0027d rather do that in a follow up if others agree.","commit_id":"44130b03a685eac0404b383fb863525478288e3b"}]}