)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"2699151523e6fb391eaa144e1efedfbe504a5358","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yongiman \u003cyongiman@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-23 22:43:59 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add hpet option for time drifting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6441b9d2de5897dd1863b53bd7e2578881b53c67"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F8oys%3D","line":7,"updated":"2013-12-23 22:09:38.000000000","message":"https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages","commit_id":"e63e3cf7fe701c74f18cc44964a5845b15fdc0d8"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"9c14a45586ec649fbb7ea64c36de248d45d3e51a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yongiman \u003cyongiman@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-23 22:43:59 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add hpet option for time drifting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6441b9d2de5897dd1863b53bd7e2578881b53c67"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2FYhs%3D","line":7,"in_reply_to":"AAAATn%2F8oys%3D","updated":"2014-01-14 11:35:28.000000000","message":"As Joe says, this is insufficient explanation and at least also needs a bug number. This description is also very misleading since you\u0027re not adding an hpet device, you\u0027re disabling one that might be there already.","commit_id":"e63e3cf7fe701c74f18cc44964a5845b15fdc0d8"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"8d048921228738aecb2fe33721db05d916eedab3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\u003ctimer name\u003d\u0027hpet\u0027 present\u003d\u0027no\u0027/\u003e"},{"line_number":27,"context_line":"\u003c/clock\u003e"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Implements : No hpet option added for time drifting of windows guest os"},{"line_number":30,"context_line":"Change-Id: I6441b9d2de5897dd1863b53bd7e2578881b53c67"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAUH%2F9Yqg%3D","line":29,"updated":"2014-02-07 09:36:47.000000000","message":"This is the wrong syntax - you need the word \u0027blueprint\u0027 in there, and you must use the actual blueprint name, not its string title.","commit_id":"08f3cb46159996622140051a205d58559b765d0a"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"33d41d04258ac6da9432da90a9af372bf71be5e6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\u003ctimer name\u003d\u0027hpet\u0027 present\u003d\u0027no\u0027/\u003e"},{"line_number":27,"context_line":"\u003c/clock\u003e"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Implements : No hpet option added for time drifting of windows guest os"},{"line_number":30,"context_line":"Change-Id: I6441b9d2de5897dd1863b53bd7e2578881b53c67"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAUH%2F9Xh8%3D","line":29,"in_reply_to":"AAAAUH%2F9Yqg%3D","updated":"2014-02-07 13:07:55.000000000","message":"I understand what you mean. I\u0027ll modify commit message.","commit_id":"08f3cb46159996622140051a205d58559b765d0a"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"1a621c565446d14aef1dfecb8686cbb657b3934f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"To this template,"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"\u003cclock offset\u003d\u0027localtime\u0027\u003e"},{"line_number":24,"context_line":"\u003ctimer name\u003d\u0027rtc\u0027 tickpolicy\u003d\u0027catchup\u0027 track\u003d\u0027guest\u0027/\u003e"},{"line_number":25,"context_line":"\u003ctimer name\u003d\u0027pit\u0027 tickpolicy\u003d\u0027delay\u0027/\u003e"},{"line_number":26,"context_line":"\u003ctimer name\u003d\u0027hpet\u0027 present\u003d\u0027no\u0027/\u003e"},{"line_number":27,"context_line":"\u003c/clock\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAAUH%2F9XIY%3D","line":24,"updated":"2014-02-07 13:16:11.000000000","message":"Oh I just noticed the track\u003dguest is added here too.","commit_id":"623a87d7e6131d477c3c1a965727c51cd4ba6a27"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"71e79517f30847eac61f0c283269f4493795d879","unresolved":false,"context_lines":[{"line_number":21,"context_line":"To this template,"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"\u003cclock offset\u003d\u0027localtime\u0027\u003e"},{"line_number":24,"context_line":"\u003ctimer name\u003d\u0027rtc\u0027 tickpolicy\u003d\u0027catchup\u0027 track\u003d\u0027guest\u0027/\u003e"},{"line_number":25,"context_line":"\u003ctimer name\u003d\u0027pit\u0027 tickpolicy\u003d\u0027delay\u0027/\u003e"},{"line_number":26,"context_line":"\u003ctimer name\u003d\u0027hpet\u0027 present\u003d\u0027no\u0027/\u003e"},{"line_number":27,"context_line":"\u003c/clock\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAAUH%2F9Wxk%3D","line":24,"in_reply_to":"AAAAUH%2F9XIY%3D","updated":"2014-02-07 14:17:08.000000000","message":"OK. I fix now","commit_id":"623a87d7e6131d477c3c1a965727c51cd4ba6a27"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"9c14a45586ec649fbb7ea64c36de248d45d3e51a","unresolved":false,"context_lines":[{"line_number":3094,"context_line":"            tmrtc \u003d vconfig.LibvirtConfigGuestTimer()"},{"line_number":3095,"context_line":"            tmrtc.name \u003d \"rtc\""},{"line_number":3096,"context_line":"            tmrtc.tickpolicy \u003d \"catchup\""},{"line_number":3097,"context_line":"            tmrtc.track \u003d \"guest\""},{"line_number":3098,"context_line":""},{"line_number":3099,"context_line":"            tmpit \u003d vconfig.LibvirtConfigGuestTimer()"},{"line_number":3100,"context_line":"            tmpit.name \u003d \"pit\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FYiE%3D","line":3097,"updated":"2014-01-14 11:35:28.000000000","message":"Please don\u0027t move other code at the same time as implementing new features - it obscures the changes. If you want to re-arrange code do that separately from new feature work.","commit_id":"e63e3cf7fe701c74f18cc44964a5845b15fdc0d8"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"9c14a45586ec649fbb7ea64c36de248d45d3e51a","unresolved":false,"context_lines":[{"line_number":3102,"context_line":""},{"line_number":3103,"context_line":"            tmhpet \u003d vconfig.LibvirtConfigGuestTimer()"},{"line_number":3104,"context_line":"            tmhpet.name \u003d \"hpet\""},{"line_number":3105,"context_line":"            tmhpet.present \u003d False"},{"line_number":3106,"context_line":""},{"line_number":3107,"context_line":"            clk.add_timer(tmrtc)"},{"line_number":3108,"context_line":"            clk.add_timer(tmpit)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FYiQ%3D","line":3105,"updated":"2014-01-14 11:35:28.000000000","message":"This is in fact the exact opposite of what your commit message says you are doing. This is explicitly disabling any hypervisor default HPET device, not adding one.","commit_id":"e63e3cf7fe701c74f18cc44964a5845b15fdc0d8"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"7fbc947d657df3bba7ea151a7ebe87044c3f07bf","unresolved":false,"context_lines":[{"line_number":3125,"context_line":"            tmhpet \u003d vconfig.LibvirtConfigGuestTimer()"},{"line_number":3126,"context_line":"            tmhpet.name \u003d \"hpet\""},{"line_number":3127,"context_line":"            tmhpet.present \u003d False"},{"line_number":3128,"context_line":""},{"line_number":3129,"context_line":"            clk.add_timer(tmrtc)"},{"line_number":3130,"context_line":"            clk.add_timer(tmpit)"},{"line_number":3131,"context_line":"            clk.add_timer(tmhpet)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F92es%3D","line":3128,"updated":"2014-02-03 10:11:54.000000000","message":"As I\u0027ve seen before, do not arbitrarily re-arrange the existing code here. If you want to do any re-arrangement, do that as a patch that is separate from any functional change.","commit_id":"9e201ee3684638664bc1b619bafe99c5b8f112e6"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"e041973fc17d827c7d2c0edb7d21040a4867484b","unresolved":false,"context_lines":[{"line_number":3125,"context_line":"            tmhpet \u003d vconfig.LibvirtConfigGuestTimer()"},{"line_number":3126,"context_line":"            tmhpet.name \u003d \"hpet\""},{"line_number":3127,"context_line":"            tmhpet.present \u003d False"},{"line_number":3128,"context_line":""},{"line_number":3129,"context_line":"            clk.add_timer(tmrtc)"},{"line_number":3130,"context_line":"            clk.add_timer(tmpit)"},{"line_number":3131,"context_line":"            clk.add_timer(tmhpet)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F91P0%3D","line":3128,"in_reply_to":"AAAAUH%2F92es%3D","updated":"2014-02-07 13:07:12.000000000","message":"I revert the code re-arrangement.\nI added my code the end of original sources.\nPlease review again.","commit_id":"9e201ee3684638664bc1b619bafe99c5b8f112e6"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"8d048921228738aecb2fe33721db05d916eedab3","unresolved":false,"context_lines":[{"line_number":3119,"context_line":"            tmrtc \u003d vconfig.LibvirtConfigGuestTimer()"},{"line_number":3120,"context_line":"            tmrtc.name \u003d \"rtc\""},{"line_number":3121,"context_line":"            tmrtc.tickpolicy \u003d \"catchup\""},{"line_number":3122,"context_line":"            tmrtc.track \u003d \"guest\""},{"line_number":3123,"context_line":""},{"line_number":3124,"context_line":"            tmhpet \u003d vconfig.LibvirtConfigGuestTimer()"},{"line_number":3125,"context_line":"            tmhpet.name \u003d \"hpet\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F9YqI%3D","line":3122,"updated":"2014-02-07 09:36:47.000000000","message":"What is this change doing here ?\n\nThis blueprint is about setting the hpet timer options, so shouldn\u0027t be changing anything todo with the RTC clock.  If there\u0027s a reason to change this setting, please file a bug to describe the reason why we need it, and do it as a separate change.","commit_id":"08f3cb46159996622140051a205d58559b765d0a"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"33d41d04258ac6da9432da90a9af372bf71be5e6","unresolved":false,"context_lines":[{"line_number":3119,"context_line":"            tmrtc \u003d vconfig.LibvirtConfigGuestTimer()"},{"line_number":3120,"context_line":"            tmrtc.name \u003d \"rtc\""},{"line_number":3121,"context_line":"            tmrtc.tickpolicy \u003d \"catchup\""},{"line_number":3122,"context_line":"            tmrtc.track \u003d \"guest\""},{"line_number":3123,"context_line":""},{"line_number":3124,"context_line":"            tmhpet \u003d vconfig.LibvirtConfigGuestTimer()"},{"line_number":3125,"context_line":"            tmhpet.name \u003d \"hpet\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F9Xf4%3D","line":3122,"in_reply_to":"AAAAUH%2F9YqI%3D","updated":"2014-02-07 13:07:55.000000000","message":"I agree with that this blueprint is about hpet timer option.\nI expect better performance for configuring to guest.\nSo, it is related to windows time sync performance.\nI\u0027ll remove it in this blueprint.","commit_id":"08f3cb46159996622140051a205d58559b765d0a"}]}