)]}'
{"nova/compute/api.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"852609650a8ea4295887678eba34ae7d1815ed1b","unresolved":false,"context_lines":[{"line_number":2312,"context_line":""},{"line_number":2313,"context_line":"        # If migration.cross_cell_move, we need to also cleanup the instance"},{"line_number":2314,"context_line":"        # data from the source cell database."},{"line_number":2315,"context_line":"        if migration.cross_cell_move:"},{"line_number":2316,"context_line":"            self.compute_task_api.confirm_snapshot_based_resize("},{"line_number":2317,"context_line":"                context, instance, migration, do_cast\u003dFalse)"},{"line_number":2318,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":56,"id":"3fa7e38b_1a57422a","line":2315,"updated":"2019-12-16 08:53:01.000000000","message":"Does this require a unit test? In [1] I am not find anything test for this function, or I was missed some details.\n\n[1]https://github.com/openstack/nova/blob/master/nova/tests/unit/compute/test_compute_api.py","commit_id":"6057373191a7df10b2d2afba876f3c5a15ae33e5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b064a5d6399ae2b18af42eec4b0666facb40a331","unresolved":false,"context_lines":[{"line_number":2312,"context_line":""},{"line_number":2313,"context_line":"        # If migration.cross_cell_move, we need to also cleanup the instance"},{"line_number":2314,"context_line":"        # data from the source cell database."},{"line_number":2315,"context_line":"        if migration.cross_cell_move:"},{"line_number":2316,"context_line":"            self.compute_task_api.confirm_snapshot_based_resize("},{"line_number":2317,"context_line":"                context, instance, migration, do_cast\u003dFalse)"},{"line_number":2318,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":56,"id":"3fa7e38b_df4995b8","line":2315,"in_reply_to":"3fa7e38b_1a57422a","updated":"2019-12-16 14:21:00.000000000","message":"The functional test covers this.","commit_id":"6057373191a7df10b2d2afba876f3c5a15ae33e5"}],"nova/tests/functional/test_cross_cell_migrate.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"24eb9a83407956a382f37e6a4c81f316222ee6ca","unresolved":false,"context_lines":[{"line_number":759,"context_line":"        data is cleaned from both the source and target cell."},{"line_number":760,"context_line":"        \"\"\""},{"line_number":761,"context_line":"        server \u003d self._resize_and_validate()[0]"},{"line_number":762,"context_line":"        self.delete_server_and_assert_cleanup(server)"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    def test_cold_migrate_target_host_in_other_cell(self):"},{"line_number":765,"context_line":"        \"\"\"Tests cold migrating to a target host in another cell. This is"}],"source_content_type":"text/x-python","patch_set":56,"id":"3fa7e38b_f56d979a","line":762,"updated":"2019-12-16 09:15:13.000000000","message":"Don\u0027t we need to assert that the migration is confirmed? As far as I see delete_server_and_assert_cleanup does not cover that.","commit_id":"6057373191a7df10b2d2afba876f3c5a15ae33e5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b46c59ba7a99901c134bc4a86e1fb31f6b4d0c31","unresolved":false,"context_lines":[{"line_number":759,"context_line":"        data is cleaned from both the source and target cell."},{"line_number":760,"context_line":"        \"\"\""},{"line_number":761,"context_line":"        server \u003d self._resize_and_validate()[0]"},{"line_number":762,"context_line":"        self.delete_server_and_assert_cleanup(server)"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    def test_cold_migrate_target_host_in_other_cell(self):"},{"line_number":765,"context_line":"        \"\"\"Tests cold migrating to a target host in another cell. This is"}],"source_content_type":"text/x-python","patch_set":56,"id":"3fa7e38b_656fb2c4","line":762,"in_reply_to":"3fa7e38b_5fcb651c","updated":"2019-12-16 15:16:32.000000000","message":"If it\u0027s OK I\u0027d like to tack this on with a FUP patch since most of the series is approved and I\u0027d like to keep things merging if possible and deal with stuff like this in FUPs.","commit_id":"6057373191a7df10b2d2afba876f3c5a15ae33e5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"64c52ff233fc14d3273b677446b9887bafde44d8","unresolved":false,"context_lines":[{"line_number":759,"context_line":"        data is cleaned from both the source and target cell."},{"line_number":760,"context_line":"        \"\"\""},{"line_number":761,"context_line":"        server \u003d self._resize_and_validate()[0]"},{"line_number":762,"context_line":"        self.delete_server_and_assert_cleanup(server)"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    def test_cold_migrate_target_host_in_other_cell(self):"},{"line_number":765,"context_line":"        \"\"\"Tests cold migrating to a target host in another cell. This is"}],"source_content_type":"text/x-python","patch_set":56,"id":"3fa7e38b_d0ed02b9","line":762,"in_reply_to":"3fa7e38b_656fb2c4","updated":"2019-12-16 16:26:50.000000000","message":"Done: https://review.opendev.org/#/c/698935/","commit_id":"6057373191a7df10b2d2afba876f3c5a15ae33e5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b064a5d6399ae2b18af42eec4b0666facb40a331","unresolved":false,"context_lines":[{"line_number":759,"context_line":"        data is cleaned from both the source and target cell."},{"line_number":760,"context_line":"        \"\"\""},{"line_number":761,"context_line":"        server \u003d self._resize_and_validate()[0]"},{"line_number":762,"context_line":"        self.delete_server_and_assert_cleanup(server)"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    def test_cold_migrate_target_host_in_other_cell(self):"},{"line_number":765,"context_line":"        \"\"\"Tests cold migrating to a target host in another cell. This is"}],"source_content_type":"text/x-python","patch_set":56,"id":"3fa7e38b_5fcb651c","line":762,"in_reply_to":"3fa7e38b_759be778","updated":"2019-12-16 14:21:00.000000000","message":"I can add a wrinkle for that.","commit_id":"6057373191a7df10b2d2afba876f3c5a15ae33e5"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"5405b672426f7f87f019ff146350a6b5405d8708","unresolved":false,"context_lines":[{"line_number":759,"context_line":"        data is cleaned from both the source and target cell."},{"line_number":760,"context_line":"        \"\"\""},{"line_number":761,"context_line":"        server \u003d self._resize_and_validate()[0]"},{"line_number":762,"context_line":"        self.delete_server_and_assert_cleanup(server)"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    def test_cold_migrate_target_host_in_other_cell(self):"},{"line_number":765,"context_line":"        \"\"\"Tests cold migrating to a target host in another cell. This is"}],"source_content_type":"text/x-python","patch_set":56,"id":"3fa7e38b_759be778","line":762,"in_reply_to":"3fa7e38b_f56d979a","updated":"2019-12-16 09:23:23.000000000","message":"Yeah +1 for this point.\nhttps://github.com/openstack/nova/blob/master/nova/tests/functional/test_cross_cell_migrate.py#L415","commit_id":"6057373191a7df10b2d2afba876f3c5a15ae33e5"}]}