)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"503cdcc825704118e3663762c0867b9a605d2649","unresolved":false,"context_lines":[{"line_number":1310,"context_line":"                             exc_info\u003dFalse)"},{"line_number":1311,"context_line":"                    continue"},{"line_number":1312,"context_line":""},{"line_number":1313,"context_line":"            # NOTE(mriedem): A cross-cell migration will work with instance"},{"line_number":1314,"context_line":"            # records across two cells once the migration is confirmed/reverted"},{"line_number":1315,"context_line":"            # one of them will be deleted but the instance still exists in the"},{"line_number":1316,"context_line":"            # other cell. Before the instance is destroyed from the old cell"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_55e5f8a2","line":1313,"updated":"2019-02-26 18:03:19.000000000","message":"Move this to before finish_revert_snapshot_based_resize_at_source in the series.","commit_id":"36962de1d996182a896447309b9a6a809cf4088e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b9f8a40bbd98b45b73a4f7bcbc7765653da1ea28","unresolved":false,"context_lines":[{"line_number":1310,"context_line":"                             exc_info\u003dFalse)"},{"line_number":1311,"context_line":"                    continue"},{"line_number":1312,"context_line":""},{"line_number":1313,"context_line":"            # NOTE(mriedem): A cross-cell migration will work with instance"},{"line_number":1314,"context_line":"            # records across two cells once the migration is confirmed/reverted"},{"line_number":1315,"context_line":"            # one of them will be deleted but the instance still exists in the"},{"line_number":1316,"context_line":"            # other cell. Before the instance is destroyed from the old cell"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_3aa5bc03","line":1313,"in_reply_to":"9fdfeff1_55e5f8a2","updated":"2019-02-26 21:31:11.000000000","message":"Done","commit_id":"36962de1d996182a896447309b9a6a809cf4088e"}],"nova/conductor/tasks/cross_cell_migrate.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2815a69a62e2fde049c7c1eaafb978eb572b9a3e","unresolved":false,"context_lines":[{"line_number":1148,"context_line":"                # # Existing BDM in the source cell so just update it."},{"line_number":1149,"context_line":"                # # TODO(mriedem): Is this correct? Could we be orphaning"},{"line_number":1150,"context_line":"                # # volume attachments by overwriting the attachment_id field?"},{"line_number":1151,"context_line":"                source_bdm \u003d source_cell_bdms_by_uuid.pop(bdm.uuid)  # noqa"},{"line_number":1152,"context_line":"                # self._update_source_obj_from_target_cell(source_bdm, bdm)"},{"line_number":1153,"context_line":"                # source_bdm.save()"},{"line_number":1154,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_0b601a35","line":1151,"updated":"2019-02-21 13:50:38.000000000","message":"We need to pop here so we don\u0027t destroy it below thinking we detached this volume.","commit_id":"47edfca531810a2360766e5dd221523c6b7ff6db"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2815a69a62e2fde049c7c1eaafb978eb572b9a3e","unresolved":false,"context_lines":[{"line_number":1162,"context_line":"                          \u0027attached while the server was resized.\u0027,"},{"line_number":1163,"context_line":"                          bdm.volume_id, instance\u003dself.instance)"},{"line_number":1164,"context_line":"                source_bdm \u003d clone_creatable_object(source_cell_context, bdm)"},{"line_number":1165,"context_line":"                source_bdm.create()"},{"line_number":1166,"context_line":"        # If there are any source bdms left that were not processed from the"},{"line_number":1167,"context_line":"        # target cell bdms, it means those source bdms were detached while"},{"line_number":1168,"context_line":"        # resized in the target cell, and we need to delete them from the"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_eb5ef674","line":1165,"updated":"2019-02-21 13:50:38.000000000","message":"This doesn\u0027t make the functional test fail because when destroying the server we get a VolumeAttachmentNotFound which is logged at debug and ignored:\n\nhttps://github.com/openstack/nova/blob/af78b13c24d4abf393d17ac57e9135204ef12b73/nova/compute/manager.py#L2549","commit_id":"47edfca531810a2360766e5dd221523c6b7ff6db"}],"nova/tests/functional/test_cross_cell_migrate.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7e70e2c0070ecde5714d93c94516ab1454680554","unresolved":false,"context_lines":[{"line_number":457,"context_line":"        # There are two events:"},{"line_number":458,"context_line":"        # - conductor_revert_snapshot_based_resize which is copied from the"},{"line_number":459,"context_line":"        #   target cell database and record in conductor"},{"line_number":460,"context_line":"        #   TODO(mriedem): Maybe we should remove this. I\u0027m curious as to why"},{"line_number":461,"context_line":"        #   conductor_confirm_snapshot_based_resize doesn\u0027t show up for the"},{"line_number":462,"context_line":"        #   confirm scenario..."},{"line_number":463,"context_line":"        # - compute_finish_revert_snapshot_based_resize_at_source which is from"},{"line_number":464,"context_line":"        #   the source compute service method"},{"line_number":465,"context_line":"        # FIXME(mriedem): There should really be three events since we need to"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_246847f2","line":462,"range":{"start_line":460,"start_character":56,"end_line":462,"end_character":31},"updated":"2019-02-26 20:07:12.000000000","message":"It does, it\u0027s compute_confirm_snapshot_based_resize_at_source that doesn\u0027t show up because it\u0027s created in the source cell database and not copied over to the target.","commit_id":"36962de1d996182a896447309b9a6a809cf4088e"}]}