)]}'
{"nova/scheduler/client/report.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"cbc69687719dff1248486b5ec336e815075c90f5","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            # the same host so we need to sum the allocations for"},{"line_number":175,"context_line":"            # the compute node (and possibly shared providers) using both"},{"line_number":176,"context_line":"            # the current and new allocations."},{"line_number":177,"context_line":"            # Note that we sum the allocations rather than take the max per"},{"line_number":178,"context_line":"            # resource class between the current and new allocations because"},{"line_number":179,"context_line":"            # the compute node/resource tracker is going to adjust for"},{"line_number":180,"context_line":"            # decrementing any old allocations as necessary, the scheduler"},{"line_number":181,"context_line":"            # shouldn\u0027t make assumptions about that."},{"line_number":182,"context_line":"            scheduler_utils.merge_resources("},{"line_number":183,"context_line":"                new_alloc_req[\u0027allocations\u0027][rp_uuid][\u0027resources\u0027],"},{"line_number":184,"context_line":"                dest_alloc_req[\u0027allocations\u0027][rp_uuid][\u0027resources\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_78fcf13d","side":"PARENT","line":181,"range":{"start_line":177,"start_character":0,"end_line":181,"end_character":52},"updated":"2019-02-22 17:24:15.000000000","message":"But we would ideally *like* to take the max, because that would be a fix for the cited bug. So I don\u0027t think we should remove this wording entirely without mentioning that (including the bug number in the comment).","commit_id":"e162bcb22ceb7c87924b992ad71a567f1f4c314b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6db453522bb3466282fb3d6dbf2b4e5cbf0a70df","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            # the same host so we need to sum the allocations for"},{"line_number":175,"context_line":"            # the compute node (and possibly shared providers) using both"},{"line_number":176,"context_line":"            # the current and new allocations."},{"line_number":177,"context_line":"            # Note that we sum the allocations rather than take the max per"},{"line_number":178,"context_line":"            # resource class between the current and new allocations because"},{"line_number":179,"context_line":"            # the compute node/resource tracker is going to adjust for"},{"line_number":180,"context_line":"            # decrementing any old allocations as necessary, the scheduler"},{"line_number":181,"context_line":"            # shouldn\u0027t make assumptions about that."},{"line_number":182,"context_line":"            scheduler_utils.merge_resources("},{"line_number":183,"context_line":"                new_alloc_req[\u0027allocations\u0027][rp_uuid][\u0027resources\u0027],"},{"line_number":184,"context_line":"                dest_alloc_req[\u0027allocations\u0027][rp_uuid][\u0027resources\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_f839c1f1","side":"PARENT","line":181,"range":{"start_line":177,"start_character":0,"end_line":181,"end_character":52},"in_reply_to":"9fdfeff1_78fcf13d","updated":"2019-02-22 17:32:00.000000000","message":"As discussed in IRC, I think this entire block condition can be removed because we shouldn\u0027t hit this code since queens when we started swapping the allocations from the instance to the migration record prior to scheduling, so source_allocs should be empty for a resize. I think the only case this method can be called is during evacuate, and you can\u0027t evacuate to the same host so new_rp_uuids should never be empty.","commit_id":"e162bcb22ceb7c87924b992ad71a567f1f4c314b"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b45e2daa5e43f1740e89373d226f13228ea19a7b","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            # the same host so we need to sum the allocations for"},{"line_number":175,"context_line":"            # the compute node (and possibly shared providers) using both"},{"line_number":176,"context_line":"            # the current and new allocations."},{"line_number":177,"context_line":"            # Note that we sum the allocations rather than take the max per"},{"line_number":178,"context_line":"            # resource class between the current and new allocations because"},{"line_number":179,"context_line":"            # the compute node/resource tracker is going to adjust for"},{"line_number":180,"context_line":"            # decrementing any old allocations as necessary, the scheduler"},{"line_number":181,"context_line":"            # shouldn\u0027t make assumptions about that."},{"line_number":182,"context_line":"            scheduler_utils.merge_resources("},{"line_number":183,"context_line":"                new_alloc_req[\u0027allocations\u0027][rp_uuid][\u0027resources\u0027],"},{"line_number":184,"context_line":"                dest_alloc_req[\u0027allocations\u0027][rp_uuid][\u0027resources\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_d8595d5b","side":"PARENT","line":181,"range":{"start_line":177,"start_character":0,"end_line":181,"end_character":52},"in_reply_to":"9fdfeff1_78fcf13d","updated":"2019-02-22 17:30:44.000000000","message":"[Later] Now the hypothesis is that this method is only called during evacuate, and since you can\u0027t evacuate to same host, we can reduce the guts of this whole loop down to just L170-171.","commit_id":"e162bcb22ceb7c87924b992ad71a567f1f4c314b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dccda4009e427b6ba2f134e4e61778d10fcb34b5","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            # the same host so we need to sum the allocations for"},{"line_number":175,"context_line":"            # the compute node (and possibly shared providers) using both"},{"line_number":176,"context_line":"            # the current and new allocations."},{"line_number":177,"context_line":"            # Note that we sum the allocations rather than take the max per"},{"line_number":178,"context_line":"            # resource class between the current and new allocations because"},{"line_number":179,"context_line":"            # the compute node/resource tracker is going to adjust for"},{"line_number":180,"context_line":"            # decrementing any old allocations as necessary, the scheduler"},{"line_number":181,"context_line":"            # shouldn\u0027t make assumptions about that."},{"line_number":182,"context_line":"            scheduler_utils.merge_resources("},{"line_number":183,"context_line":"                new_alloc_req[\u0027allocations\u0027][rp_uuid][\u0027resources\u0027],"},{"line_number":184,"context_line":"                dest_alloc_req[\u0027allocations\u0027][rp_uuid][\u0027resources\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_cc268269","side":"PARENT","line":181,"range":{"start_line":177,"start_character":0,"end_line":181,"end_character":52},"in_reply_to":"9fdfeff1_f839c1f1","updated":"2019-02-22 17:50:43.000000000","message":"\u003e down to just L170-171\n\nNot totally because this code still accounts for shared storage providers...even though we don\u0027t support those yet.","commit_id":"e162bcb22ceb7c87924b992ad71a567f1f4c314b"}]}