)]}'
{"nova/objects/request_spec.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"41063db5a3254509d48c8a78d9d2b088ee37a3d3","unresolved":false,"context_lines":[{"line_number":546,"context_line":"                # NOTE(danms): Instance group may have been deleted"},{"line_number":547,"context_line":"                spec.instance_group \u003d None"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"        if \u0027ignore_hosts\u0027 in spec and spec.ignore_hosts:"},{"line_number":550,"context_line":"            spec.ignore_hosts \u003d []"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"        spec.obj_reset_changes()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_dbe8727d","line":549,"updated":"2019-02-22 23:48:21.000000000","message":"This isn\u0027t right, what you want to do is add it to L527 using an \"in\" statement. IOW, don\u0027t modify ignore_hosts during the lifetime of this RequestSpec object in memory, but don\u0027t persist it either.","commit_id":"3ef55e43d56ce66e003c934f4a5c83e787aca7b3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"41063db5a3254509d48c8a78d9d2b088ee37a3d3","unresolved":false,"context_lines":[{"line_number":598,"context_line":"                spec.instance_group.hosts \u003d None"},{"line_number":599,"context_line":"            # NOTE(mriedem): Don\u0027t persist retries or requested_destination"},{"line_number":600,"context_line":"            # since those are per-request"},{"line_number":601,"context_line":"            for excluded in (\u0027retry\u0027, \u0027requested_destination\u0027,"},{"line_number":602,"context_line":"                             \u0027requested_resources\u0027):"},{"line_number":603,"context_line":"                if excluded in spec and getattr(spec, excluded):"},{"line_number":604,"context_line":"                    setattr(spec, excluded, None)"},{"line_number":605,"context_line":"            # NOTE(stephenfin): Don\u0027t persist network metadata since we have"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_9b02ea3d","line":602,"range":{"start_line":601,"start_character":12,"end_line":602,"end_character":52},"updated":"2019-02-22 23:48:21.000000000","message":"You can just add ignore_hosts to this tuple/generator/thing.","commit_id":"3ef55e43d56ce66e003c934f4a5c83e787aca7b3"}]}