)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"dacf27a6a123233aeaadb0ec8ff12d452c5a9753","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch adds such rp-trait caches for multi create."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"NOTE: I don\u0027t think that today multi-create can be used with port\u0027s that"},{"line_number":17,"context_line":"has resource request (those the one that triggers"},{"line_number":18,"context_line":"_fill_provider_mapping) because for multi create to work the user needs"},{"line_number":19,"context_line":"to pass networks to the server create API insted of pre-created Neutron"},{"line_number":20,"context_line":"ports. However ports with resource request only supported if pre-created"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_0d3e88b7","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":20},"updated":"2019-03-25 23:26:05.000000000","message":"oh, do we not hit this code path for regular multicreate?","commit_id":"35ff258f7905caf5054a9648f5f16443270fc33a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"40d3a54bc4c4ce437b9add7e859b7bdc4ea831bc","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch adds such rp-trait caches for multi create."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"NOTE: I don\u0027t think that today multi-create can be used with port\u0027s that"},{"line_number":17,"context_line":"has resource request (those the one that triggers"},{"line_number":18,"context_line":"_fill_provider_mapping) because for multi create to work the user needs"},{"line_number":19,"context_line":"to pass networks to the server create API insted of pre-created Neutron"},{"line_number":20,"context_line":"ports. However ports with resource request only supported if pre-created"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_2f2fb388","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":20},"in_reply_to":"5fc1f717_0d3e88b7","updated":"2019-03-26 09:39:39.000000000","message":"The multicreate only works with neutron networks:\n\nstack@ubuntu:~/devstack$ openstack server create --image cirros-0.4.0-x86_64-disk --flavor c1 demo-vm --min\u003d2 --max\u003d2 --nic port-id\u003dmy-port --wait\nFailed to launch instances: Unable to launch multiple instances with a single configured port ID. Please launch your instance one by one with different ports. (HTTP 400) (Request-ID: req-f20c8bf8-6e3c-4ce9-96da-9f64cc0a9497)\n\n\nThe code in question only triggered if there are ports with resource request. But nova only supports such ports if they are pre-created in neutron before the server create. So multicreate will not trigger the codepath in question. It will hit this early return [1]\n\n[1] https://review.openstack.org/#/c/638847/1/nova/conductor/manager.py@1271","commit_id":"35ff258f7905caf5054a9648f5f16443270fc33a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5fb41666aebddad60db47e3dec91f1a761705436","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch adds such rp-trait caches for multi create."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"NOTE: I don\u0027t think that today multi-create can be used with port\u0027s that"},{"line_number":17,"context_line":"has resource request (those the one that triggers"},{"line_number":18,"context_line":"_fill_provider_mapping) because for multi create to work the user needs"},{"line_number":19,"context_line":"to pass networks to the server create API insted of pre-created Neutron"},{"line_number":20,"context_line":"ports. However ports with resource request only supported if pre-created"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_58f7628c","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":20},"in_reply_to":"5fc1f717_2f2fb388","updated":"2019-03-26 15:56:45.000000000","message":"Thanks for the explanation.","commit_id":"35ff258f7905caf5054a9648f5f16443270fc33a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e15bd6481df8179cb28bcb6f402678960c7739e2","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch adds such rp-trait caches for multi create."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"NOTE: I don\u0027t think that today multi-create can be used with port\u0027s that"},{"line_number":17,"context_line":"has resource request (those the one that triggers"},{"line_number":18,"context_line":"_fill_provider_mapping) because for multi create to work the user needs"},{"line_number":19,"context_line":"to pass networks to the server create API insted of pre-created Neutron"},{"line_number":20,"context_line":"ports. However ports with resource request only supported if pre-created"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_98960b3e","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":20},"in_reply_to":"5fc1f717_58f7628c","updated":"2019-03-27 17:28:02.000000000","message":"Instead of abandoning it, I changed the TODO to a NOTE.","commit_id":"35ff258f7905caf5054a9648f5f16443270fc33a"}]}