)]}'
{"id":"openstack%2Fnova~640887","triplet_id":"openstack%2Fnova~master~Icb889c09a69e7c5cbf9330e5d9917d6ab3ac3dc5","project":"openstack/nova","branch":"master","topic":"bug/1818560","hashtags":[],"change_id":"Icb889c09a69e7c5cbf9330e5d9917d6ab3ac3dc5","subject":"Stop using PlacementDirect","status":"MERGED","created":"2019-03-04 22:31:39.000000000","updated":"2020-03-05 17:50:07.000000000","submitted":"2020-03-05 17:40:32.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":21,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"640887-1583430032901-cb471cbf","meta_rev_id":"a66a4f37383dacf270b7fab997f2844911b32c9a","_number":640887,"virtual_id_number":640887,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"date":"2020-03-05 14:13:30.000000000","_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"value":0,"date":"2020-03-05 14:43:53.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"date":"2020-03-05 14:00:57.000000000","_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-05 17:40:32.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"date":"2020-03-05 15:27:01.000000000","_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"date":"2020-03-05 16:12:52.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"date":"2020-03-05 13:39:36.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2020-03-05 13:52:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-03-05 13:48:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":1,"date":"2020-03-05 13:52:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-03-05 15:07:50.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2019-03-05 15:31:42.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-03-11 07:51:44.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2019-03-11 21:05:33.000000000","updated_by":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-03-11 21:48:46.000000000","updated_by":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-03-11 22:41:11.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-03-11 23:02:27.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-03-05 13:48:05.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2020-03-05 13:52:25.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2020-03-05 14:00:57.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2020-03-05 14:13:30.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-03-05 14:43:53.000000000","updated_by":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"reviewer":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"state":"REVIEWER"},{"updated":"2020-03-05 15:27:01.000000000","updated_by":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-03-05 16:12:52.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2020-03-05 17:40:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0ac527fe516893ed4558437d6c3c305b95a88632","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-04 22:31:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"373a74c529c2bc99be3a380b9ea91bf50321b06a","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2019-03-04 22:32:03.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial tempest-dsvm-intel-nfv-xenial : SKIPPED (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial tempest-dsvm-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"29accc18e4cfa8fa12b1274900ea34b65cd47943","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-04 22:37:40.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"545e4d3b4ebfaae2222f9abc703f595ad5fa2e81","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-03-04 22:42:24.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/640887/1 : FAILURE in 9m 41s","accounts_in_message":[],"_revision_number":1},{"id":"3d7ef92b349d351c98463f2de33d7b8cb9377381","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-03-04 22:49:41.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)\n\nthis certainly looks cleaner to me and it removes a number of dependencies but it looks like a good change to me.","accounts_in_message":[],"_revision_number":1},{"id":"f11a79ae391b8404080007c608c11898f9f76ea5","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-04 22:59:15.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c1993964bbd1d8ffaa9e7fc873e1639d61722423","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-03-04 23:15:14.000000000","message":"Patch Set 1:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/87/640887/1/check/nova-out-of-tree-pvm/874af9e : FAILURE in 42m 27s\n- nova-in-tree-pvm http://184.172.12.213/87/640887/1/check/nova-in-tree-pvm/e17a853 : FAILURE in 40m 57s","accounts_in_message":[],"_revision_number":1},{"id":"7e234bb79c1b662b711d780cc1a994c6eaf32155","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2019-03-04 23:26:39.000000000","message":"Patch Set 1:\n\nTesting completed on the zVM Driver CI system check-nova pipeline and failed.  To recheck only the zVM driver plugins, submit a comment with only  zvm: recheck in the comment.. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-28636 : FAILURE in 54m 25s","accounts_in_message":[],"_revision_number":1},{"id":"bce14b8e029a1889fa610ca2265f46e609bca2e0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-04 23:59:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/87/640887/1/check/openstack-tox-cover/3a05781/cover/ : SUCCESS in 16m 15s\n- openstack-tox-lower-constraints http://logs.openstack.org/87/640887/1/check/openstack-tox-lower-constraints/c99a55f/ : SUCCESS in 14m 03s\n- openstack-tox-pep8 http://logs.openstack.org/87/640887/1/check/openstack-tox-pep8/1cfbb3c/ : SUCCESS in 9m 24s\n- openstack-tox-py27 http://logs.openstack.org/87/640887/1/check/openstack-tox-py27/ab47f75/ : SUCCESS in 11m 06s\n- openstack-tox-py35 http://logs.openstack.org/87/640887/1/check/openstack-tox-py35/2e5c7fd/ : SUCCESS in 12m 02s\n- openstack-tox-py36 http://logs.openstack.org/87/640887/1/check/openstack-tox-py36/a4dfe1a/ : SUCCESS in 12m 26s\n- openstack-tox-docs http://logs.openstack.org/87/640887/1/check/openstack-tox-docs/2f233e6/html/ : SUCCESS in 6m 36s\n- nova-tox-functional http://logs.openstack.org/87/640887/1/check/nova-tox-functional/1ba43e5/ : SUCCESS in 21m 12s\n- nova-tox-functional-py35 http://logs.openstack.org/87/640887/1/check/nova-tox-functional-py35/3723061/ : SUCCESS in 25m 00s","accounts_in_message":[],"_revision_number":1},{"id":"e45c2d24d6cd9fad17914a4e305add510a34fefd","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2019-03-05 00:00:05.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- EMC_VxFlexOS_NOVA http://publiclogs.emc.com/87/640887/1/check/EMC_VxFlexOS_NOVA/9c3efe8/EMC_VxFlexOS_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-dell-emc-vxflexos\u0027 to trigger a recheck, for more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/Dell_EMC_VxFlexOS_CI","accounts_in_message":[],"_revision_number":1},{"id":"20f7aba93c62ce3c1e01ab75e31faf0807eec316","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2019-03-05 00:29:25.000000000","message":"Patch Set 1:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/87/640887/1/check-vote/ext-nova-zuul/c1b5574 : SUCCESS in 59m 24s","accounts_in_message":[],"_revision_number":1},{"id":"005fa3cad0022187b57c7e37146ea6350a7997f3","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2019-03-05 00:58:54.000000000","message":"Patch Set 1:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-87-640887-1 : FAILURE \n\nSee https://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI for rechecking and info.","accounts_in_message":[],"_revision_number":1},{"id":"798e1bed09988009b5c665a223544e83866a7ce5","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-03-05 01:37:43.000000000","message":"Patch Set 1: Code-Review+1\n\nNice work. I agree this is a change we should have.\n\nAlthough the diff looks big, it\u0027s not actually that much of a change. If we\u0027re feeling inclined I don\u0027t think we should wait on this until Train. Merge my patches if they are going to be ready sooner, then merge this.\n\nOr wait, but we should do this.","accounts_in_message":[],"_revision_number":1},{"id":"91c2abd23ef05795ac7550aea71f000e27360c06","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-05 14:45:47.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"342a1bf5a2d0bbdc6505a638270468de79ef0ac0","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2019-03-05 14:46:12.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial tempest-dsvm-intel-nfv-xenial : SKIPPED (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial tempest-dsvm-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"2b22fdb3f98c36c90de788bc8eec3c4465098316","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-05 14:46:55.000000000","message":"Patch Set 3: Published edit on patch set 2.","accounts_in_message":[],"_revision_number":3},{"id":"b57c1e974a63841c56349fbadf86708444eae025","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2019-03-05 14:47:21.000000000","message":"Patch Set 3:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial tempest-dsvm-intel-nfv-xenial : SKIPPED (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial tempest-dsvm-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"96c646d2cd5f47a65d94c50e1388afa6de01d5c3","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-03-05 15:07:20.000000000","message":"Patch Set 3: Code-Review+1\n\nMessed about with this locally. Does what it says.","accounts_in_message":[],"_revision_number":3},{"id":"bbc89d2bdd6c09c61b90301542c5bd62875be687","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-03-05 15:07:50.000000000","message":"Patch Set 3: Code-Review+1\n\nthis still looks good to me","accounts_in_message":[],"_revision_number":3},{"id":"27b8671bea0ad0566cec042ba38ca6db16910e60","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-05 15:13:04.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/87/640887/3/check/openstack-tox-cover/9986248/cover/ : SUCCESS in 15m 55s\n- openstack-tox-lower-constraints http://logs.openstack.org/87/640887/3/check/openstack-tox-lower-constraints/6aba4e0/ : SUCCESS in 13m 45s\n- openstack-tox-pep8 http://logs.openstack.org/87/640887/3/check/openstack-tox-pep8/723858e/ : SUCCESS in 10m 36s\n- openstack-tox-py27 http://logs.openstack.org/87/640887/3/check/openstack-tox-py27/aed4b17/ : SUCCESS in 14m 08s\n- openstack-tox-py35 http://logs.openstack.org/87/640887/3/check/openstack-tox-py35/68478ce/ : SUCCESS in 13m 40s\n- openstack-tox-py36 http://logs.openstack.org/87/640887/3/check/openstack-tox-py36/e55faf1/ : SUCCESS in 11m 41s\n- openstack-tox-docs http://logs.openstack.org/87/640887/3/check/openstack-tox-docs/9aea11f/html/ : SUCCESS in 6m 26s\n- nova-tox-functional http://logs.openstack.org/87/640887/3/check/nova-tox-functional/d043a86/ : SUCCESS in 20m 35s\n- nova-tox-functional-py35 http://logs.openstack.org/87/640887/3/check/nova-tox-functional-py35/278c7cb/ : SUCCESS in 17m 16s","accounts_in_message":[],"_revision_number":3},{"id":"5cb54ff645b7f91347fda55c5e2f5c4e0a27dd1b","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2019-03-05 15:13:31.000000000","message":"Patch Set 3:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- EMC_VxFlexOS_NOVA http://publiclogs.emc.com/87/640887/3/check/EMC_VxFlexOS_NOVA/4f1149e/EMC_VxFlexOS_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-dell-emc-vxflexos\u0027 to trigger a recheck, for more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/Dell_EMC_VxFlexOS_CI","accounts_in_message":[],"_revision_number":3},{"id":"fa4bb4fe63fac70873423d6e1e364be77b0f8917","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-03-05 15:31:42.000000000","message":"Patch Set 3:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/87/640887/3/check/nova-out-of-tree-pvm/b829d59 : FAILURE in 43m 53s\n- nova-in-tree-pvm http://184.172.12.213/87/640887/3/check/nova-in-tree-pvm/bf94d5e : FAILURE in 40m 59s","accounts_in_message":[],"_revision_number":3},{"id":"557334a5d961b8b196727c468db72e2d90148f61","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2019-03-05 16:20:43.000000000","message":"Patch Set 3:\n\nTesting completed on the zVM Driver CI system check-nova pipeline.  To recheck only the zVM driver plugins, submit a comment with only zvm: recheck in the comment. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-28682 : SUCCESS in 1h 33m 18s","accounts_in_message":[],"_revision_number":3},{"id":"8d9b724030488bd35db67810f9ef8c47cce14e4d","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2019-03-05 16:29:15.000000000","message":"Patch Set 3:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-87-640887-3 : SUCCESS \n\nhttps://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI","accounts_in_message":[],"_revision_number":3},{"id":"7c90a031b69c172be22ba85e6c95bb6f8b73c9dd","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-03-05 17:14:33.000000000","message":"Patch Set 3:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/640887/3 : SUCCESS in 2h 26m 51s","accounts_in_message":[],"_revision_number":3},{"id":"3da4edb00067b2ada598a1d284458101eb49669c","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2019-03-05 20:33:02.000000000","message":"Patch Set 3:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/87/640887/3/check-vote/ext-nova-zuul/79221d2 : SUCCESS in 55m 32s","accounts_in_message":[],"_revision_number":3},{"id":"ac032b4d9f0ce54c6e592e8ed44069524cfadfcc","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-03-11 07:51:44.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"038330ffa9d6c8ba6c736dacab360045eefcf3dd","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-03-11 15:29:39.000000000","message":"Patch Set 3:\n\n(4 comments)","accounts_in_message":[],"_revision_number":3},{"id":"0acf3ce9cfd1606b3e0bb2a16b59ddadf1c20260","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-03-11 15:34:03.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"dae62ba59cf5fa975ed4ece0ff537a0dbf441e8f","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-03-11 15:34:45.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"372c9935719c7f6c66db8e2371c539b2777672ae","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-03-11 15:39:48.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"61b874e66355c83f52bde65e161d38a17ab95c88","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-11 16:27:17.000000000","message":"Patch Set 3: Workflow-1\n\n(3 comments)\n\nWhile I look into that NonCallableMock, what do you want to do about testing PlacementDirect?","accounts_in_message":[],"_revision_number":3},{"id":"0d8c36166477ddc4694986c8a526305e0789c358","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-03-11 16:41:23.000000000","message":"Patch Set 3:\n\n(1 comment)\n\nI\u0027m OK to drop the test coverage for PlacementDirect in nova since it\u0027s already tested in placement (I didn\u0027t make that connection). Maybe note it in the commit message for dummies like me.","accounts_in_message":[],"_revision_number":3},{"id":"4fc4e41823982cb0ea1b219b830c63c0be9cc8be","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-11 19:36:18.000000000","message":"Patch Set 3:\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"70c940d229ba4d2640519a8640de070d9c3337c4","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-11 19:36:46.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"9cca4091eaa2163e980c91613ca7fe657010f0ad","author":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"date":"2019-03-11 19:36:58.000000000","message":"Patch Set 4:\n\n* pci-test http://52.27.155.124/pci/640887/4 : FAILURE","accounts_in_message":[],"_revision_number":4},{"id":"9f58955923db226e13c73dabcd702ad12584b65a","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2019-03-11 19:37:12.000000000","message":"Patch Set 4:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial tempest-dsvm-intel-nfv-xenial : SKIPPED (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial tempest-dsvm-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"45893309b299c53ad90ba9e893090a1ec180afcf","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-03-11 19:41:31.000000000","message":"Patch Set 4: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"a53261e89bbf5d55a59e43fb0117f00a389498f5","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2019-03-11 19:44:02.000000000","message":"Patch Set 4:\n\nTesting completed on the zVM Driver CI system check-nova pipeline and failed.  To recheck only the zVM driver plugins, submit a comment with only  zvm: recheck in the comment.. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-29067 : FAILURE in 6m 45s","accounts_in_message":[],"_revision_number":4},{"id":"34f1e65b9b4531e005e6cd28d5b1a849d2c79cac","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-11 20:03:03.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/87/640887/4/check/openstack-tox-cover/6cf2d75/cover/ : SUCCESS in 17m 37s\n- openstack-tox-lower-constraints http://logs.openstack.org/87/640887/4/check/openstack-tox-lower-constraints/cf25bc8/ : SUCCESS in 17m 16s\n- openstack-tox-pep8 http://logs.openstack.org/87/640887/4/check/openstack-tox-pep8/a8eaf7e/ : SUCCESS in 10m 02s\n- openstack-tox-py27 http://logs.openstack.org/87/640887/4/check/openstack-tox-py27/09a1b28/ : SUCCESS in 17m 26s\n- openstack-tox-py35 http://logs.openstack.org/87/640887/4/check/openstack-tox-py35/7fe3b5c/ : SUCCESS in 12m 38s\n- openstack-tox-py36 http://logs.openstack.org/87/640887/4/check/openstack-tox-py36/0446270/ : SUCCESS in 12m 00s\n- openstack-tox-docs http://logs.openstack.org/87/640887/4/check/openstack-tox-docs/cb66674/html/ : SUCCESS in 5m 54s\n- nova-tox-functional http://logs.openstack.org/87/640887/4/check/nova-tox-functional/72b7eb0/ : SUCCESS in 20m 16s\n- nova-tox-functional-py35 http://logs.openstack.org/87/640887/4/check/nova-tox-functional-py35/80d9a4b/ : SUCCESS in 17m 59s","accounts_in_message":[],"_revision_number":4},{"id":"60a8a508674af6e53801650e638d756de62483e0","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2019-03-11 20:33:06.000000000","message":"Patch Set 4:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/87/640887/4/check-vote/ext-nova-zuul/eb12969 : SUCCESS in 55m 50s","accounts_in_message":[],"_revision_number":4},{"id":"19180182cb199db804e1d07c2dcbda030fb0c3b8","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-11 21:05:07.000000000","message":"Patch Set 5: Commit message was updated.","accounts_in_message":[],"_revision_number":5},{"id":"1a9f6a956bcffcd71bb6421589205a5f2963b588","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2019-03-11 21:05:33.000000000","message":"Patch Set 5:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial tempest-dsvm-intel-nfv-xenial : SKIPPED (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial tempest-dsvm-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"3c9491208dec67b9224c025fefed02d237c5c531","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-11 21:05:58.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"49bc72918b00062f1854fd21863c38350a49854b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-11 21:45:30.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/87/640887/5/check/openstack-tox-cover/67a99a0/cover/ : SUCCESS in 17m 54s\n- openstack-tox-lower-constraints http://logs.openstack.org/87/640887/5/check/openstack-tox-lower-constraints/f516259/ : SUCCESS in 13m 41s\n- openstack-tox-pep8 http://logs.openstack.org/87/640887/5/check/openstack-tox-pep8/366451f/ : SUCCESS in 12m 22s\n- openstack-tox-py27 http://logs.openstack.org/87/640887/5/check/openstack-tox-py27/1e29b06/ : SUCCESS in 15m 44s\n- openstack-tox-py35 http://logs.openstack.org/87/640887/5/check/openstack-tox-py35/0db36d4/ : SUCCESS in 13m 31s\n- openstack-tox-py36 http://logs.openstack.org/87/640887/5/check/openstack-tox-py36/008d94e/ : SUCCESS in 14m 59s\n- openstack-tox-docs http://logs.openstack.org/87/640887/5/check/openstack-tox-docs/1a87cf9/html/ : SUCCESS in 8m 43s\n- nova-tox-functional http://logs.openstack.org/87/640887/5/check/nova-tox-functional/f3fee25/ : SUCCESS in 22m 28s\n- nova-tox-functional-py35 http://logs.openstack.org/87/640887/5/check/nova-tox-functional-py35/4167ef8/ : SUCCESS in 22m 11s","accounts_in_message":[],"_revision_number":5},{"id":"873292f8b7769a0626e976f333a67698185c6824","author":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"date":"2019-03-11 21:48:46.000000000","message":"Patch Set 5:\n\n* pci-test http://52.27.155.124/pci/640887/5 : FAILURE","accounts_in_message":[],"_revision_number":5},{"id":"726dc2c38ebd8c33cdd423c3c5814bdd80da3eab","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2019-03-11 22:39:20.000000000","message":"Patch Set 5:\n\nTesting completed on the zVM Driver CI system check-nova pipeline and failed.  To recheck only the zVM driver plugins, submit a comment with only  zvm: recheck in the comment.. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-29074 : FAILURE in 1h 33m 42s","accounts_in_message":[],"_revision_number":5},{"id":"177dc0495556319815e4049d99564912954e6578","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-03-11 22:41:11.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"178e35658341fac070b458fc9a2c77521f49c676","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2019-03-11 23:02:27.000000000","message":"Patch Set 5:\n\nBuild failed\n\n- dsvm-nova http://207.189.188.190/logs/87/640887/5/check-vote/ext-nova-zuul/55c23c2 : FAILURE in 1h 05m 21s","accounts_in_message":[],"_revision_number":5},{"id":"032e9c27f944440b4075a35dcd79203fe503c59d","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-03-11 23:13:35.000000000","message":"Patch Set 5:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/640887/5 : SUCCESS in 2h 07m 51s","accounts_in_message":[],"_revision_number":5},{"id":"5d0ba2cb239c33195835f3bdfa5c3bbe5e6eae15","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2019-03-12 00:11:24.000000000","message":"Patch Set 4:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-87-640887-4 : SUCCESS \n\nhttps://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI","accounts_in_message":[],"_revision_number":4},{"id":"aedd0f5ad691eeecf9a34018aff62b6249058abc","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2019-03-12 03:04:25.000000000","message":"Patch Set 5:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-87-640887-5 : FAILURE \n\nSee https://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI for rechecking and info.","accounts_in_message":[],"_revision_number":5},{"id":"f0b0ece4c85f6e4b173e774c1c34c574e976ea2f","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-03-12 11:51:50.000000000","message":"Patch Set 5: Code-Review+1\n\nyup","accounts_in_message":[],"_revision_number":5},{"id":"752576183ba30f83e9ff8df9a90cc8d923fd7690","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2020-03-05 13:36:43.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"5604e4d9a8754fd46ee9a5bc4aa72dfbe7c12927","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2020-03-05 13:39:36.000000000","message":"Patch Set 6:\n\nManual rebase.\n\nRecommend reviewing test_report_client.py with Ignore Whitespace \u003d All.","accounts_in_message":[],"_revision_number":6},{"id":"4295c5e850bfc5013bd66a87af538f5552459e48","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2020-03-05 13:48:05.000000000","message":"Patch Set 6: Code-Review+1\n\nI haven\u0027t given this a close review because time/energy but assuming zuul likes it, great, this is the right thing to do.\n\nSince the out-of-band reshaper never appeared, it may be worth killing off PlacementDirect in placement itself. The only thing within placement that appears to be using it, other than self-tests, are policy tests.","accounts_in_message":[],"_revision_number":6},{"id":"43e12ad3ef48a90d7d3bb2716005781cdd9c5e38","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-03-05 13:52:08.000000000","message":"Patch Set 6: Code-Review+2","accounts_in_message":[],"_revision_number":6},{"id":"64c0b828d75473ac314963a519f567938b5ff301","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-03-05 13:52:25.000000000","message":"Patch Set 6: Workflow+1\n\nFast approving since mriedem was +2 on this previously and it\u0027s just a rebase","accounts_in_message":[],"_revision_number":6},{"id":"455279d8e1c26e9d5a94f119cef6ad8bda4f0052","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-03-05 14:00:57.000000000","message":"Patch Set 6:\n\nBuild SUCCESSFUL (check pipeline).\n\n- pmem-tempest-plugin-filtered http://52.27.155.124/87/640887/6/check/pmem-tempest-plugin-filtered/e3f2a66/ : SUCCESS in 23m 04s","accounts_in_message":[],"_revision_number":6},{"id":"af58ee2178d16c2b34ec20ff24f928875b3c7653","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-05 14:12:51.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/be3c4c84193c480b8eddd81855b91076 : SUCCESS in 20m 09s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/96d0fe2194944cdab262d13e6205255a : SUCCESS in 14m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c3a10a278deb420195a3e70b7ee5afdf : SUCCESS in 9m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b26c375ac8384397b8939ea529ece1ee : SUCCESS in 13m 08s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/1879952097374349b1f2d56dcd890f05 : SUCCESS in 13m 20s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/7d0a92d926b64d7ca4f3d547d77f4495 : SUCCESS in 13m 43s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/48920380862441dcbb576217c7e0e4d7 : SUCCESS in 11m 29s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/8a0e9a27e89b483397dece51a3714af9 : SUCCESS in 15m 19s","accounts_in_message":[],"_revision_number":6},{"id":"196b15fa410b3b318332c901dfdd6e7d788d9def","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-05 14:13:18.000000000","message":"Patch Set 6: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":6},{"id":"f836a57f3bfcf738530d31cd4a56d295e1146cb1","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2020-03-05 14:13:30.000000000","message":"Patch Set 6:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_VxFlexOS_NOVA http://publiclogs.emc.com/87/640887/6/check/EMC_VxFlexOS_NOVA/466e0be/EMC_VxFlexOS_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC VxFlexOS CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_VxFlexOS_CI","accounts_in_message":[],"_revision_number":6},{"id":"970d8a3657590ae8cc61a28d9d24f5fe5a9f3686","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2020-03-05 14:43:53.000000000","message":"Patch Set 6:\n\nTesting completed on the zVM Driver CI system check-nova pipeline.  To recheck only the zVM driver plugins, submit a comment with only zvm: recheck in the comment. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-41498 : SUCCESS in 1h 06m 39s","accounts_in_message":[],"_revision_number":6},{"id":"f2e3055d6b1e208838ff37d12a8de3e9baea9a29","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2020-03-05 15:27:01.000000000","message":"Patch Set 6:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-87-640887-6 : FAILURE \n\nSee https://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI for rechecking and info.","accounts_in_message":[],"_revision_number":6},{"id":"6a0de9bc85b5caca35ec9c6309fc269de09964c5","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-03-05 16:12:52.000000000","message":"Patch Set 6:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/640887/6 : FAILURE in 2h 35m 20s","accounts_in_message":[],"_revision_number":6},{"id":"6a49b1be7b462519f3a5b9207e356f9c6e12aee6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-05 17:40:32.000000000","message":"Patch Set 6: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f941e84cff1546b089711b3e00bf08c4 : SUCCESS in 18m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c615c689b37a424ca44821ee0abc2e81 : SUCCESS in 8m 26s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c122ba3cc6c34627be0db1ce2ff0212a : SUCCESS in 14m 59s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/931fcd3a026049f89d98ed11e786ce69 : SUCCESS in 15m 17s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/24722d18839f4208bce052ec66fc33bd : SUCCESS in 12m 40s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/233f6b8838d944ffa644445d620220fa : SUCCESS in 17m 11s","accounts_in_message":[],"_revision_number":6},{"id":"596542009a9930d9e186ec61b26fa9fa824d73a5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-05 17:40:32.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":6},{"id":"63b3c33e0f4cf595f13840c890b67f3e7a3ae42e","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-05 17:50:07.000000000","message":"Patch Set 6:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f331e1bb3bac4e3b847328784e6a62a4 : SUCCESS in 1m 29s","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"f2d088b04e6e6896f0df04f03e92b32a539b6917","revisions":{"6a8d73443c92f7751027da362d4fd043eeac3edf":{"kind":"REWORK","_number":1,"created":"2019-03-04 22:31:39.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/87/640887/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/640887/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/640887/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/640887/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/640887/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/640887/1"}}},"commit":{"parents":[{"commit":"c7db20d140eb0d3ccf0fd107eda7e80275bdd7d4","subject":"Merge \"Remove wrong description for auto resize confirm\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c7db20d140eb0d3ccf0fd107eda7e80275bdd7d4"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-04 22:08:39.000000000","tz":-360},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-04 22:31:36.000000000","tz":-360},"subject":"Stop using PlacementDirect","message":"Stop using PlacementDirect\n\nPlacementDirect was integrated into a functional test suite when it was\nfirst created as a way to prove that it worked and demonstrate how to\nuse it.\n\nHowever, it was a pain then, because the interceptor needs to be created\nevery time you want to use it; and since extracted placement started\ndiverging from in-tree placement, other problems started cropping up\n(see the associated bug).\n\nSo this commit removes the use of PlacementDirect from nova. Details:\n\n- test_report_client now uses PlacementFixture. So all the `with\n  interceptor` context management is gone. This accounts for the vast\n  majority of the apparent change, which is just outdenting those\n  contexts.\n- SchedulerReportClientTestBase, which was doing some hocus pocus to\n  wrap the SchedulerReportClient such that we could do some microversion\n  checks, is removed. The test suite simply instantiates the\n  microversion-checking wrapper class directly as the client used by the\n  test cases.\n- We were taking advantage of a PlacementDirect feature allowing us to\n  default to the latest microversion if not explicitly specified in the\n  request. Without this, we had to add the `version` kwarg to some of\n  the calls we were making to SchedulerReportClient primitives\n  (get/put/post/delete).\n- A piece of test_update_from_provider_tree was using a\n  deliberately-broken interceptor to prove that the code in question\n  wasn\u0027t hitting the API. We replace this with a non-callable mock on\n  the Adapter\u0027s request method.\n- test_global_request_id was taking advantage of the interceptor to\n  validate that the global request ID was making it to the \"other side\"\n  of the API boundary. This was fun, but overkill. We now simply assert\n  that the correct HTTP header is making it into the ksa Adapter\u0027s\n  request method.\n- Functional test suite test_resource_tracker.IronicResourceTrackerTest\n  was inheriting from the SchedulerReportClientTestBase class, but not\n  using the interceptor anywhere. Can\u0027t tell you why that was done. So\n  now it just uses the plain old test.TestBase like everyone else.\n\nChange-Id: Icb889c09a69e7c5cbf9330e5d9917d6ab3ac3dc5\nCloses-Bug: #1818560\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6a8d73443c92f7751027da362d4fd043eeac3edf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6a8d73443c92f7751027da362d4fd043eeac3edf"}]},"branch":"refs/heads/master"},"4872867d2bc3b1f0d4c31d58889c852b973e9eb3":{"kind":"REWORK","_number":2,"created":"2019-03-05 14:45:47.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/87/640887/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/640887/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/640887/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/640887/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/640887/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/640887/2"}}},"commit":{"parents":[{"commit":"c43c1d3fb9da5dd0a13e1f15623a696212f095ff","subject":"Merge \"libvirt: Omit needless check on \u0027CONF.serial_console\u0027\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c43c1d3fb9da5dd0a13e1f15623a696212f095ff"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-04 22:08:39.000000000","tz":-360},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-05 14:45:41.000000000","tz":-360},"subject":"Stop using PlacementDirect","message":"Stop using PlacementDirect\n\nPlacementDirect was integrated into a functional test suite when it was\nfirst created as a way to prove that it worked and demonstrate how to\nuse it.\n\nHowever, it was a pain then, because the interceptor needs to be created\nevery time you want to use it; and since extracted placement started\ndiverging from in-tree placement, other problems started cropping up\n(see the associated bug).\n\nSo this commit removes the use of PlacementDirect from nova. Details:\n\n- test_report_client now uses PlacementFixture. So all the `with\n  interceptor` context management is gone. This accounts for the vast\n  majority of the apparent change, which is just outdenting those\n  contexts.\n- SchedulerReportClientTestBase, which was doing some hocus pocus to\n  wrap the SchedulerReportClient such that we could do some microversion\n  checks, is removed. The test suite simply instantiates the\n  microversion-checking wrapper class directly as the client used by the\n  test cases.\n- We were taking advantage of a PlacementDirect feature allowing us to\n  default to the latest microversion if not explicitly specified in the\n  request. Without this, we had to add the `version` kwarg to some of\n  the calls we were making to SchedulerReportClient primitives\n  (get/put/post/delete).\n- A piece of test_update_from_provider_tree was using a\n  deliberately-broken interceptor to prove that the code in question\n  wasn\u0027t hitting the API. We replace this with a non-callable mock on\n  the Adapter\u0027s request method.\n- test_global_request_id was taking advantage of the interceptor to\n  validate that the global request ID was making it to the \"other side\"\n  of the API boundary. This was fun, but overkill. We now simply assert\n  that the correct HTTP header is making it into the ksa Adapter\u0027s\n  request method.\n- Functional test suite test_resource_tracker.IronicResourceTrackerTest\n  was inheriting from the SchedulerReportClientTestBase class, but not\n  using the interceptor anywhere. Can\u0027t tell you why that was done. So\n  now it just uses the plain old test.TestBase like everyone else.\n\nChange-Id: Icb889c09a69e7c5cbf9330e5d9917d6ab3ac3dc5\nCloses-Bug: #1818560\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4872867d2bc3b1f0d4c31d58889c852b973e9eb3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4872867d2bc3b1f0d4c31d58889c852b973e9eb3"}]},"branch":"refs/heads/master"},"73fc1df5f21147835058a27efe00ca6596320610":{"kind":"REWORK","_number":3,"created":"2019-03-05 14:46:55.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/87/640887/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/640887/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/640887/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/640887/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/640887/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/640887/3"}}},"commit":{"parents":[{"commit":"c43c1d3fb9da5dd0a13e1f15623a696212f095ff","subject":"Merge \"libvirt: Omit needless check on \u0027CONF.serial_console\u0027\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c43c1d3fb9da5dd0a13e1f15623a696212f095ff"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-04 22:08:39.000000000","tz":-360},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-05 14:46:54.000000000","tz":0},"subject":"Stop using PlacementDirect","message":"Stop using PlacementDirect\n\nPlacementDirect was integrated into a functional test suite when it was\nfirst created as a way to prove that it worked and demonstrate how to\nuse it.\n\nHowever, it was a pain then, because the interceptor needs to be created\nevery time you want to use it; and since extracted placement started\ndiverging from in-tree placement, other problems started cropping up\n(see the associated bug).\n\nSo this commit removes the use of PlacementDirect from nova. Details:\n\n- test_report_client now uses PlacementFixture. So all the `with\n  interceptor` context management is gone. This accounts for the vast\n  majority of the apparent change, which is just outdenting those\n  contexts.\n- SchedulerReportClientTestBase, which was doing some hocus pocus to\n  wrap the SchedulerReportClient such that we could do some microversion\n  checks, is removed. The test suite simply instantiates the\n  microversion-checking wrapper class directly as the client used by the\n  test cases.\n- We were taking advantage of a PlacementDirect feature allowing us to\n  default to the latest microversion if not explicitly specified in the\n  request. Without this, we had to add the `version` kwarg to some of\n  the calls we were making to SchedulerReportClient primitives\n  (get/put/post/delete).\n- A piece of test_update_from_provider_tree was using a\n  deliberately-broken interceptor to prove that the code in question\n  wasn\u0027t hitting the API. We replace this with a non-callable mock on\n  the Adapter\u0027s request method.\n- test_global_request_id was taking advantage of the interceptor to\n  validate that the global request ID was making it to the \"other side\"\n  of the API boundary. This was fun, but overkill. We now simply assert\n  that the correct HTTP header is making it into the ksa Adapter\u0027s\n  request method.\n- Functional test suite test_resource_tracker.IronicResourceTrackerTest\n  was inheriting from the SchedulerReportClientTestBase class, but not\n  using the interceptor anywhere. Can\u0027t tell you why that was done. So\n  now it just uses the plain old test.TestBase like everyone else.\n\nChange-Id: Icb889c09a69e7c5cbf9330e5d9917d6ab3ac3dc5\nCloses-Bug: #1818560\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/73fc1df5f21147835058a27efe00ca6596320610"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/73fc1df5f21147835058a27efe00ca6596320610"}]},"branch":"refs/heads/master"},"bcbc623868c2e7419e9dd6fff2dc12047553c494":{"kind":"REWORK","_number":4,"created":"2019-03-11 19:36:46.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/87/640887/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/640887/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/640887/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/640887/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/640887/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/640887/4"}}},"commit":{"parents":[{"commit":"c43c1d3fb9da5dd0a13e1f15623a696212f095ff","subject":"Merge \"libvirt: Omit needless check on \u0027CONF.serial_console\u0027\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c43c1d3fb9da5dd0a13e1f15623a696212f095ff"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-04 22:08:39.000000000","tz":-360},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-11 19:21:59.000000000","tz":-300},"subject":"Stop using PlacementDirect","message":"Stop using PlacementDirect\n\nPlacementDirect was integrated into a functional test suite when it was\nfirst created as a way to prove that it worked and demonstrate how to\nuse it.\n\nHowever, it was a pain then, because the interceptor needs to be created\nevery time you want to use it; and since extracted placement started\ndiverging from in-tree placement, other problems started cropping up\n(see the associated bug).\n\nSo this commit removes the use of PlacementDirect from nova. Details:\n\n- test_report_client now uses PlacementFixture. So all the `with\n  interceptor` context management is gone. This accounts for the vast\n  majority of the apparent change, which is just outdenting those\n  contexts.\n- SchedulerReportClientTestBase, which was doing some hocus pocus to\n  wrap the SchedulerReportClient such that we could do some microversion\n  checks, is removed. The test suite simply instantiates the\n  microversion-checking wrapper class directly as the client used by the\n  test cases.\n- We were taking advantage of a PlacementDirect feature allowing us to\n  default to the latest microversion if not explicitly specified in the\n  request. Without this, we had to add the `version` kwarg to some of\n  the calls we were making to SchedulerReportClient primitives\n  (get/put/post/delete).\n- A piece of test_update_from_provider_tree was using a\n  deliberately-broken interceptor to prove that the code in question\n  wasn\u0027t hitting the API. We replace this with a non-callable mock on\n  the Adapter\u0027s request method.\n- test_global_request_id was taking advantage of the interceptor to\n  validate that the global request ID was making it to the \"other side\"\n  of the API boundary. This was fun, but overkill. We now simply assert\n  that the correct HTTP header is making it into the ksa Adapter\u0027s\n  request method.\n- Functional test suite test_resource_tracker.IronicResourceTrackerTest\n  was inheriting from the SchedulerReportClientTestBase class, but not\n  using the interceptor anywhere. Can\u0027t tell you why that was done. So\n  now it just uses the plain old test.TestCase like everyone else.\n\nChange-Id: Icb889c09a69e7c5cbf9330e5d9917d6ab3ac3dc5\nRelated-Bug: #1818560\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bcbc623868c2e7419e9dd6fff2dc12047553c494"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bcbc623868c2e7419e9dd6fff2dc12047553c494"}]},"branch":"refs/heads/master"},"b25ea3d54bfffbc015a0eb1853154e27788e9f99":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2019-03-11 21:05:07.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/87/640887/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/640887/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/640887/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/640887/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/640887/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/640887/5"}}},"commit":{"parents":[{"commit":"c43c1d3fb9da5dd0a13e1f15623a696212f095ff","subject":"Merge \"libvirt: Omit needless check on \u0027CONF.serial_console\u0027\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c43c1d3fb9da5dd0a13e1f15623a696212f095ff"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-04 22:08:39.000000000","tz":-360},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-11 21:05:05.000000000","tz":0},"subject":"Stop using PlacementDirect","message":"Stop using PlacementDirect\n\nPlacementDirect was integrated into a functional test suite when it was\nfirst created as a way to prove that it worked [1] and demonstrate how\nto use it.\n\nHowever, it was a pain then, because the interceptor needs to be created\nevery time you want to use it; and since extracted placement started\ndiverging from in-tree placement, other problems started cropping up\n(see the associated bug).\n\nSo this commit removes the use of PlacementDirect from nova. Details:\n\n- test_report_client now uses PlacementFixture. So all the `with\n  interceptor` context management is gone. This accounts for the vast\n  majority of the apparent change, which is just outdenting those\n  contexts.\n- SchedulerReportClientTestBase, which was doing some hocus pocus to\n  wrap the SchedulerReportClient such that we could do some microversion\n  checks, is removed. The test suite simply instantiates the\n  microversion-checking wrapper class directly as the client used by the\n  test cases.\n- We were taking advantage of a PlacementDirect feature allowing us to\n  default to the latest microversion if not explicitly specified in the\n  request. Without this, we had to add the `version` kwarg to some of\n  the calls we were making to SchedulerReportClient primitives\n  (get/put/post/delete).\n- A piece of test_update_from_provider_tree was using a\n  deliberately-broken interceptor to prove that the code in question\n  wasn\u0027t hitting the API. We replace this with a non-callable mock on\n  the Adapter\u0027s request method.\n- test_global_request_id was taking advantage of the interceptor to\n  validate that the global request ID was making it to the \"other side\"\n  of the API boundary. This was fun, but overkill. We now simply assert\n  that the correct HTTP header is making it into the ksa Adapter\u0027s\n  request method.\n- Functional test suite test_resource_tracker.IronicResourceTrackerTest\n  was inheriting from the SchedulerReportClientTestBase class, but not\n  using the interceptor anywhere. Can\u0027t tell you why that was done. So\n  now it just uses the plain old test.TestCase like everyone else.\n\n[1] This commit does remove all of nova\u0027s testing of PlacementDirect.\nHowever, it is still tested in the placement repository itself:\nhttps://github.com/openstack/placement/blob/69b9659a457b6d715ed47e6bd6d3b923d548c620/placement/tests/functional/test_direct.py\n\nChange-Id: Icb889c09a69e7c5cbf9330e5d9917d6ab3ac3dc5\nRelated-Bug: #1818560\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b25ea3d54bfffbc015a0eb1853154e27788e9f99"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b25ea3d54bfffbc015a0eb1853154e27788e9f99"}]},"branch":"refs/heads/master"},"f2d088b04e6e6896f0df04f03e92b32a539b6917":{"kind":"REWORK","_number":6,"created":"2020-03-05 13:36:43.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/87/640887/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/640887/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/640887/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/640887/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/640887/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/640887/6"}}},"commit":{"parents":[{"commit":"19cbbbebddadb125b8123ce0350b7146b29a59c6","subject":"Merge \"libvirt: Remove native LUKS compat code\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/19cbbbebddadb125b8123ce0350b7146b29a59c6"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-03-04 22:08:39.000000000","tz":-360},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2020-03-05 13:36:37.000000000","tz":-360},"subject":"Stop using PlacementDirect","message":"Stop using PlacementDirect\n\nPlacementDirect was integrated into a functional test suite when it was\nfirst created as a way to prove that it worked [1] and demonstrate how\nto use it.\n\nHowever, it was a pain then, because the interceptor needs to be created\nevery time you want to use it; and since extracted placement started\ndiverging from in-tree placement, other problems started cropping up\n(see the associated bug).\n\nSo this commit removes the use of PlacementDirect from nova. Details:\n\n- test_report_client now uses PlacementFixture. So all the `with\n  interceptor` context management is gone. This accounts for the vast\n  majority of the apparent change, which is just outdenting those\n  contexts.\n- SchedulerReportClientTestBase, which was doing some hocus pocus to\n  wrap the SchedulerReportClient such that we could do some microversion\n  checks, is removed. The test suite simply instantiates the\n  microversion-checking wrapper class directly as the client used by the\n  test cases.\n- We were taking advantage of a PlacementDirect feature allowing us to\n  default to the latest microversion if not explicitly specified in the\n  request. Without this, we had to add the `version` kwarg to some of\n  the calls we were making to SchedulerReportClient primitives\n  (get/put/post/delete).\n- A piece of test_update_from_provider_tree was using a\n  deliberately-broken interceptor to prove that the code in question\n  wasn\u0027t hitting the API. We replace this with a non-callable mock on\n  the Adapter\u0027s request method.\n- test_global_request_id was taking advantage of the interceptor to\n  validate that the global request ID was making it to the \"other side\"\n  of the API boundary. This was fun, but overkill. We now simply assert\n  that the correct HTTP header is making it into the ksa Adapter\u0027s\n  request method.\n- Functional test suite test_resource_tracker.IronicResourceTrackerTest\n  was inheriting from the SchedulerReportClientTestBase class, but not\n  using the interceptor anywhere. Can\u0027t tell you why that was done. So\n  now it just uses the plain old test.TestCase like everyone else.\n\n[1] This commit does remove all of nova\u0027s testing of PlacementDirect.\nHowever, it is still tested in the placement repository itself:\nhttps://github.com/openstack/placement/blob/69b9659a457b6d715ed47e6bd6d3b923d548c620/placement/tests/functional/test_direct.py\n\nChange-Id: Icb889c09a69e7c5cbf9330e5d9917d6ab3ac3dc5\nRelated-Bug: #1818560\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f2d088b04e6e6896f0df04f03e92b32a539b6917"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f2d088b04e6e6896f0df04f03e92b32a539b6917"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}