)]}'
{"nova/rpc/__init__.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"10c088152fd3906f7a3472a45d7536f8e626552b","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    :returns: An instance of nova.rpc.common.Connection"},{"line_number":61,"context_line":"    \"\"\""},{"line_number":62,"context_line":"    global _CONF"},{"line_number":63,"context_line":"    return _get_impl().create_connection(_CONF, new\u003dnew)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAFX%2F%2F%2ByQ%3D","line":62,"updated":"2012-04-10 15:52:51.000000000","message":"You\u0027re not changing _CONF\u0027s value by assignment, so the \u0027global\u0027 statement is not needed.  Same for most of the rest of the usages below.","commit_id":"db8105321cf1841a6963be7ecb06074015a5c58c"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"e6db52a41f3b99f4c7e754567d975ed8f697cb0e","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    :returns: An instance of nova.rpc.common.Connection"},{"line_number":61,"context_line":"    \"\"\""},{"line_number":62,"context_line":"    global _CONF"},{"line_number":63,"context_line":"    return _get_impl().create_connection(_CONF, new\u003dnew)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAFX%2F%2F%2Bww%3D","line":62,"in_reply_to":"AAAAFX%2F%2F%2ByQ%3D","updated":"2012-04-10 16:21:13.000000000","message":"Done","commit_id":"db8105321cf1841a6963be7ecb06074015a5c58c"}],"nova/rpc/amqp.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"dcb62106ca9d7446dcec6ff14cbd74bcd3351ec4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":49,"context_line":"        self.connection_cls \u003d kwargs.pop(\"connection_cls\", None)"},{"line_number":50,"context_line":"        self.conf \u003d kwargs.pop(\"conf\", None)"},{"line_number":51,"context_line":"        kwargs.setdefault(\"max_size\", self.conf.rpc_conn_pool_size)"},{"line_number":52,"context_line":"        kwargs.setdefault(\"order_as_stack\", True)"},{"line_number":53,"context_line":"        super(Pool, self).__init__(*args, **kwargs)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAFX%2F%2F%2BRE%3D","line":51,"updated":"2012-04-11 07:12:58.000000000","message":"conf is required so why not make it first positional argument to __init__?   (The \u0027None\u0027 in the pop() doesn\u0027t really do anything, since we\u0027d traceback on this line if it doesn\u0027t exist in kwargs.)","commit_id":"1c9d85e3017e035ec322f254047582f2f5f4ec65"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"dcb62106ca9d7446dcec6ff14cbd74bcd3351ec4","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    the pool."},{"line_number":86,"context_line":"    \"\"\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def __init__(self, connection_pool, conf, pooled\u003dTrue, server_params\u003dNone):"},{"line_number":89,"context_line":"        \"\"\"Create a new connection, or get one from the pool\"\"\""},{"line_number":90,"context_line":"        self.connection \u003d None"},{"line_number":91,"context_line":"        self.conf \u003d conf"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAFX%2F%2F%2BQk%3D","line":88,"updated":"2012-04-11 07:12:58.000000000","message":"conf isn\u0027t strictly required to be added here, because you could get it from connection_pool.conf.... although I\u0027m fine with leaving it.","commit_id":"1c9d85e3017e035ec322f254047582f2f5f4ec65"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"dcb62106ca9d7446dcec6ff14cbd74bcd3351ec4","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    \"\"\"Context that supports replying to a rpc.call\"\"\""},{"line_number":175,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":176,"context_line":"        self.msg_id \u003d kwargs.pop(\u0027msg_id\u0027, None)"},{"line_number":177,"context_line":"        self.conf \u003d kwargs.pop(\u0027conf\u0027, None)"},{"line_number":178,"context_line":"        super(RpcContext, self).__init__(*args, **kwargs)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def reply(self, reply\u003dNone, failure\u003dNone, ending\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAFX%2F%2F%2BQQ%3D","line":177,"updated":"2012-04-11 07:12:58.000000000","message":"I\u0027d drop the \u0027, None\u0027 on this... since conf is required and it\u0027ll always be there because of line 200 below anyway.  I\u0027d rather it fail fast here if for some reason there is some sort of problem in the future.","commit_id":"1c9d85e3017e035ec322f254047582f2f5f4ec65"}],"nova/rpc/impl_kombu.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"10c088152fd3906f7a3472a45d7536f8e626552b","unresolved":false,"context_lines":[{"line_number":664,"context_line":"_pool_create_sem \u003d eventlet.semaphore.Semaphore()"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"def _get_connection_pool(conf):"},{"line_number":668,"context_line":"    with _pool_create_sem:"},{"line_number":669,"context_line":"        # Make sure only one thread tries to create the connection pool."},{"line_number":670,"context_line":"        if not Connection.pool:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAFX%2F%2F%2ByE%3D","line":667,"updated":"2012-04-10 15:52:51.000000000","message":"Is there any way to abstract this out into rpc.common (or whatever) so we can gain more DRY compliance?","commit_id":"db8105321cf1841a6963be7ecb06074015a5c58c"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"e6db52a41f3b99f4c7e754567d975ed8f697cb0e","unresolved":false,"context_lines":[{"line_number":664,"context_line":"_pool_create_sem \u003d eventlet.semaphore.Semaphore()"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"def _get_connection_pool(conf):"},{"line_number":668,"context_line":"    with _pool_create_sem:"},{"line_number":669,"context_line":"        # Make sure only one thread tries to create the connection pool."},{"line_number":670,"context_line":"        if not Connection.pool:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAFX%2F%2F%2Bws%3D","line":667,"in_reply_to":"AAAAFX%2F%2F%2ByE%3D","updated":"2012-04-10 16:21:13.000000000","message":"Good idea.  Done in rev2.","commit_id":"db8105321cf1841a6963be7ecb06074015a5c58c"}]}