)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c1cf721be7f104cb209bf145a63222ae7a17d042","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2013-12-26 14:51:04 +0900"},{"line_number":4,"context_line":"Commit:     Eiich Aikawa \u003caikawa@mxk.nes.nec.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-26 15:13:49 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"API schema for v3 get_console_output API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By defining the API schema, it is possible to separate the validation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2Fuek%3D","line":6,"updated":"2014-01-09 06:01:13.000000000","message":"s/get_console_output/console_output/ like the other patches.","commit_id":"fa9ceadba9925bccb214e383c3d7eaea3378be28"},{"author":{"_account_id":9533,"name":"Eiichi Aikawa","email":"aikawa@mxk.nes.nec.co.jp","username":"EiichiAikawa"},"change_message_id":"9c6e62fe064b81476b5950d97af2de836bea78d1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2013-12-26 14:51:04 +0900"},{"line_number":4,"context_line":"Commit:     Eiich Aikawa \u003caikawa@mxk.nes.nec.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-26 15:13:49 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"API schema for v3 get_console_output API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By defining the API schema, it is possible to separate the validation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2FuWg%3D","line":6,"in_reply_to":"AAAAUH%2F%2Fuek%3D","updated":"2014-01-09 06:37:07.000000000","message":"Thanks. I will change it like others.","commit_id":"fa9ceadba9925bccb214e383c3d7eaea3378be28"}],"nova/api/openstack/compute/plugins/v3/console_output.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"40c61647fb2b77fcedf4b147d5799f1960e87cce","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import re"},{"line_number":20,"context_line":"import webob"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from nova.api.openstack.compute.schemas.v3 import get_console_output_schema"},{"line_number":24,"context_line":"from nova.api.openstack import extensions"},{"line_number":25,"context_line":"from nova.api.openstack import wsgi"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2F9xY%3D","line":22,"updated":"2013-12-26 06:49:30.000000000","message":"a new line is not necessary.","commit_id":"fa9ceadba9925bccb214e383c3d7eaea3378be28"},{"author":{"_account_id":9533,"name":"Eiichi Aikawa","email":"aikawa@mxk.nes.nec.co.jp","username":"EiichiAikawa"},"change_message_id":"9c6e62fe064b81476b5950d97af2de836bea78d1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import re"},{"line_number":20,"context_line":"import webob"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from nova.api.openstack.compute.schemas.v3 import get_console_output_schema"},{"line_number":24,"context_line":"from nova.api.openstack import extensions"},{"line_number":25,"context_line":"from nova.api.openstack import wsgi"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2F9TM%3D","line":22,"in_reply_to":"AAAAT3%2F%2F9xY%3D","updated":"2014-01-09 06:37:07.000000000","message":"Thanks. I will remove this new blank line.","commit_id":"fa9ceadba9925bccb214e383c3d7eaea3378be28"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5df8a5828f551bab18ee1dc918dd00305e402df7","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    @extensions.expected_errors((400, 404, 409, 501))"},{"line_number":40,"context_line":"    @wsgi.action(\u0027get_console_output\u0027)"},{"line_number":41,"context_line":"    @validation.schema(request_body_schema\u003d"},{"line_number":42,"context_line":"                       get_console_output_schema.get_console_output)"},{"line_number":43,"context_line":"    def get_console_output(self, req, id, body):"},{"line_number":44,"context_line":"        \"\"\"Get text console output.\"\"\""},{"line_number":45,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FfZc%3D","line":42,"updated":"2014-01-13 11:36:31.000000000","message":"request_body_schema should be removed, and the module name get_console_output_schema.py should be renamed to console_output.py.\n(get_ also is unnecessary.)\n\n\nref: http://lists.openstack.org/pipermail/openstack-dev/2014-January/024067.html","commit_id":"ae528d97067e0259b63452e2447bb975c5f7074b"}],"nova/api/openstack/compute/schemas/v3/console_output.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"938c264ad113904e7cde4096674c005688217a92","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                    \u0027minimum\u0027: 0,"},{"line_number":24,"context_line":"                    \u0027pattern\u0027: \u0027^[0-9]+$\u0027,"},{"line_number":25,"context_line":"                },"},{"line_number":26,"context_line":"            },"},{"line_number":27,"context_line":"        },"},{"line_number":28,"context_line":"    },"},{"line_number":29,"context_line":"    \u0027required\u0027: [\u0027get_console_output\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FZ1w%3D","line":26,"updated":"2014-01-14 04:02:21.000000000","message":"Sorry, here needs:\n\n \u0027additionalProperties\u0027: False,","commit_id":"2930053d3ea950e86e04ae153503ec8d62985f13"},{"author":{"_account_id":9533,"name":"Eiichi Aikawa","email":"aikawa@mxk.nes.nec.co.jp","username":"EiichiAikawa"},"change_message_id":"f5a4182d4a5d64f903a4816ae9d578a0fcc5dc31","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                    \u0027minimum\u0027: 0,"},{"line_number":24,"context_line":"                    \u0027pattern\u0027: \u0027^[0-9]+$\u0027,"},{"line_number":25,"context_line":"                },"},{"line_number":26,"context_line":"            },"},{"line_number":27,"context_line":"        },"},{"line_number":28,"context_line":"    },"},{"line_number":29,"context_line":"    \u0027required\u0027: [\u0027get_console_output\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FZz0%3D","line":26,"in_reply_to":"AAAAUH%2F%2FZ1w%3D","updated":"2014-01-14 04:16:45.000000000","message":"Done","commit_id":"2930053d3ea950e86e04ae153503ec8d62985f13"}],"nova/tests/api/openstack/compute/plugins/v3/test_console_output.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"40c61647fb2b77fcedf4b147d5799f1960e87cce","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        res \u003d req.get_response(self.app)"},{"line_number":146,"context_line":"        self.assertEqual(res.status_int, 501)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def test_get_console_output_with_under_zero_for_length(self):"},{"line_number":149,"context_line":"        req \u003d self._create_request(length_dict\u003d{\u0027length\u0027: -1})"},{"line_number":150,"context_line":"        res \u003d req.get_response(self.app)"},{"line_number":151,"context_line":"        self.assertEqual(res.status_int, 400)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2F9xM%3D","line":148,"updated":"2013-12-26 06:49:30.000000000","message":"nit: How about just \"_with_negative_length\" instead of \"_with_under_zero_for_length\"?","commit_id":"fa9ceadba9925bccb214e383c3d7eaea3378be28"},{"author":{"_account_id":9533,"name":"Eiichi Aikawa","email":"aikawa@mxk.nes.nec.co.jp","username":"EiichiAikawa"},"change_message_id":"9c6e62fe064b81476b5950d97af2de836bea78d1","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        res \u003d req.get_response(self.app)"},{"line_number":146,"context_line":"        self.assertEqual(res.status_int, 501)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def test_get_console_output_with_under_zero_for_length(self):"},{"line_number":149,"context_line":"        req \u003d self._create_request(length_dict\u003d{\u0027length\u0027: -1})"},{"line_number":150,"context_line":"        res \u003d req.get_response(self.app)"},{"line_number":151,"context_line":"        self.assertEqual(res.status_int, 400)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2F7Is%3D","line":148,"in_reply_to":"AAAAT3%2F%2F9xM%3D","updated":"2014-01-09 06:37:07.000000000","message":"I will change this as your proposal.","commit_id":"fa9ceadba9925bccb214e383c3d7eaea3378be28"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"40c61647fb2b77fcedf4b147d5799f1960e87cce","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        res \u003d req.get_response(self.app)"},{"line_number":151,"context_line":"        self.assertEqual(res.status_int, 400)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def test_get_console_output_with_length_as_boolean(self):"},{"line_number":154,"context_line":"        req \u003d self._create_request(length_dict\u003d{\u0027length\u0027: True})"},{"line_number":155,"context_line":"        res \u003d req.get_response(self.app)"},{"line_number":156,"context_line":"        self.assertEqual(res.status_int, 400)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2F9xI%3D","line":153,"updated":"2013-12-26 06:49:30.000000000","message":"nit: How about \"_with_boolean_length\" ?","commit_id":"fa9ceadba9925bccb214e383c3d7eaea3378be28"},{"author":{"_account_id":9533,"name":"Eiichi Aikawa","email":"aikawa@mxk.nes.nec.co.jp","username":"EiichiAikawa"},"change_message_id":"9c6e62fe064b81476b5950d97af2de836bea78d1","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        res \u003d req.get_response(self.app)"},{"line_number":151,"context_line":"        self.assertEqual(res.status_int, 400)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def test_get_console_output_with_length_as_boolean(self):"},{"line_number":154,"context_line":"        req \u003d self._create_request(length_dict\u003d{\u0027length\u0027: True})"},{"line_number":155,"context_line":"        res \u003d req.get_response(self.app)"},{"line_number":156,"context_line":"        self.assertEqual(res.status_int, 400)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2F7Io%3D","line":153,"in_reply_to":"AAAAT3%2F%2F9xI%3D","updated":"2014-01-09 06:37:07.000000000","message":"I will change this as your proposal.","commit_id":"fa9ceadba9925bccb214e383c3d7eaea3378be28"}]}
