)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c635418c1a109381c20c91b5d1b6070304414968","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit 525631d8dc058910728e55def616358b0e7f2f69."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This change could potentially leave us with an empty file in the image"},{"line_number":12,"context_line":"cache, which would result in failure to spawn for any subsequent"},{"line_number":13,"context_line":"instance using the same image and image cache. This situation can only"},{"line_number":14,"context_line":"be recovered by manually deleting the file from the image cache. Until"},{"line_number":15,"context_line":"we can determine the root cause we should do something safer, like"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_baafec92","line":12,"range":{"start_line":11,"start_character":12,"end_line":12,"end_character":5},"updated":"2019-03-07 03:04:22.000000000","message":"May I ask how? Is there a open bug associated with this that explains in more detail?\n\nEither way, seems like a major problem and probably worth a revert. It sounds like this bug is worse than the bug the patch originally fixed.","commit_id":"e65a5275eeecae6ab041db2f089ae5dc3eefd92c"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"3e1309a9c6d11910dff54448c00b9dc336b2ed87","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit 525631d8dc058910728e55def616358b0e7f2f69."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This change could potentially leave us with an empty file in the image"},{"line_number":12,"context_line":"cache, which would result in failure to spawn for any subsequent"},{"line_number":13,"context_line":"instance using the same image and image cache. This situation can only"},{"line_number":14,"context_line":"be recovered by manually deleting the file from the image cache. Until"},{"line_number":15,"context_line":"we can determine the root cause we should do something safer, like"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_ff51de0f","line":12,"range":{"start_line":11,"start_character":12,"end_line":12,"end_character":5},"in_reply_to":"5fc1f717_baafec92","updated":"2019-03-07 10:43:19.000000000","message":"The problem isn\u0027t that this *will* occur. In fact a couple of people have tested this and say that it doesn\u0027t in practise, at least on their NFS setups. However, the problem we\u0027re trying to workaround, referenced in the original commit, isn\u0027t understood at all. Nobody currently knows *why* this works and doesn\u0027t cause problems. My concern is that while this appears to work for reasons we don\u0027t understand on NFS, its obvious effect is still wrong in the absence of NFS weirdness: it will create an empty file if called on a path which doesn\u0027t exist. As we really don\u0027t want that to ever happen, especially in the image cache, this is the wrong workaround for a problem we don\u0027t understand.\n\nRather than breaking the semantics of a library call with unpredictable consequences, by patching the call site instead we can reduce the scope of the workaround to only the case which we know to be failing.\n\nThis workaround introduces a significant risk of regressions, and we should pick something safer. The other proposed fix for this problem is safer, as it won\u0027t do anything unexpected on normal filesystems.","commit_id":"e65a5275eeecae6ab041db2f089ae5dc3eefd92c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ed867a2cc19d1a8151fb9e77b95d7a8e08976628","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit 525631d8dc058910728e55def616358b0e7f2f69."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This change could potentially leave us with an empty file in the image"},{"line_number":12,"context_line":"cache, which would result in failure to spawn for any subsequent"},{"line_number":13,"context_line":"instance using the same image and image cache. This situation can only"},{"line_number":14,"context_line":"be recovered by manually deleting the file from the image cache. Until"},{"line_number":15,"context_line":"we can determine the root cause we should do something safer, like"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_e21e220b","line":12,"range":{"start_line":11,"start_character":12,"end_line":12,"end_character":5},"in_reply_to":"5fc1f717_ff51de0f","updated":"2019-03-07 12:39:17.000000000","message":"Thank you for the detailed explanation.","commit_id":"e65a5275eeecae6ab041db2f089ae5dc3eefd92c"}]}