)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4992ce56729bcc14d0490fe3bd8d415844116f9a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"how migration status error handling worked but at this point they"},{"line_number":13,"context_line":"are the same and if *anything* fails in finish_resize then the"},{"line_number":14,"context_line":"migration status should be \u0027error\u0027 rather than just if part of it"},{"line_number":15,"context_line":"fails."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id6c0a0ee41520dd974052d7cdd17ca35d688f6b0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_d30af188","line":15,"updated":"2019-03-06 17:42:28.000000000","message":"Will we need to add the decorator to prep_resize()?\nThe covered cases of this change is bigger than prep_resize() and it is worth to doing this. I just wanted to see the usage of both the decorator and the method.","commit_id":"08eaba7db861fb427b2ce7c3a7ac3c97887eeef3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3675e69f1cff876ad9200dd05e019ab94f0723b9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"how migration status error handling worked but at this point they"},{"line_number":13,"context_line":"are the same and if *anything* fails in finish_resize then the"},{"line_number":14,"context_line":"migration status should be \u0027error\u0027 rather than just if part of it"},{"line_number":15,"context_line":"fails."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id6c0a0ee41520dd974052d7cdd17ca35d688f6b0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_1bdc42e2","line":15,"in_reply_to":"5fc1f717_9b15929e","updated":"2019-03-28 14:59:53.000000000","message":"Conductor will set the migration status to \u0027error\u0027 if rescheduling fails during resize:\n\nhttps://github.com/openstack/nova/blob/73edcfae7d5ea498fd17fa8e548ae1bd690f408a/nova/conductor/tasks/migrate.py#L309","commit_id":"08eaba7db861fb427b2ce7c3a7ac3c97887eeef3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a305eea72b00b415f7e5295add80125b3a9610fe","unresolved":false,"context_lines":[{"line_number":12,"context_line":"how migration status error handling worked but at this point they"},{"line_number":13,"context_line":"are the same and if *anything* fails in finish_resize then the"},{"line_number":14,"context_line":"migration status should be \u0027error\u0027 rather than just if part of it"},{"line_number":15,"context_line":"fails."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id6c0a0ee41520dd974052d7cdd17ca35d688f6b0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_9b15929e","line":15,"in_reply_to":"5fc1f717_d30af188","updated":"2019-03-28 14:56:25.000000000","message":"No I don\u0027t think so because prep_resize can trigger a reschedule to another host if the resize_claim fails, so if we eventually fail the resize, conductor should set the migration status to error before raising MaxRetriesExceeded (granted I need to check to see that conductor is actually setting the migration status to error...it might not be).","commit_id":"08eaba7db861fb427b2ce7c3a7ac3c97887eeef3"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"96d556c912d990978919a532bfba97a09546daf6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"are the same and if *anything* fails in finish_resize then the"},{"line_number":14,"context_line":"migration status should be \u0027error\u0027 rather than just if part of it"},{"line_number":15,"context_line":"fails."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id6c0a0ee41520dd974052d7cdd17ca35d688f6b0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_27830607","line":16,"updated":"2019-03-05 22:24:45.000000000","message":"As mentioned previously [1], this should probably have a bug, as it may need to be backported to rocky and/or queens where the referenced change was landed.\n\n[1] https://review.openstack.org/#/c/635349/1/nova/compute/manager.py@4570","commit_id":"08eaba7db861fb427b2ce7c3a7ac3c97887eeef3"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"90695e312995feb34a6d658623fc8e6d63ccb231","unresolved":false,"context_lines":[{"line_number":13,"context_line":"are the same and if *anything* fails in finish_resize then the"},{"line_number":14,"context_line":"migration status should be \u0027error\u0027 rather than just if part of it"},{"line_number":15,"context_line":"fails."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id6c0a0ee41520dd974052d7cdd17ca35d688f6b0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_a26284d7","line":16,"in_reply_to":"5fc1f717_020fd82e","updated":"2019-03-05 22:52:17.000000000","message":"okaaaay, don\u0027t say I didn\u0027t warn you :P","commit_id":"08eaba7db861fb427b2ce7c3a7ac3c97887eeef3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a573d6759e8bbb92425986f226262960b631ee26","unresolved":false,"context_lines":[{"line_number":13,"context_line":"are the same and if *anything* fails in finish_resize then the"},{"line_number":14,"context_line":"migration status should be \u0027error\u0027 rather than just if part of it"},{"line_number":15,"context_line":"fails."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id6c0a0ee41520dd974052d7cdd17ca35d688f6b0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_020fd82e","line":16,"in_reply_to":"5fc1f717_27830607","updated":"2019-03-05 22:45:38.000000000","message":"I\u0027m not saying we need to backport this, nor am I super comfortable with backporting it since I\u0027d need to make sure all of the related changes still make sense. I\u0027m also not saying it\u0027s really a bug, unless someone hits a window where something fails between where that context manager was used before and the decorator is used now, like if notifications blow up or something. I mean, that could happen I guess, and in that case we really should be setting the migration to error status, but probability is low. Half of this change is just getting rid of the ugly nested context and using a cleaner method decorator that does the same thing.","commit_id":"08eaba7db861fb427b2ce7c3a7ac3c97887eeef3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8ead0a9a48615eedda1fcc36b5a3142195afd403","unresolved":false,"context_lines":[{"line_number":13,"context_line":"are the same and if *anything* fails in finish_resize then the"},{"line_number":14,"context_line":"migration status should be \u0027error\u0027 rather than just if part of it"},{"line_number":15,"context_line":"fails."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id6c0a0ee41520dd974052d7cdd17ca35d688f6b0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_b3099add","line":16,"in_reply_to":"5fc1f717_a26284d7","updated":"2019-07-01 18:34:24.000000000","message":"Heh turns out I could use this in stable/stein to make a functional test I\u0027m trying to backport not race:\n\nhttps://review.opendev.org/#/c/666959/1/nova/tests/functional/regressions/test_bug_1825537.py@51","commit_id":"08eaba7db861fb427b2ce7c3a7ac3c97887eeef3"}]}