)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d98bf7a9b9d18fc5232237fa67976de48de1c2a0","unresolved":false,"context_lines":[{"line_number":477,"context_line":"            flavorid \u003d instance_type.flavorid if instance_type else None"},{"line_number":478,"context_line":"            LOG.info(\u0027Dropping move claim on node %s for tracked \u0027"},{"line_number":479,"context_line":"                     \u0027migration %s with flavor %s.\u0027,"},{"line_number":480,"context_line":"                     migration.uuid, nodename, flavorid, instance\u003dinstance)"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"            if instance_type is not None:"},{"line_number":483,"context_line":"                numa_topology \u003d self._get_migration_context_resource("}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_b934fadf","line":480,"range":{"start_line":480,"start_character":21,"end_line":480,"end_character":45},"updated":"2019-03-06 00:38:39.000000000","message":"These are in the wrong order.","commit_id":"e3d9f8056c9e3a2d23feef1fa80e0e5cc5f4e717"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"681a87ee2f6b1871317ae0415244dff4ab9fa020","unresolved":false,"context_lines":[{"line_number":499,"context_line":"                     \u0027instance with flavor %s.\u0027, nodename, flavorid,"},{"line_number":500,"context_line":"                     instance\u003dinstance)"},{"line_number":501,"context_line":"            self.tracked_instances.remove(instance[\u0027uuid\u0027])"},{"line_number":502,"context_line":"            self._drop_pci_devices(instance, nodename, prefix)"},{"line_number":503,"context_line":"            # TODO(lbeliveau): Validate if numa needs the same treatment."},{"line_number":504,"context_line":"            # FIXME(mriedem): Why doesn\u0027t this path call"},{"line_number":505,"context_line":"            # self._update_usage(usage, nodename, sign\u003d-1)? Otherwise it\u0027s"},{"line_number":506,"context_line":"            # not reflecting updated usage for the removed instance until the"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_5913960e","line":503,"range":{"start_line":502,"start_character":12,"end_line":503,"end_character":73},"updated":"2019-03-06 00:54:45.000000000","message":"This was left from https://review.openstack.org/#/c/370374/ and yeah it looks like we should also be updating usage in here. The reasoning in that change for this was \"So in this case the PCI devices were only freed on the next periodic audit. For PCI resources such as PCI passthrough, those are limited in number and should be freed right away.\" That\u0027s the exact same issue I\u0027m seeing with cross-cell resize functional testing, so it\u0027s just a latent bug.","commit_id":"d3fd7c2a7d04aa3a39dca48fe76bcc32f1de0be1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"95d77bc285c92a664b6b926fa2a31bb391605e0d","unresolved":false,"context_lines":[{"line_number":499,"context_line":"                     \u0027instance with flavor %s.\u0027, nodename, flavorid,"},{"line_number":500,"context_line":"                     instance\u003dinstance)"},{"line_number":501,"context_line":"            self.tracked_instances.remove(instance[\u0027uuid\u0027])"},{"line_number":502,"context_line":"            self._drop_pci_devices(instance, nodename, prefix)"},{"line_number":503,"context_line":"            # TODO(lbeliveau): Validate if numa needs the same treatment."},{"line_number":504,"context_line":"            # FIXME(mriedem): Why doesn\u0027t this path call"},{"line_number":505,"context_line":"            # self._update_usage(usage, nodename, sign\u003d-1)? Otherwise it\u0027s"},{"line_number":506,"context_line":"            # not reflecting updated usage for the removed instance until the"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_59e156fe","line":503,"range":{"start_line":502,"start_character":12,"end_line":503,"end_character":73},"in_reply_to":"5fc1f717_5913960e","updated":"2019-03-06 00:58:02.000000000","message":"Note that StarlingX has already fixed this:\n\nhttps://github.com/starlingx-staging/stx-nova/blob/master/nova/compute/resource_tracker.py#L728","commit_id":"d3fd7c2a7d04aa3a39dca48fe76bcc32f1de0be1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ac9e24bf6633f21cfc98f5d03cc0be17c9fcbb7d","unresolved":false,"context_lines":[{"line_number":499,"context_line":"                     \u0027instance with flavor %s.\u0027, nodename, flavorid,"},{"line_number":500,"context_line":"                     instance\u003dinstance)"},{"line_number":501,"context_line":"            self.tracked_instances.remove(instance[\u0027uuid\u0027])"},{"line_number":502,"context_line":"            self._drop_pci_devices(instance, nodename, prefix)"},{"line_number":503,"context_line":"            # TODO(lbeliveau): Validate if numa needs the same treatment."},{"line_number":504,"context_line":"            # FIXME(mriedem): Why doesn\u0027t this path call"},{"line_number":505,"context_line":"            # self._update_usage(usage, nodename, sign\u003d-1)? Otherwise it\u0027s"},{"line_number":506,"context_line":"            # not reflecting updated usage for the removed instance until the"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_fa625916","line":503,"range":{"start_line":502,"start_character":12,"end_line":503,"end_character":73},"in_reply_to":"5fc1f717_59e156fe","updated":"2019-03-06 21:57:27.000000000","message":"Reported bug 1818914 for this.","commit_id":"d3fd7c2a7d04aa3a39dca48fe76bcc32f1de0be1"}]}