)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b0cbad9be96a012c72bd81450cdf135dbfa9b592","unresolved":false,"context_lines":[{"line_number":7,"context_line":"De-cruft compute manager live migration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is pretty basic and only does two things:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1. Uses the errors_out_migration decorator on the"},{"line_number":12,"context_line":"   live_migration method so that any errors in that"},{"line_number":13,"context_line":"   method will result in the migration status changing"},{"line_number":14,"context_line":"   to \u0027error\u0027 rather than only RuntimeErrors."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"2. Since we dropped RPC 4.x compability the MigrateData"},{"line_number":17,"context_line":"   parameter to _do_live_migration is required, so drop"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_311c8c69","line":14,"range":{"start_line":10,"start_character":0,"end_line":14,"end_character":45},"updated":"2019-03-06 19:25:51.000000000","message":"this will just trigger a rollback of the migration\nright? i wont put the vm to error state just the migration task","commit_id":"a0c97f7fe7d0ff5af39670ac70e6eded4a5c0428"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"29ff86d2455653e863785295645daa8c4f1fa4f1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"De-cruft compute manager live migration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is pretty basic and only does two things:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1. Uses the errors_out_migration decorator on the"},{"line_number":12,"context_line":"   live_migration method so that any errors in that"},{"line_number":13,"context_line":"   method will result in the migration status changing"},{"line_number":14,"context_line":"   to \u0027error\u0027 rather than only RuntimeErrors."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"2. Since we dropped RPC 4.x compability the MigrateData"},{"line_number":17,"context_line":"   parameter to _do_live_migration is required, so drop"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_fabb39e2","line":14,"range":{"start_line":10,"start_character":0,"end_line":14,"end_character":45},"in_reply_to":"5fc1f717_311c8c69","updated":"2019-03-06 21:38:23.000000000","message":"The decorator sets the migration.status to \u0027error\u0027 if there is a not-None migration in the method signature (which there is in this case). I wouldn\u0027t use the word \u0027rollback\u0027 here to avoid confusion the _rollback_live_migration method.","commit_id":"a0c97f7fe7d0ff5af39670ac70e6eded4a5c0428"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"45bbe2f6dec0d83613ce25b1e1bc30c14843b7ef","unresolved":false,"context_lines":[{"line_number":13,"context_line":"   method will result in the migration status changing"},{"line_number":14,"context_line":"   to \u0027error\u0027 rather than only RuntimeErrors."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"2. Since we dropped RPC 4.x compability the MigrateData"},{"line_number":17,"context_line":"   parameter to _do_live_migration is required, so drop"},{"line_number":18,"context_line":"   a condition on it being None and also DRY up and"},{"line_number":19,"context_line":"   comment on setting migrate_data.migration which is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_1c2cea48","line":16,"range":{"start_line":16,"start_character":3,"end_line":16,"end_character":39},"updated":"2019-04-02 18:35:27.000000000","message":"where?","commit_id":"a0c97f7fe7d0ff5af39670ac70e6eded4a5c0428"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b0cbad9be96a012c72bd81450cdf135dbfa9b592","unresolved":false,"context_lines":[{"line_number":6306,"context_line":"        mock_get_uuid.return_value \u003d fake_bdms"},{"line_number":6307,"context_line":""},{"line_number":6308,"context_line":"        # start test"},{"line_number":6309,"context_line":"        migration \u003d objects.Migration(c, uuid\u003duuids.migration)"},{"line_number":6310,"context_line":""},{"line_number":6311,"context_line":"        @mock.patch.object(self.compute.network_api, \u0027setup_networks_on_host\u0027)"},{"line_number":6312,"context_line":"        @mock.patch.object(self.compute, \u0027reportclient\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_f127e4b5","line":6309,"range":{"start_line":6309,"start_character":38,"end_line":6309,"end_character":40},"updated":"2019-03-06 19:25:51.000000000","message":"what is c.\nlater: oh its the admin context.\nterrible name but ok that is just a nit.","commit_id":"a0c97f7fe7d0ff5af39670ac70e6eded4a5c0428"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"45bbe2f6dec0d83613ce25b1e1bc30c14843b7ef","unresolved":false,"context_lines":[{"line_number":6306,"context_line":"        mock_get_uuid.return_value \u003d fake_bdms"},{"line_number":6307,"context_line":""},{"line_number":6308,"context_line":"        # start test"},{"line_number":6309,"context_line":"        migration \u003d objects.Migration(c, uuid\u003duuids.migration)"},{"line_number":6310,"context_line":""},{"line_number":6311,"context_line":"        @mock.patch.object(self.compute.network_api, \u0027setup_networks_on_host\u0027)"},{"line_number":6312,"context_line":"        @mock.patch.object(self.compute, \u0027reportclient\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_bc6ef693","line":6309,"range":{"start_line":6309,"start_character":38,"end_line":6309,"end_character":40},"in_reply_to":"5fc1f717_e16a97eb","updated":"2019-04-02 18:35:27.000000000","message":"fwiw, tests still pass if I revert the changes to the test modules.\n\nI guess it\u0027s good form to pass the context around, though.","commit_id":"a0c97f7fe7d0ff5af39670ac70e6eded4a5c0428"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"87c9f7617931e8de3f560d2fd7d7e79adfecb6f1","unresolved":false,"context_lines":[{"line_number":6306,"context_line":"        mock_get_uuid.return_value \u003d fake_bdms"},{"line_number":6307,"context_line":""},{"line_number":6308,"context_line":"        # start test"},{"line_number":6309,"context_line":"        migration \u003d objects.Migration(c, uuid\u003duuids.migration)"},{"line_number":6310,"context_line":""},{"line_number":6311,"context_line":"        @mock.patch.object(self.compute.network_api, \u0027setup_networks_on_host\u0027)"},{"line_number":6312,"context_line":"        @mock.patch.object(self.compute, \u0027reportclient\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_e16a97eb","line":6309,"range":{"start_line":6309,"start_character":38,"end_line":6309,"end_character":40},"in_reply_to":"5fc1f717_f127e4b5","updated":"2019-04-02 18:14:14.000000000","message":"These contexts are needed so the Migration can be saved back to the db by @errors_out_migration, right?","commit_id":"a0c97f7fe7d0ff5af39670ac70e6eded4a5c0428"}]}