)]}'
{"nova/virt/disk/mount/api.py":[{"author":{"_account_id":4912,"name":"Michael H Wilson","email":"geekinutah@gmail.com","username":"geekinutah"},"change_message_id":"38442697c1516ccb11693dfd3d215c4c8600907d","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        if not self.mounted:"},{"line_number":207,"context_line":"            return"},{"line_number":208,"context_line":"        # Flush file system buffers"},{"line_number":209,"context_line":"        utils.execute(\u0027sync\u0027, run_as_root\u003dTrue)"},{"line_number":210,"context_line":"        LOG.debug(_(\"Umount %s\") % self.mapped_device)"},{"line_number":211,"context_line":"        utils.execute(\u0027umount\u0027, self.mapped_device, run_as_root\u003dTrue)"},{"line_number":212,"context_line":"        self.mounted \u003d False"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAT3%2F%2F35k%3D","line":209,"updated":"2013-12-29 01:08:52.000000000","message":"I think it would be better to mount the nbd device with the sync option rather than calling sync before umount. My reasoning is that calling sync is going to flush _all_ block devices on a node rather than the one we really care about. As I understand it we only mount block devices to inject files, resize filesystems, etc. I think the performance degradation would be much less if this specific device\u0027s writes were synchronized rather than forcing a sync on all block device.","commit_id":"ee4faf29093b9357f003be33f2fb7ba64472dd53"}]}