)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"03bdee197cb1bc8503d3bc76f0fd0f9eac938065","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Check compute_node existence in when nova-compute reports info to placement"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If deleting service when nova-compute service is active, nova-compute will"},{"line_number":10,"context_line":"continue to report the old resource_provider uuid, this will raise"},{"line_number":11,"context_line":"ResourceProviderCreationFailed."},{"line_number":12,"context_line":"So add _get_compute_node in _update_to_placement to ensure compute_node existence."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dfbec78f_0bda8be8","line":10,"range":{"start_line":10,"start_character":23,"end_line":10,"end_character":49},"updated":"2019-05-03 18:54:05.000000000","message":"Why? Because of the ProviderTree cache in the ResourceTracker?\n\nAlso note that the nova-compute service should be stopped before deleting the service:\n\nhttps://developer.openstack.org/api-ref/compute/#delete-compute-service\n\nI know people might miss that though.","commit_id":"ea7a547c19fc1ae6587d440a856912cbae329120"}],"nova/compute/resource_tracker.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"809cc7748d81e7e8ba01445841b6a0be534fc346","unresolved":false,"context_lines":[{"line_number":950,"context_line":"        nodename \u003d compute_node.hypervisor_hostname"},{"line_number":951,"context_line":"        # Persist the stats to the Scheduler"},{"line_number":952,"context_line":"        # First check compute_node existence."},{"line_number":953,"context_line":"        if not self._get_compute_node(context, nodename):"},{"line_number":954,"context_line":"            return"},{"line_number":955,"context_line":"        # Try update_provider_tree"},{"line_number":956,"context_line":"        # Retrieve the provider tree associated with this compute node.  If"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_d9050b16","line":953,"range":{"start_line":953,"start_character":8,"end_line":953,"end_character":57},"updated":"2019-04-03 06:14:44.000000000","message":"I\u0027m a little confusing on which case you are trying to fix.\n\nAfter you delete the service and before restart the nova-compute, you will see the RP create failed exception when refresh the tree, this check can skip that refresh, but I\u0027m not sure this fix is meanful.\n\nAnother case is after you restart the nova-compute, you will see the same exception also, and this check is useless, since the nova-compute re-create the service db record again, and you will see the exception again.\n\nI think we should fix the second case, ensure the nova-compute can still works after restart.","commit_id":"ea7a547c19fc1ae6587d440a856912cbae329120"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8522da0342fd547f205500e9dca31424ff8a379e","unresolved":false,"context_lines":[{"line_number":951,"context_line":"        # Persist the stats to the Scheduler"},{"line_number":952,"context_line":"        # First check compute_node existence."},{"line_number":953,"context_line":"        if not self._get_compute_node(context, nodename):"},{"line_number":954,"context_line":"            return"},{"line_number":955,"context_line":"        # Try update_provider_tree"},{"line_number":956,"context_line":"        # Retrieve the provider tree associated with this compute node.  If"},{"line_number":957,"context_line":"        # it doesn\u0027t exist yet, this will create it with a (single, root)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_17d12530","line":954,"range":{"start_line":954,"start_character":12,"end_line":954,"end_character":18},"updated":"2019-04-02 19:24:53.000000000","message":"This should be a pretty unusual situation, shouldn\u0027t it? I would think we would want to log a warning here.","commit_id":"ea7a547c19fc1ae6587d440a856912cbae329120"}]}