)]}'
{"nova/tests/functional/test_servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"859154a389f883734c550c0c18fb9f4fb7725eb0","unresolved":false,"context_lines":[{"line_number":6465,"context_line":"        self.api.detach_interface("},{"line_number":6466,"context_line":"            server[\u0027id\u0027], self.neutron.port_with_resource_request[\u0027id\u0027])"},{"line_number":6467,"context_line":""},{"line_number":6468,"context_line":"        self._wait_for_port_unbind("},{"line_number":6469,"context_line":"            self.neutron, self.neutron.port_with_resource_request[\u0027id\u0027])"},{"line_number":6470,"context_line":""},{"line_number":6471,"context_line":"        updated_port \u003d self.neutron.show_port("}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_7c8dbc79","side":"PARENT","line":6468,"range":{"start_line":6468,"start_character":13,"end_line":6468,"end_character":34},"updated":"2019-03-11 13:46:49.000000000","message":"Is anything else using this method now or can we remove it also? Looks like this is the only usage:\n\nhttp://codesearch.openstack.org/?q\u003d_wait_for_port_unbind\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d\n\nNote you could keep this method but change it\u0027s implementation to be waiting for that versioned notification.","commit_id":"f853e04cd22acc36c906ffb29084160fa05d1ebd"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"47086b7572d2aec339a6bf79416533e061731f0b","unresolved":false,"context_lines":[{"line_number":6465,"context_line":"        self.api.detach_interface("},{"line_number":6466,"context_line":"            server[\u0027id\u0027], self.neutron.port_with_resource_request[\u0027id\u0027])"},{"line_number":6467,"context_line":""},{"line_number":6468,"context_line":"        self._wait_for_port_unbind("},{"line_number":6469,"context_line":"            self.neutron, self.neutron.port_with_resource_request[\u0027id\u0027])"},{"line_number":6470,"context_line":""},{"line_number":6471,"context_line":"        updated_port \u003d self.neutron.show_port("}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_dce710e4","side":"PARENT","line":6468,"range":{"start_line":6468,"start_character":13,"end_line":6468,"end_character":34},"in_reply_to":"5fc1f717_7c8dbc79","updated":"2019-03-11 14:26:54.000000000","message":"Good point, this was the only place the _wait_for_port_unbind was called.\n\nThe _wait_for_port_unbind can happen in other than detach cases so I\u0027d like to be explicit about what the test waits for.","commit_id":"f853e04cd22acc36c906ffb29084160fa05d1ebd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"859154a389f883734c550c0c18fb9f4fb7725eb0","unresolved":false,"context_lines":[{"line_number":5937,"context_line":"        self.neutron._subnets["},{"line_number":5938,"context_line":"            self.neutron.subnet_2[\u0027id\u0027]] \u003d self.neutron.subnet_2"},{"line_number":5939,"context_line":""},{"line_number":5940,"context_line":"        fake_notifier.stub_notifier(self)"},{"line_number":5941,"context_line":"        self.addCleanup(fake_notifier.reset)"},{"line_number":5942,"context_line":""},{"line_number":5943,"context_line":"    def _create_server(self, flavor, networks):"},{"line_number":5944,"context_line":"        server_req \u003d self._build_minimal_create_server_request("}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_fc81ac4b","line":5941,"range":{"start_line":5940,"start_character":8,"end_line":5941,"end_character":44},"updated":"2019-03-11 13:46:49.000000000","message":"This is already in the base class:\n\nhttp://git.openstack.org/cgit/openstack/nova/tree/nova/tests/functional/integrated_helpers.py#n414","commit_id":"e75b9d0bc938dd7c32dd9356ad62ead85c275866"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"47086b7572d2aec339a6bf79416533e061731f0b","unresolved":false,"context_lines":[{"line_number":5937,"context_line":"        self.neutron._subnets["},{"line_number":5938,"context_line":"            self.neutron.subnet_2[\u0027id\u0027]] \u003d self.neutron.subnet_2"},{"line_number":5939,"context_line":""},{"line_number":5940,"context_line":"        fake_notifier.stub_notifier(self)"},{"line_number":5941,"context_line":"        self.addCleanup(fake_notifier.reset)"},{"line_number":5942,"context_line":""},{"line_number":5943,"context_line":"    def _create_server(self, flavor, networks):"},{"line_number":5944,"context_line":"        server_req \u003d self._build_minimal_create_server_request("}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_fcea0caa","line":5941,"range":{"start_line":5940,"start_character":8,"end_line":5941,"end_character":44},"in_reply_to":"5fc1f717_fc81ac4b","updated":"2019-03-11 14:26:54.000000000","message":"Done","commit_id":"e75b9d0bc938dd7c32dd9356ad62ead85c275866"}]}